[wildfly-dev] Shall we limit size of the deployment in WildFly?

[Jason T. Greene]

Sent from my iPhone
> On Nov 4, 2015, at 8:09 AM, Darran Lofthouse <darran.lofthouse at jboss.com> wrote:
> 
> Actually - this makes me think 'Content Length' on a HTTP upload is not 
> a suitable measure of the file size - this is the length being sent to 
> the server, not necessarily the actual size of the resulting file.

Well technically we use multipart/form-data, so the file that is appended is actually a part with its own content-length independent of the http message body. 

It's a fair point though that this value is the network size which is not necessarily the disk size . It just so happens we only support the cases where hey correspond (on the http side). You can't add a gzip encoding to a part for example. You could only do that as a special mime-type.

> 
>> On 04/11/15 14:06, Brian Stansberry wrote:
>> It shouldn't as part of the management API, no.[1] Any total size
>> information that gets exchanged is part of the underlying management
>> communication protocol used for propagating streams and isn't exposed
>> outside that layer. I'd like to see even that bit go away too, as it's
>> unnecessary and wastes resources on the client.
>> 
>> [1] In some cases the CLI actually sends the deployment bytes base 64
>> encoded as a param to the op, in which case the size info is available
>> to the operation step handler. I consider that CLI behavior to be a bug
>> though.
>> 
>>> On 11/4/15 7:52 AM, Darran Lofthouse wrote:
>>> Does the op in the CLI send any length information?  That would help the
>>> two be consistent.
>>> 
>>>> On 04/11/15 12:29, Jason T. Greene wrote:
>>>> 
>>>> On Nov 4, 2015, at 4:36 AM, Heiko Braun <hbraun at redhat.com
>>>> <mailto:hbraun at redhat.com>> wrote:
>>>> 
>>>>> GWT boils down to plain web technologies.  And no, AFAIKT there is no
>>>>> way to  check the size of an uploaded file across web browsers. Most
>>>>> browsers do however have an implicit limitation on the file size,
>>>>> which for majority is about 2 GB.
>>>> 
>>>> You can now that we have switched to XHR to do the upload. The File
>>>> object returned from a file list has a size property that you can use.
>>>> 
>>>> So you could in theory check that there is available space before
>>>> posting, however, since as Stuart mentions, browsers set a content
>>>> length, the server knows it anyway so it's less racy checking at the
>>>> server level, if one was to check.
>>>> 
>>>> 
>>>>> 
>>>>>> On 04 Nov 2015, at 10:11, Darran Lofthouse
>>>>>> <darran.lofthouse at jboss.com <mailto:darran.lofthouse at jboss.com>> wrote:
>>>>>> 
>>>>>>  From within GWT is there any option to detect the file size before
>>>>>> uploading?
>>>>> 
>>>>> _______________________________________________
>>>>> wildfly-dev mailing list
>>>>> wildfly-dev at lists.jboss.org <mailto:wildfly-dev at lists.jboss.org>
>>>>> https://lists.jboss.org/mailman/listinfo/wildfly-dev
>>> _______________________________________________
>>> wildfly-dev mailing list
>>> wildfly-dev at lists.jboss.org
>>> https://lists.jboss.org/mailman/listinfo/wildfly-dev
> _______________________________________________
> wildfly-dev mailing list
> wildfly-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/wildfly-dev