[wildfly-dev] A note about pull requests and reviews

David M. Lloyd david.lloyd at redhat.com
Thu Nov 17 09:47:46 EST 2016


A quick note about pull requests, particularly those with multiple 
commits - not just on WildFly but on *all* projects.

In order to efficiently review a pull request, especially a complex one, 
it *must* be possible to review it one commit at a time.  This means 
that if there's a review item on your pull request for a mistake or 
problem, don't just add a commit to the PR to fix it.  Rather, please 
amend or remove the faulty commit completely, otherwise some other 
reviewer who is looking one commit at a time is just going to waste time 
reporting the same problem only to have to go back and remove it once 
the later commit found.

Remember: PR *submitters* have a great deal more processing power than 
PR *reviewers*.

Thanks!
-- 
- DML


More information about the wildfly-dev mailing list