[wildfly-dev] Logging Changes

[Brian Stansberry]

On Tue, Dec 12, 2017 at 12:45 PM, James Perkins <jperkins at redhat.com> wrote:

>
>
> On Tue, Dec 12, 2017 at 9:37 AM, Brian Stansberry <
> brian.stansberry at redhat.com> wrote:
>
>>
>>
>> On Thu, Dec 7, 2017 at 5:46 PM, David Lloyd <david.lloyd at redhat.com>
>> wrote:
>>
>>> On Thu, Dec 7, 2017 at 2:02 PM, James Perkins <jperkins at redhat.com>
>>> wrote:
>>> > There will be a slight performance impact during boot. This can be
>>> greatly
>>> > reduced if the caller calculation is disabled. This can be done in
>>> normal
>>> > cases, but we likely can't make it the default.
>>>
>>> I suspect we can safely disable caller calculation by default on boot,
>>> as long as users have an easy way to turn it on.
>>>
>>> Also I think we should consider some kind of grimy hack to bootstrap
>>> the logging subsystem first, if it's present, otherwise immediately
>>> fall back to properties-based config if it's absent.
>>>
>>> I'm not sure what counts as first in this context, but fwiw if a logging
>> subsystem is present during boot we always execute it's Stage.RUNTIME steps
>> first before proceeding on to doing the parallel execution of the other
>> subsystems. We could probably without too much trouble get a bit more
>> grimy, e.g. to get the subsystem ops to run before a few others if they
>> don't already. Beyond that I sense we wouldn't be talking grimy, we'd be
>> talking horrible. :)
>>
>
> Darran and I had a brief discussion about what we could do because at
> least parts of Elytron and logging are generally needed before other things
> are configured. Elytron would likely need to be first because logging will
> have to use capabilities from it.
>
> I've wondered if there should be a new Stage.PRE_RUNTIME type of stage,
> but I can also see where that may get abused.
>

This is starting to smell bad.

Elytron needs DS it seems, and DS needs ? and, well, this is why we use
MSC. :)  We hadn't had deps from logging to other subsystems before, which
is what made the minor boot op ordering tricks we do useful, but since we
now do, then we're really down to MSC. Boot op ordering tricks can help
optimize common cases like a logging subsystem not having elytron
dependencies, but I don't think we should try and create a duplicate MSC.


>
>
>>
>> --
>>> - DML
>>> _______________________________________________
>>> wildfly-dev mailing list
>>> wildfly-dev at lists.jboss.org
>>> https://lists.jboss.org/mailman/listinfo/wildfly-dev
>>>
>>
>>
>>
>> --
>> Brian Stansberry
>> Manager, Senior Principal Software Engineer
>> Red Hat
>>
>
>
>
> --
> James R. Perkins
> JBoss by Red Hat
>



-- 
Brian Stansberry
Manager, Senior Principal Software Engineer
Red Hat
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/wildfly-dev/attachments/20171212/0fdd05b6/attachment-0001.html