[wildfly-dev] Tests for incomplete bugs

[Stuart Douglas]

In the cases I am taking about the is no point even testing on CI, as it is
already known that the underling bug is not fixed yet.

Stuart

On Wed, 18 Apr. 2018, 9:05 pm Darran Lofthouse, <darran.lofthouse at redhat.com>
wrote:

> +1
>
> If multiple engineers are working on the same problem they should set up
> their own topic branch (can just be in one of their personal repos)
> somewhere and collaborate together then submit a combined PR from that
> branch that contains both the fix and the test case.
>
> Sometimes I think PRs are used as an easy way to get branches into CI, we
> should probably look again at how easy it is to get topic branches into CI
> without relying on the PR process to get jobs running.
>
> Regards,
> Darran Lofthouse.
>
>
> On Wed, 18 Apr 2018 at 02:12 Stuart Douglas <stuart.w.douglas at gmail.com>
> wrote:
>
>> Hi Everyone,
>>
>> Historically we have been ok with pull requests being submitted that add
>> tests for things that are not yet complete.
>>
>> In practice this has been kinda problematic for reviewers, as these pull
>> requests can hang around for a long time, and this ends up wasting a lot of
>> reviewer time as we have to continually check the status of the PR. You
>> basically end up with multiple reviewers continually polling the issue to
>> check if it is ready, instead of a single person just submitting it when it
>> is complete.
>>
>> I think that there is no real benefit to having the tests as a seperate
>> PR that gets opened before the fix. Instead I propose that tests that do
>> not pass yet are linked/co-ordinated under the relevant JIRA, and when the
>> fix is submitted the tests can be submitted as part of the same PR.
>>
>> Does anyone have any objections to this?
>>
>> Stuart
>> _______________________________________________
>> wildfly-dev mailing list
>> wildfly-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/wildfly-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/wildfly-dev/attachments/20180418/0cf4765d/attachment.html