[wildfly-dev] Missing transformer tests

[Paul Ferraro]

Thanks for identifying these.  As for the missing Infinispan subsystem
transformer, we were previously using the default protocol version
from the hotrod client as our default value in the model.  This makes
it very easy to miss default value changes during Infinispan upgrades.
I've changed this to use an explicit value, which should hopefully
prevent this problem in the future.
https://issues.jboss.org/browse/WFLY-11839

On Fri, Feb 8, 2019 at 10:07 AM Kabir Khan <kkhan at redhat.com> wrote:
>
> TL;DR: It looks like we may be missing transformer tests in the following subsystems: ejb3, infinispan, jca, logging, undertow. I've not dug in beyond that.
>
> Full:
> We have been using ModelTestControllerVersion.EAP_7_2_0_TEMP (containing WF14) for transformer testing until EAP 7.2.0 was released. [1] renames this to be EAP_7_2_0 and points to EAP 7.2.0.
>
> In addition I have some WIP to update the full mixed domain and subsystem tests to do the same. When doing this I noticed that the only subsystem that had transformer tests referencing EAP_7_2_0_TEMP was modcluster. I knew messaging-activemq had some changes, which Emmanuel is looking at.
>
> I've run the model comparison tool against master/7.2.0: and see changes which might be significant:
>
> ====== Resource root address: ["subsystem" => "ejb3"] - Current version: 0.0.0; legacy version: 5.0.0 =======
> --- Problems for relative address to root ["passivation-store" => "*"]:
> Different 'access-type' for attribute 'bean-cache'. Current: "read-write"; legacy: "read-only"
> Different 'access-type' for attribute 'cache-container'. Current: "read-write"; legacy: "read-only"
>
> ====== Resource root address: ["subsystem" => "infinispan"] - Current version: 0.0.0; legacy version: 8.0.0 =======
> * --- Problems for relative address to root ["remote-cache-container" => "*"]:
> Different 'default' for attribute 'protocol-version'. Current: "2.9"; legacy: "2.8"

Here the default value is taken from Infinispan - which is how the
version update was overlooked during the upgrade from Infinispan 9.3.x
to 9.4.x.
I think what I'd like to do for this one is to always apply a default
value conversion - we don't need to keep incrementing the threshold
version for every upgrade.
We do, however, need to remember to bump model versions when this
protocol version changes.

> ====== Resource root address: ["subsystem" => "jca"] - Current version: 0.0.0; legacy version: 5.0.0 =======
> --- Problems for relative address to root ["distributed-workmanager" => "*","long-running-threads" => "*"]:
> * Missing attributes in current: [handoff-executor]; missing in legacy []
> * Missing parameters for operation 'add' in current: [handoff-executor]; missing in legacy []
> --- Problems for relative address to root ["distributed-workmanager" => "*","short-running-threads" => "*"]:
> * Missing attributes in current: [handoff-executor]; missing in legacy []
> * Missing parameters for operation 'add' in current: [handoff-executor]; missing in legacy []
> --- Problems for relative address to root ["workmanager" => "*","long-running-threads" => "*"]:
> * Missing attributes in current: [handoff-executor]; missing in legacy []
> * Missing parameters for operation 'add' in current: [handoff-executor]; missing in legacy []
> --- Problems for relative address to root ["workmanager" => "*","short-running-threads" => "*"]:
> * Missing attributes in current: [handoff-executor]; missing in legacy []
> * Missing parameters for operation 'add' in current: [handoff-executor]; missing in legacy []
> --- Problems for relative address to root ["workmanager" => "default","long-running-threads" => "*"]:
> * Missing attributes in current: [handoff-executor]; missing in legacy []
> * Missing parameters for operation 'add' in current: [handoff-executor]; missing in legacy []
> --- Problems for relative address to root ["workmanager" => "default","short-running-threads" => "*"]:
> * Missing attributes in current: [handoff-executor]; missing in legacy []
> * Missing parameters for operation 'add' in current: [handoff-executor]; missing in legacy []
>
>
> ====== Resource root address: ["subsystem" => "logging"] - Current version: 0.0.0; legacy version: 7.0.0 =======
> * --- Problems for relative address to root ["json-formatter" => "*"]:
> Different 'default' for attribute 'record-delimiter'. Current: "
> "; legacy: ""
> * --- Problems for relative address to root ["logging-profile" => "*","json-formatter" => "*"]:
> Different 'default' for attribute 'record-delimiter'. Current: "
> "; legacy: ""
> * --- Problems for relative address to root ["logging-profile" => "*","xml-formatter" => "*"]:
> Different 'default' for attribute 'record-delimiter'. Current: "
> "; legacy: ""
> * --- Problems for relative address to root ["xml-formatter" => "*"]:
> Different 'default' for attribute 'record-delimiter'. Current: "
> "; legacy: ""
>
>
> ====== Resource root address: ["subsystem" => "undertow"] - Current version: 0.0.0; legacy version: 7.0.0 =======
> --- Problems for relative address to root ["application-security-domain" => "*"]:
> * Missing attributes in current: []; missing in legacy [enable-jaspi, integrated-jaspi]
> * Missing parameters for operation 'add' in current: []; missing in legacy [enable-jaspi, integrated-jaspi]
>
> Although WF16 doesn't provide any domain mode guarantees for previous releases, this will one day end up as a product release and then it is important that we have these tests in place. It is easier to add them as we go along than to retrofit them when that time comes.
>
> Thanks,
>
> Kabir
>
>
>
> [1] https://github.com/wildfly/wildfly-core/pull/3664
> _______________________________________________
> wildfly-dev mailing list
> wildfly-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/wildfly-dev