[wildfly-dev] Adding a banner to WildFly

[Emmanuel Hugonnet]

Hello,

I have updated the PR a bit:

 - the banner.txt now lives in $JBOSS_HOME/bin making it easier to edit or remove

 - removal of the banner.txt will provide the same behaviour as the current one.

 - the banner.txt is now part of a galleon banner package making it easier to remove / override

Emmanuel

Le 28/04/2020 à 23:18, Ken Wills a écrit :
>
>
> On Tue, Apr 28, 2020 at 4:10 PM James Perkins <jperkins at redhat.com <mailto:jperkins at redhat.com>> wrote:
>
>
>
>     On Tue, Apr 28, 2020 at 7:07 AM Emmanuel Hugonnet <ehugonne at redhat.com <mailto:ehugonne at redhat.com>> wrote:
>
>
>         Le 28/04/2020 à 02:21, James Perkins a écrit :
>         > I've got some concerns with this going through a logger. That means it's written to any handler that would process that logger
>         including
>         > the server.log by default. While I don't know if it is an issue, I could see this possibly being an issue for anything that
>         scraps the log
>         > files and attempts to put them into some kind of aggregator.
>
>         We can use System.out if that's an issue, thus it shouldn't be processed by all handlers.
>
>
>     We could do that, but by the time it gets to this point System.out is wrapped with a logger so it will processed by a stdout logger.
>      
>
>
>         >
>         > It also feels a bit weird to me to have this in the manifest. Not that anyone looks at it, but just seems weird :)
>         It is no longer in the manifest, I've moved it to a banner.txt in the META-INF.
>         >
>         > I'd also like to know how this works with OpenShift since there are options to use the EFK stack AIUI.
>
>
> Would it make sense if you were using a json logger to somehow not include the banner, otherwise to just include it?
>  
>
>
>         We may exclude it from our image
>
>
>     Ah okay. That could make sense.
>      
>
>
>
>         >
>         > On Mon, Apr 27, 2020 at 12:53 PM Emmanuel Hugonnet <ehugonne at redhat.com <mailto:ehugonne at redhat.com> <mailto:ehugonne at redhat.com
>         <mailto:ehugonne at redhat.com>>> wrote:
>         >
>         >     Hello,
>         >
>         >     I have submitted a PR[1] to enable the use of a cool ASCII banner during WildFly startup.
>         >
>         >     The banner content is externalized to a banner.txt file and removing that file or its content is supported.
>         >
>         >     What do you think about this ? 
>         >
>         >     6:37:53,123 INFO  [org.jboss.modules] (main) JBoss Modules version 1.10.0.Final
>         >     16:37:53,587 INFO  [org.jboss.msc] (main) JBoss MSC version 1.4.11.Final
>         >     16:37:53,594 INFO  [org.jboss.threads] (main) JBoss Threads version 2.3.3.Final
>         >     16:37:53,706 INFO  [org.jboss.as <http://org.jboss.as> <http://org.jboss.as>] (MSC service thread 1-2) WFLYSRV0049: WildFly
>         Core 12.0.0.Beta2-SNAPSHOT
>         >     (WildFly Core
>         >     12.0.0.Beta2-SNAPSHOT) starting
>         >      _       ___ __    __________         ______
>         >     | |     / (_) /___/ / ____/ /_  __   / ____/___  ________
>         >     | | /| / / / / __  / /_  / / / / /  / /   / __ \/ ___/ _ \
>         >     | |/ |/ / / / /_/ / __/ / / /_/ /  / /___/ /_/ / /  /  __/
>         >     |__/|__/_/_/\__,_/_/   /_/\__, /   \____/\____/_/   \___/
>         >                              /____/
>         >
>         >     16:37:54,319 INFO  [org.wildfly.security] (ServerService Thread Pool -- 6) ELY00001: WildFly Elytron version 1.11.3.Final
>         >
>         >     ....
>         >
>         >
>         >     Emmanuel
>         >
>         >     [1]: https://github.com/wildfly/wildfly-core/pull/4145
>         >
>         >     _______________________________________________
>         >     wildfly-dev mailing list
>         >     wildfly-dev at lists.jboss.org <mailto:wildfly-dev at lists.jboss.org> <mailto:wildfly-dev at lists.jboss.org
>         <mailto:wildfly-dev at lists.jboss.org>>
>         >     https://lists.jboss.org/mailman/listinfo/wildfly-dev
>         >
>         >
>         >
>         > --
>         > James R. Perkins
>         > JBoss by Red Hat
>         >
>         > _______________________________________________
>         > wildfly-dev mailing list
>         > wildfly-dev at lists.jboss.org <mailto:wildfly-dev at lists.jboss.org>
>         > https://lists.jboss.org/mailman/listinfo/wildfly-dev
>
>         _______________________________________________
>         wildfly-dev mailing list
>         wildfly-dev at lists.jboss.org <mailto:wildfly-dev at lists.jboss.org>
>         https://lists.jboss.org/mailman/listinfo/wildfly-dev
>
>
>
>     -- 
>     James R. Perkins
>     JBoss by Red Hat
>     _______________________________________________
>     wildfly-dev mailing list
>     wildfly-dev at lists.jboss.org <mailto:wildfly-dev at lists.jboss.org>
>     https://lists.jboss.org/mailman/listinfo/wildfly-dev
>
>
> _______________________________________________
> wildfly-dev mailing list
> wildfly-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/wildfly-dev

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
Url : http://lists.jboss.org/pipermail/wildfly-dev/attachments/20200625/5fc795c7/attachment.bin