<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div>Since this change looks minor, and it comes from a community member I am inclined to allow into 8.0.1.</div><div><br></div><div>How bad is the conflict for the other change you are referring to Darran?</div><div><br>On Mar 19, 2014, at 5:43 PM, Marek Żupnik <<a href="mailto:marek.zupnik@gmail.com">marek.zupnik@gmail.com</a>> wrote:<br><br></div><blockquote type="cite"><div><div dir="ltr"><div>Hi,</div><div><br></div><div>Darran, I understand your point of view, but stable version of 9 will be not released tomorrow. Lack of pkcs12 support in 8 is a major issue, not to mention that in AS 7 I was able to use this format for https private key. I think it will be useful to fix it yet in 8, even thought the code with a fix will be thrown away in 9.</div>
<div><br></div><div>I made a pull request with a fix (<a href="https://github.com/wildfly/wildfly/pull/6062">https://github.com/wildfly/wildfly/pull/6062</a>). It is up to you what you do with it.</div><div><br></div><div>
Thank you for your answers and clarifications.</div><div><br></div><div>Kind Regards,</div><div>Marek Zupnik</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">2014-03-18 18:10 GMT+01:00 Darran Lofthouse <span dir="ltr"><<a href="mailto:darran.lofthouse@jboss.com" target="_blank">darran.lofthouse@jboss.com</a>></span>:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I will have another look if I get a chance to get something into 8 but<br>
in reality a related change in this area (that completely conflicts with<br>
your changes) was pushed to 9 as the consensus was we did not want the<br>
configuration model in this area changing before WildFLy 9.<br>
<div class=""><br>
On 18/03/14 16:30, Marek Żupnik wrote:<br>
> Hi,<br>
><br>
> Thank You Brian for your comments. I'll try to apply them to my code. I<br>
> ask if I will have further questions about it.<br>
><br>
> @Darran, I have a question for you. I wasn't looking into development<br>
> branch so I haven't known about the changes. Is it possible that pkcs12<br>
> support will be merged in Wildfly 8? If not, could my change be merged<br>
> earlier? Otherwise, I'm forced to maintain my version of Wildfly untill<br>
> no 9 will be released.<br>
><br>
> Kind Regards,<br>
> Marek Zupnik<br>
><br>
><br>
> 2014-03-18 16:20 GMT+01:00 Brian Stansberry <<a href="mailto:brian.stansberry@redhat.com">brian.stansberry@redhat.com</a><br>
</div>> <mailto:<a href="mailto:brian.stansberry@redhat.com">brian.stansberry@redhat.com</a>>>:<br>
<div><div class="h5">><br>
> Hi Marek,<br>
><br>
> Welcome!<br>
><br>
> I'm going to make a few comments on github re: some minor details of<br>
> your commit. But please keep an eye on this list for your more general<br>
> question about whether this is how we want to go about this. I believe<br>
> Darran Lofthouse was planning some work in this area so he may have some<br>
> input.<br>
><br>
> Cheers,<br>
><br>
> --<br>
> Brian Stansberry<br>
> Senior Principal Software Engineer<br>
> JBoss by Red Hat<br>
><br>
> On 3/18/14, 8:59 AM, Marek Żupnik wrote:<br>
> > Hi,<br>
> ><br>
> > I'm Marek Zupnik. It's my first message for this list but for<br>
> some time<br>
> > I've been keeping my eyes on what's happening in wildfly development.<br>
> ><br>
> > I'm writing regarding to the issue about lack of support for PKCS12<br>
> > keystores in security realms<br>
> > (<a href="https://issues.jboss.org/browse/WFLY-2229" target="_blank">https://issues.jboss.org/browse/WFLY-2229</a>). I wanted to migrate my<br>
> > system to Wildfly but in my case it is a blocking issue. I have<br>
> to use<br>
> > keystore in PKCS12 format in which I'm storing, among others, https<br>
> > private key.<br>
> ><br>
> > I forked Wildfly on github and made a simple fix for this issue which<br>
> > consists in additional parameter "keystore-type" for keystore<br>
> > configuration. Based on this parameter I'm able to create appropriate<br>
> > keystore type.<br>
> ><br>
> > Config sample:<br>
> > <keystore path="keystore.p12" relative-to="jboss.server.config.dir"<br>
> > keystore-password="xxx" keystore-type="PKCS12" alias="https"/><br>
> ><br>
> > The changes are in my fork on github (keystore_type branch):<br>
> > <a href="https://github.com/mzupnik/wildfly/tree/keystore_type" target="_blank">https://github.com/mzupnik/wildfly/tree/keystore_type</a><br>
> ><br>
> > Before I will try to do push request, could you answer me if it is<br>
> > acceptable solution according to your architecture concept? If not,<br>
> > could you give me some tips how to resolve it in other way? I<br>
> care about<br>
> > this fix before 9. release.<br>
> ><br>
> > Kind Regards,<br>
> > Marek Zupnik<br>
> ><br>
> ><br>
> > _______________________________________________<br>
> > wildfly-dev mailing list<br>
</div></div>> > <a href="mailto:wildfly-dev@lists.jboss.org">wildfly-dev@lists.jboss.org</a> <mailto:<a href="mailto:wildfly-dev@lists.jboss.org">wildfly-dev@lists.jboss.org</a>><br>
<div class="">> > <a href="https://lists.jboss.org/mailman/listinfo/wildfly-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/wildfly-dev</a><br>
> ><br>
><br>
><br>
> _______________________________________________<br>
> wildfly-dev mailing list<br>
</div>> <a href="mailto:wildfly-dev@lists.jboss.org">wildfly-dev@lists.jboss.org</a> <mailto:<a href="mailto:wildfly-dev@lists.jboss.org">wildfly-dev@lists.jboss.org</a>><br>
<div class="HOEnZb"><div class="h5">> <a href="https://lists.jboss.org/mailman/listinfo/wildfly-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/wildfly-dev</a><br>
><br>
><br>
><br>
><br>
> _______________________________________________<br>
> wildfly-dev mailing list<br>
> <a href="mailto:wildfly-dev@lists.jboss.org">wildfly-dev@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/wildfly-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/wildfly-dev</a><br>
><br>
_______________________________________________<br>
wildfly-dev mailing list<br>
<a href="mailto:wildfly-dev@lists.jboss.org">wildfly-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/wildfly-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/wildfly-dev</a></div></div></blockquote></div><br></div>
</div></blockquote><blockquote type="cite"><div><span>_______________________________________________</span><br><span>wildfly-dev mailing list</span><br><span><a href="mailto:wildfly-dev@lists.jboss.org">wildfly-dev@lists.jboss.org</a></span><br><span><a href="https://lists.jboss.org/mailman/listinfo/wildfly-dev">https://lists.jboss.org/mailman/listinfo/wildfly-dev</a></span></div></blockquote></body></html>