<div dir="ltr">Instead of duplicating the entire test suite can we just add a new CI job that runs the tests with the *-elytron.xml configuration file? Duplicating the entire testsuite will end in nothing but headaches IMO. Like Kabir mentioned any bug in a test will need to be fixed in two locations.</div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Dec 2, 2016 at 12:11 AM, Josef Cacek <span dir="ltr"><<a href="mailto:jcacek@redhat.com" target="_blank">jcacek@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br>
<br>
EAP QE and Elytron Dev teams would like to raise a discussion about how the Elytron integration tests will be added to the WildFly/EAP testsuite.<br>
We would like to agree on a unified approach across the testsuite, so we don't end up in situation where each component comes with its own "best-fitting" solution.<br>
<br>
We see following requirements:<br>
1. new features which come with Elytron need to be covered by integration tests<br>
2. existing scenarios have to stay working when Elytron is configured as the default security subsystem<br>
3. legacy security subsystem must stay working in parallel<br>
<br>
Our teams came to agreement that the safest way would be to copy whole existing testsuite modules into new ones. E.g.<br>
<br>
cp -r testsuite/integration/basic testsuite/integration/basic-<wbr>legacy-security<br>
# + Reconfigure testsuite/integration/basic to use Elytron<br>
# + Add @Ignore to all tests which fail with Elytron or use directly the old security configuration<br>
<br>
The modules would just live side by side - basic would use Elytron configuration, basic-legacy-security would use configuration similar to (or same as) the current server configuration.<br>
<br>
In the next step we will go through the Ignored tests (the TODO list) for Elytron and rewrite them or report issues if necessary.<br>
<br>
By this way we would keep all the test coverage for legacy security. We would also have all existing scenarios covered (or at least present) for Elytron configuration.<br>
<br>
Are there any objections to this suggestion?<br>
<br>
Thanks,<br>
<br>
-- Josef<br>
______________________________<wbr>_________________<br>
wildfly-dev mailing list<br>
<a href="mailto:wildfly-dev@lists.jboss.org">wildfly-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/wildfly-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/<wbr>mailman/listinfo/wildfly-dev</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>James R. Perkins</div><div>JBoss by Red Hat</div></div></div></div></div>
</div>