<div dir="ltr">AFAICT currently (i.e. before this change), the normal dist module build (i.e. no -Drelease) didn't do anything different from the 'build' module besides creating a fat server, except [1]. So I'm ok with skipping that. I'll just change my normal<div><br></div><div>$ dist/target/wildfly-whatever-SNAPSHOT/bin/standalone.sh</div><div><br></div><div>to </div><div><br></div><div>$ build/target/wildfly-whatever-SNAPSHOT/bin/standalone.sh<br></div><div><br></div><div>[1] In full WildFly the dist module runs the maven-verifier-plugin. We'll need to move that to 'build' as I don't want it only run when we're about to release. I believe all the existing verifications should work just fine from build, except for this one, which IMO should be removed anyway, as it's not checking any contract we support:</div><div><br></div><div><div><br></div><div> <file></div><div> <location>target/${server.output.dir.prefix}-${project.version}/modules/system/layers/base/org/jboss/as/server/main/wildfly-server-${version.org.wildfly.core}.jar</location></div><div> <exists>true</exists></div><div> </file></div></div><div><br></div><div>Rob -- can you confirm that JBDS doesn't really need to check the contents of the server module any more? AIUI doing that was just a workaround in some prior releases and isn't relevant with the latest releases.</div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Oct 20, 2017 at 7:47 AM, Tomaž Cerar <span dir="ltr"><<a href="mailto:tomaz.cerar@gmail.com" target="_blank">tomaz.cerar@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div><div><div><div><div><div><div><div><div><div>Hey guys,<br><br><br></div>As initial work on trimming our IO usage by testsuite and build,<br></div>I've send <a href="https://github.com/wildfly/wildfly-core/pull/2880" target="_blank">https://github.com/wildfly/<wbr>wildfly-core/pull/2880</a> <br></div>which changes wildfly-core to never produce "inflated" build/distro with jars present.<br></div>But rather uses thin server provisioning (module.xml entries point to maven GAV)<br><br></div>As part of this work, "dist" folder is now used for just that, for distribution and noting else.<br></div>So unless build is invoked with -Drelease which is something that is done as part of release process, "dist" folder will be empty and wont produce anything.<br></div><br></div>Sever for testing is still present in "build" directory as it always was.<br><br></div>This was done to reduce unnecessary IO work and producing multiple server builds without need for them.<br><br></div>I am sending this mail mostly as FYI that further work on this is going to happen, in core and in full, and such changes might clash with some poeple's workflows, where they are used to expect server dist to be in "dist" folder but it is not there yet.<br><br>--</div><div>tomaz<br></div><div><div><div><div><div><br> <br></div></div></div></div></div></div>
<br>______________________________<wbr>_________________<br>
wildfly-dev mailing list<br>
<a href="mailto:wildfly-dev@lists.jboss.org">wildfly-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/wildfly-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/<wbr>mailman/listinfo/wildfly-dev</a><br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">Brian Stansberry<div>Manager, Senior Principal Software Engineer</div><div>Red Hat</div></div></div>
</div>