<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On 16 April 2018 at 09:31, <span dir="ltr"><<a href="mailto:" target="_blank"></a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Adding +WildFly Dev <wildfly-dev at <a href="http://lists.jboss.org" rel="noreferrer" target="_blank">lists.jboss.org</a>> to the loop<br>
<br>
Thanks for the explanation Rado.<br>
<br>
TL;DR: A while ago Sanne pointed out that we do not set `node-identifier`<br>
in transaction subsystem by default. The default value for the<br>
`node-identifier` attribute it `1`. Not setting this attribute might cause<br>
problems in transaction recovery. Perhaps we could follow Rado's idea and<br>
set it to node name by default?<br></blockquote><div><br></div><div>
<span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:12.8px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">Indeed - it would cause serious data integrity problems if a non-unique node-identifier is used.</span>
</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Some more comments inlined.<br>
<br>
Thanks,<br>
Sebastian<br>
<br>
On Fri, Apr 13, 2018 at 7:07 PM Radoslav Husar <rhusar at <a href="http://redhat.com" rel="noreferrer" target="_blank">redhat.com</a>> wrote:<br>
<br>
> Hi Sebastian,<br>
><br>
> On Wed, Apr 11, 2018 at 2:31 PM, Sebastian Laskawiec<br>
> <slaskawi at <a href="http://redhat.com" rel="noreferrer" target="_blank">redhat.com</a>> wrote:<br>
> > Hey Rado, Paul,<br>
> ><br>
> > I started looking into this issue and it turned out that WF subsystem<br>
> > template doesn't provide `node-identifier` attribute [1].<br>
><br>
> I assume you mean that the default WildFly server profiles do not<br>
> explicitly define the attribute. Right ? thus the value defaults in<br>
> the model to "1"<br>
><br>
> <a href="https://github.com/wildfly/wildfly/blob/master/transactions/src/main/java/org/jboss/as/txn/subsystem/TransactionSubsystemRootResourceDefinition.java#L97" rel="noreferrer" target="_blank">https://github.com/wildfly/<wbr>wildfly/blob/master/<wbr>transactions/src/main/java/<wbr>org/jboss/as/txn/subsystem/<wbr>TransactionSubsystemRootResour<wbr>ceDefinition.java#L97</a><br>
> which sole intention seems to be to log a warning on boot if the value<br>
> is unchanged.<br>
> Why they decided on a constant that will be inherently not unique as<br>
> opposed to defaulting to the node name (which we already require to be<br>
> unique) as clustering node name or undertow instance-id does, is<br>
> unclear to me.<br>
> Some context is on <a href="https://issues.jboss.org/browse/WFLY-1119" rel="noreferrer" target="_blank">https://issues.jboss.org/<wbr>browse/WFLY-1119</a>.<br>
><br>
<br>
In OpenShift environment we could set it to `hostname`. This is guaranteed<br>
to be unique in whole OpenShift cluster.<br>
<br>
<br></blockquote><div>
We do this too in EAP images.
<br>To Rado's point, the default is "1" so we can print the warning to alert
people they are misconfigured - it seems to be working :)<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
><br>
> > I'm not sure if you guys are the right people to ask, but is it safe to<br>
> > leave it set to default? Or shall I override our Infinispan templates and<br>
> > add this parameter (as I mentioned before, in OpenShift this I wanted to<br>
> set<br>
> > it as Pod name trimmed to the last 23 chars since this is the limit).<br></blockquote><div><br></div><div>
Putting a response to this in line - I am not certain who originally
proposed this.
<br>
<br>You must use a globally unique node-identifier. If you are certain the
last 23 characters guarantee that it would be valid - if there is a
chance they are not unique it is not valid to trim.
<br>
<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
><br>
> It is not safe to leave it set to "1" as that results in inconsistent<br>
> processing of transaction recovery.<br>
> IIUC we already set it to the node name for both EAP and JDG<br>
><br>
> <a href="https://github.com/jboss-openshift/cct_module/blob/master/os-eap70-openshift/added/standalone-openshift.xml#L411" rel="noreferrer" target="_blank">https://github.com/jboss-<wbr>openshift/cct_module/blob/<wbr>master/os-eap70-openshift/<wbr>added/standalone-openshift.<wbr>xml#L411</a><br>
><br>
> <a href="https://github.com/jboss-openshift/cct_module/blob/master/os-jdg7-conffiles/added/clustered-openshift.xml#L282" rel="noreferrer" target="_blank">https://github.com/jboss-<wbr>openshift/cct_module/blob/<wbr>master/os-jdg7-conffiles/<wbr>added/clustered-openshift.xml#<wbr>L282</a><br>
> which in turn defaults to the pod name ? so which profiles are we<br>
> talking about here?<br>
><br>
<br>
Granted, we set it by default in CCT Modules. However in Infinispan we just<br>
grab provided transaction subsystem when rendering full configuration from<br>
featurepacks:<br>
<a href="https://github.com/infinispan/infinispan/blob/master/server/integration/feature-pack/src/main/resources/configuration/standalone/subsystems-cloud.xml#L19" rel="noreferrer" target="_blank">https://github.com/infinispan/<wbr>infinispan/blob/master/server/<wbr>integration/feature-pack/src/<wbr>main/resources/configuration/<wbr>standalone/subsystems-cloud.<wbr>xml#L19</a><br>
<br>
The default configuration XML doesn't contain the `node-identifier`<br>
attribute. I can add it manually in the cloud.xml but I believe the right<br>
approach is to modify the transaction subsystem.<br>
<br>
<br>
> Rado<br>
><br>
> > Thanks,<br>
> > Seb<br>
> ><br>
> > [1] usually set to node-identifier="${<a href="http://jboss.node.name" rel="noreferrer" target="_blank">jboss.node.<wbr>name</a>}"<br>
> ><br>
> ><br>
> > On Mon, Apr 9, 2018 at 10:39 AM Sanne Grinovero <sanne at <a href="http://infinispan.org" rel="noreferrer" target="_blank">infinispan.org</a>><br>
> > wrote:<br>
> >><br>
> >> On 9 April 2018 at 09:26, Sebastian Laskawiec <slaskawi at <a href="http://redhat.com" rel="noreferrer" target="_blank">redhat.com</a>><br>
> wrote:<br>
> >> > Thanks for looking into it Sanne. Of course, we should add it (it can<br>
> be<br>
> >> > set<br>
> >> > to the same name as hostname since those are unique in Kubernetes).<br>
> >> ><br>
> >> > Created <a href="https://issues.jboss.org/browse/ISPN-9051" rel="noreferrer" target="_blank">https://issues.jboss.org/<wbr>browse/ISPN-9051</a> for it.<br>
> >> ><br>
> >> > Thanks again!<br>
> >> > Seb<br>
> >><br>
> >> Thanks Sebastian!<br>
> >><br>
> >> ><br>
> >> > On Fri, Apr 6, 2018 at 8:53 PM Sanne Grinovero <sanne at <a href="http://infinispan.org" rel="noreferrer" target="_blank">infinispan.org</a>><br>
> >> > wrote:<br>
> >> >><br>
> >> >> Hi all,<br>
> >> >><br>
> >> >> I've started to use the Infinispan Openshift Template and was<br>
> browsing<br>
> >> >> through the errors and warnings this produces.<br>
> >> >><br>
> >> >> In particular I noticed "WFLYTX0013: Node identifier property is set<br>
> >> >> to the default value. Please make sure it is unique." being produced<br>
> >> >> by the transaction system.<br>
> >> >><br>
> >> >> The node id is usually not needed for developer's convenience and<br>
> >> >> assuming there's a single node in "dev mode", yet clearly the<br>
> >> >> Infinispan template is meant to work with multiple nodes running so<br>
> >> >> this warning seems concerning.<br>
> >> >><br>
> >> >> I'm not sure what the impact is on the transaction manager so I asked<br>
> >> >> on the Narayana forums; Tom pointed me to some thourough design<br>
> >> >> documents and also suggested the EAP image does set the node<br>
> >> >> identifier:<br>
> >> >> - <a href="https://developer.jboss.org/message/981702#981702" rel="noreferrer" target="_blank">https://developer.jboss.org/<wbr>message/981702#981702</a><br>
> >> >><br>
> >> >> WDYT? we probably want the Infinispan template to set this as well,<br>
> or<br>
> >> >> silence the warning?<br>
> >> >><br>
> >> >> Thanks,<br>
> >> >> Sanne<br>
> >> >> ______________________________<wbr>_________________<br>
> >> >> infinispan-dev mailing list<br>
> >> >> infinispan-dev at <a href="http://lists.jboss.org" rel="noreferrer" target="_blank">lists.jboss.org</a><br>
> >> >> <a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/<wbr>mailman/listinfo/infinispan-<wbr>dev</a><br>
> >> ><br>
> >> ><br>
> >> > ______________________________<wbr>_________________<br>
> >> > infinispan-dev mailing list<br>
> >> > infinispan-dev at <a href="http://lists.jboss.org" rel="noreferrer" target="_blank">lists.jboss.org</a><br>
> >> > <a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/<wbr>mailman/listinfo/infinispan-<wbr>dev</a><br>
> >> ______________________________<wbr>_________________<br>
> >> infinispan-dev mailing list<br>
> >> infinispan-dev at <a href="http://lists.jboss.org" rel="noreferrer" target="_blank">lists.jboss.org</a><br>
> >> <a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/<wbr>mailman/listinfo/infinispan-<wbr>dev</a><br>
><br>
-------------- next part --------------<br>
An HTML attachment was scrubbed...<br>
URL: <a href="http://lists.jboss.org/pipermail/wildfly-dev/attachments/20180416/65962cf1/attachment-0001.html" rel="noreferrer" target="_blank">http://lists.jboss.org/<wbr>pipermail/wildfly-dev/<wbr>attachments/20180416/65962cf1/<wbr>attachment-0001.html</a> <br>
<br>
<br>
<br>
</blockquote></div><br></div></div>