<div dir="ltr">+1 (In cases of 1 to 1 server code and testcases)</div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Apr 19, 2018 at 9:52 AM, Carlo de Wolf <span dir="ltr"><<a href="mailto:cdewolf@redhat.com" target="_blank">cdewolf@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
It would prove the test code is valid. I have seen some false
positives. :)<br>
<br>
So having an independent run of the test is nice, but it must end up
in the same PR as the fix.<br>
<br>
Filing a test-only PR isn't very pretty, because it creates smoke
for the mergers.<span class="HOEnZb"><font color="#888888"><br>
<br>
Carlo</font></span><div><div class="h5"><br>
<br>
<div class="m_7903633336812027593moz-cite-prefix">On 18-04-18 14:54, Stuart Douglas
wrote:<br>
</div>
<blockquote type="cite">
<div dir="auto">
<div>In the cases I am taking about the is no point even testing
on CI, as it is already known that the underling bug is not
fixed yet.</div>
<div dir="auto"><br>
</div>
<div dir="auto">Stuart</div>
<div dir="auto"><br>
<div class="gmail_quote" dir="auto">
<div dir="ltr">On Wed, 18 Apr. 2018, 9:05 pm Darran
Lofthouse, <<a href="mailto:darran.lofthouse@redhat.com" target="_blank">darran.lofthouse@redhat.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">+1<br>
<div><br>
</div>
<div>If multiple engineers are working on the same
problem they should set up their own topic branch (can
just be in one of their personal repos) somewhere and
collaborate together then submit a combined PR from
that branch that contains both the fix and the test
case.</div>
<div><br>
</div>
<div>Sometimes I think PRs are used as an easy way to
get branches into CI, we should probably look again at
how easy it is to get topic branches into CI without
relying on the PR process to get jobs running.</div>
<div><br>
</div>
<div>Regards,</div>
<div>Darran Lofthouse.</div>
<div><br>
</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr">On Wed, 18 Apr 2018 at 02:12 Stuart
Douglas <<a href="mailto:stuart.w.douglas@gmail.com" rel="noreferrer" target="_blank">stuart.w.douglas@gmail.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">Hi Everyone,
<div><br>
</div>
<div>Historically we have been ok with pull requests
being submitted that add tests for things that are
not yet complete.</div>
<div><br>
</div>
<div>In practice this has been kinda problematic for
reviewers, as these pull requests can hang around
for a long time, and this ends up wasting a lot of
reviewer time as we have to continually check the
status of the PR. You basically end up with
multiple reviewers continually polling the issue
to check if it is ready, instead of a single
person just submitting it when it is complete.</div>
<div><br>
</div>
<div>I think that there is no real benefit to having
the tests as a seperate PR that gets opened before
the fix. Instead I propose that tests that do not
pass yet are linked/co-ordinated under the
relevant JIRA, and when the fix is submitted the
tests can be submitted as part of the same PR.</div>
<div><br>
</div>
<div>Does anyone have any objections to this?</div>
<div><br>
</div>
<div>Stuart</div>
</div>
______________________________<wbr>_________________<br>
wildfly-dev mailing list<br>
<a href="mailto:wildfly-dev@lists.jboss.org" rel="noreferrer" target="_blank">wildfly-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/wildfly-dev" rel="noreferrer noreferrer" target="_blank">https://lists.jboss.org/<wbr>mailman/listinfo/wildfly-dev</a></blockquote>
</div>
</blockquote>
</div>
</div>
</div>
<br>
<fieldset class="m_7903633336812027593mimeAttachmentHeader"></fieldset>
<br>
<pre>______________________________<wbr>_________________
wildfly-dev mailing list
<a class="m_7903633336812027593moz-txt-link-abbreviated" href="mailto:wildfly-dev@lists.jboss.org" target="_blank">wildfly-dev@lists.jboss.org</a>
<a class="m_7903633336812027593moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/wildfly-dev" target="_blank">https://lists.jboss.org/<wbr>mailman/listinfo/wildfly-dev</a></pre>
</blockquote>
<br>
</div></div></div>
<br>______________________________<wbr>_________________<br>
wildfly-dev mailing list<br>
<a href="mailto:wildfly-dev@lists.jboss.org">wildfly-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/wildfly-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/<wbr>mailman/listinfo/wildfly-dev</a><br></blockquote></div><br></div>