<div dir="ltr">Hi Guillaume,<div><br></div><div>thanks for bringing this up. There have been some changes in the module deps in wfcore since the release referenced from the patch gen. Please try this branch <a href="https://github.com/aloubyansky/patch-gen-1/commits/upgrade-wfcore-5">https://github.com/aloubyansky/patch-gen-1/commits/upgrade-wfcore-5</a></div><div><br></div><div>I was able to build your branch with your last commit and w/o it. If that works for you, please let me know, I'll make a release with the fix.</div><div><br></div><div>Thanks,</div><div>Alexey</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jun 6, 2018 at 2:13 PM, Guillaume Smet <span dir="ltr"><<a href="mailto:guillaume@hibernate.org" target="_blank">guillaume@hibernate.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Hi,</div><div><br></div><div>For some time now, we build WildFly patches for Hibernate Validator.</div><div><br></div><div>With 11 and 12, everything was OK, but I just tried to upgrade to WildFly 13 and the patch-gen-maven-plugin fails with the following error in the patchgen.log:</div><div>java.io.IOException: org.jboss.modules.<wbr>ModuleNotFoundException: org.jboss.modules:main<br> at org.jboss.as.patching.<wbr>generator.<wbr>DistributionProcessor.process(<wbr>DistributionProcessor.java:<wbr>106)<br> at org.jboss.as.patching.<wbr>generator.Distribution.create(<wbr>Distribution.java:68)<br> at org.jboss.as.patching.<wbr>generator.PatchGenerator.<wbr>process(PatchGenerator.java:<wbr>129)<br> at org.jboss.as.patching.<wbr>generator.PatchGenerator.main(<wbr>PatchGenerator.java:73)<br>Caused by: org.jboss.modules.<wbr>ModuleNotFoundException: org.jboss.modules:main<br> at org.jboss.modules.Module.<wbr>addPaths(Module.java:1116)<br> at org.jboss.modules.Module.link(<wbr>Module.java:1472)<br> at org.jboss.modules.Module.<wbr>relinkIfNecessary(Module.java:<wbr>1500)<br> at org.jboss.modules.<wbr>ModuleLoader.loadModule(<wbr>ModuleLoader.java:226)<br> at org.jboss.as.patching.<wbr>generator.<wbr>DistributionProcessor.process(<wbr>DistributionProcessor.java:93)<br> ... 3 more</div><div><br></div><div>My branch is here: <a href="https://github.com/gsmet/hibernate-validator/tree/HV-1622" target="_blank">https://github.com/gsmet/<wbr>hibernate-validator/tree/HV-<wbr>1622</a> . A simple mvn clean install fails with the above error. If you drop the latest commit and go back to build WF 11 and 12, everything is fine.<br></div><div><br></div><div>I use the latest patch-gen-maven-plugin with the latest wildfly-core (5.0.0.Final) so the latest wildfly-patching.</div><div><br></div><div>Note that we usually support 2 versions of WF so I would like to keep supporting WF 12 too.<br></div><div><br></div><div>Any thoughts?</div><div><br></div><div>Thanks!</div><span class="HOEnZb"><font color="#888888"><div><br></div><div>-- <br></div><div>Guillaume<br></div></font></span></div>
<br>______________________________<wbr>_________________<br>
wildfly-dev mailing list<br>
<a href="mailto:wildfly-dev@lists.jboss.org">wildfly-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/wildfly-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/<wbr>mailman/listinfo/wildfly-dev</a><br></blockquote></div><br></div>