<div dir="ltr"><div class="gmail_default" style="font-family:trebuchet ms,sans-serif">Excellent! Thank you so much Wolfgang!</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Jun 3, 2019 at 9:52 AM Eduardo Martins <<a href="mailto:emartins@redhat.com">emartins@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="overflow-wrap: break-word;">Wolfgang: yours and mine PRs are merged, and when WFLY 17 Final is out I will also deploy the archetype, thanks a lot for your contribution! Yet now I have to ask, do you plan to submit similar for the other old javaee archetype? :-)<div><br></div><div>Brian: yep it was just the JDK, I will deploy these too (no planned updates in such code tho)</div><div><br></div><div>—E<br><div><br><blockquote type="cite"><div>On 16 May 2019, at 10:09, Eduardo Martins <<a href="mailto:emartins@redhat.com" target="_blank">emartins@redhat.com</a>> wrote:</div><br class="gmail-m_4965788826300227035Apple-interchange-newline"><div><div style="overflow-wrap: break-word;">Hmm ok, maybe it just failed build due to some specific like JDK 11, will recheck that.<div><br></div><div>—E<br><div><br><blockquote type="cite"><div>On 16 May 2019, at 02:25, Brian Stansberry <<a href="mailto:brian.stansberry@redhat.com" target="_blank">brian.stansberry@redhat.com</a>> wrote:</div><br class="gmail-m_4965788826300227035Apple-interchange-newline"><div><div dir="ltr"><div class="gmail_default" style="font-family:"trebuchet ms",sans-serif">These build for me.</div><div class="gmail_default" style="font-family:"trebuchet ms",sans-serif"><br></div><div class="gmail_default" style="font-family:"trebuchet ms",sans-serif">They're not as out of date as I'd thought either.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, May 10, 2019 at 6:34 PM Eduardo Martins <<a href="mailto:emartins@redhat.com" target="_blank">emartins@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><div dir="auto">If you think it’s not a small effort task then certainly agree that’s not a blocker, I look at the archetypes same way as the quickstarts, an aggregation project, so we may take outdated/faulty ones out of build and release the working+actual ones. We may give it a thought later if it makes sense effort wise to update or drop the subsystem ones, no worries.</div></div><div dir="auto"><br></div><div><div dir="auto">—E</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, 10 May 2019 at 21:46, Brian Stansberry <<a href="mailto:brian.stansberry@redhat.com" target="_blank">brian.stansberry@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_default" style="font-family:"trebuchet ms",sans-serif">Is that blocking this Eduardo?</div><div class="gmail_default" style="font-family:"trebuchet ms",sans-serif"><br></div><div class="gmail_default" style="font-family:"trebuchet ms",sans-serif">If not, updating those is a pretty big task and right now I don't see it happening anytime soon.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, May 10, 2019 at 3:10 PM Eduardo Martins <<a href="mailto:emartins@redhat.com" target="_blank">emartins@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Brian, any idea what to do wrt the subsystem archetypes? ATM even build fails and most likely there is someone else better than me to look into that…<br>
<br>
—E<br>
<br>
> On 7 May 2019, at 09:18, Eduardo Martins <<a href="mailto:emartins@redhat.com" target="_blank">emartins@redhat.com</a>> wrote:<br>
> <br>
> Hi Wolfgang, I actually did start reviewing it, but unfortunately had to put it on hold due to unexpected blocker kind of priority tasks/issues needed to be solved asap. If nothing urgent comes I should be able to finish the review the next couple of days.<br>
> <br>
> —E<br>
> <br>
>> On 6 May 2019, at 20:50, Wolfgang Knauf <<a href="mailto:wolfgang.knauf@gmx.de" target="_blank">wolfgang.knauf@gmx.de</a>> wrote:<br>
>> <br>
>> Hi,<br>
>> <br>
>> just want to ask for an update ;-)<br>
>> <br>
>> Best regards<br>
>> <br>
>> Wolfgang<br>
>> <br>
>> Am 31.03.19 um 21:34 schrieb Eduardo Martins:<br>
>>> I will review it, soon hopefully.<br>
>>> <br>
>>> —E<br>
>>> <br>
>>>> On 31 Mar 2019, at 19:40, Wolfgang Knauf <<a href="mailto:wolfgang.knauf@gmx.de" target="_blank">wolfgang.knauf@gmx.de</a>> wrote:<br>
>>>> <br>
>>>> Hi,<br>
>>>> <br>
>>>> just want to ask about the state of the pull request and further steps...<br>
>>>> <br>
>>>> Best regards<br>
>>>> <br>
>>>> Wolfgang<br>
>>>> <br>
>>>> Am 21.03.19 um 12:47 schrieb Wolfgang Knauf:<br>
>>>>> OK, I sent a pull request:<br>
>>>>> <a href="https://github.com/wildfly/wildfly-archetypes/pull/3" rel="noreferrer" target="_blank">https://github.com/wildfly/wildfly-archetypes/pull/3</a><br>
>>>>> <br>
>>>>> There already exists a JIRA (created by myself):<br>
>>>>> <a href="https://issues.jboss.org/browse/WFLY-9703" rel="noreferrer" target="_blank">https://issues.jboss.org/browse/WFLY-9703</a> - but I cannot assign it to<br>
>>>>> myself, probably because I only have the role "jira user".<br>
>>>>> <br>
>>>>> Next steps (if the pull request is accepted):<br>
>>>>> -someone has to release if to maven central. See the release scripts in<br>
>>>>> the wildfly-archetypes root. This is probably something that has to done<br>
>>>>> by the JBoss team.<br>
>>>>> -the old archetype can be removed.<br>
>>>>> -I will create a similar archetype replacement for<br>
>>>>> "wildfly-javaee7-webapp-archetype"<br>
>>>>> <br>
>>>>> <br>
>>>>> Wolfgang<br>
>>>>> <br>
>>>>> Am 19.03.19 um 12:09 schrieb Wolfgang Knauf:<br>
>>>>>> <br>
>>>>>> Am 18.03.19 um 22:49 schrieb Eduardo Martins:<br>
>>>>>>> Webapp-ear sounds a bit weird, perhaps app-ear and app-web instead? :-)<br>
>>>>>> <br>
>>>>>> <br>
>>>>>> What do you think about "wildfly-javaee-ear-archetype" and<br>
>>>>>> "wildfly-javaee-web-archetype"?<br>
>>>>>> <br>
>>>>>> <br>
>>>>>> Attached is a suggested integration test prototype, which shows how to<br>
>>>>>> create the EAR file using ShrinkWrap. The test code will be placed in<br>
>>>>>> the web module. The kitchensink quickstart had the tests in the EJB jar,<br>
>>>>>> but this is the wrong place if you also want to test the web layer.<br>
>>>>>> <br>
>>>>>> If this is all sound OK, I will start committing it to my git repository<br>
>>>>>> and sending the pull request.<br>
>>>>>> <br>
>>>>>> Best regards<br>
>>>>>> <br>
>>>>>> Wolfgang<br>
>>>>>> <br>
>>>>>>> <br>
>>>>>>> On Mon, 18 Mar 2019 at 21:04, Wolfgang Knauf <<a href="mailto:wolfgang.knauf@gmx.de" target="_blank">wolfgang.knauf@gmx.de</a><br>
>>>>>>> <mailto:<a href="mailto:wolfgang.knauf@gmx.de" target="_blank">wolfgang.knauf@gmx.de</a>>> wrote:<br>
>>>>>>> <br>
>>>>>>> OK, so there are two votes (mine and Eduardo's) for "create a blank<br>
>>>>>>> archetype from scratch - no demo source included" and no vote for<br>
>>>>>>> "continue using the quickstart" approach.<br>
>>>>>>> <br>
>>>>>>> Currently, I struggle with the archetype and will send a pull<br>
>>>>>>> request in<br>
>>>>>>> the next few days.<br>
>>>>>>> <br>
>>>>>>> Any objections against the name<br>
>>>>>>> "wildfly-javaee-webapp-ear-archetype"<br>
>>>>>>> (which means: a new subdirectory in git)?<br>
>>>>>>> <br>
>>>>>>> If this is done, the next step would be to create a<br>
>>>>>>> "wildfly-javaee-webapp-archetype". And then someone could clean<br>
>>>>>>> up the<br>
>>>>>>> old archetypes.<br>
>>>>>>> <br>
>>>>>>> I think about adding a small integration test to the web project<br>
>>>>>>> which<br>
>>>>>>> shows how to create the @Deployment using ShrinkWrap? The test<br>
>>>>>>> itself<br>
>>>>>>> might have only dummy code, just the creation of the EAR file is<br>
>>>>>>> relevant. This might be helpful to users.<br>
>>>>>>> <br>
>>>>>>> Best regards<br>
>>>>>>> <br>
>>>>>>> Wolfgang<br>
>>>>>>> <br>
>>>>>>> Am 18.03.19 um 09:33 schrieb Eduardo Martins:<br>
>>>>>>>> The archetype sources should actually be simpler to maintain, no<br>
>>>>>>> need to “fix” the imported QS sources... I guess for most releases<br>
>>>>>>> it would be to simply the effort to sync some dependency management<br>
>>>>>>> versions for the generated parent pom, e.g. WildFly BOMs version.<br>
>>>>>>>> <br>
>>>>>>>> Wrt the html5-mobile archetype, I believe it is similar to the<br>
>>>>>>> ones you were looking at, but pointing to an old QS that was<br>
>>>>>>> removed<br>
>>>>>>> at some point.<br>
>>>>>>>> <br>
>>>>>>>> —E<br>
>>>>>>>> <br>
>>>>>>>>> On 13 Mar 2019, at 19:14, Wolfgang Knauf <<a href="mailto:wolfgang.knauf@gmx.de" target="_blank">wolfgang.knauf@gmx.de</a><br>
>>>>>>> <mailto:<a href="mailto:wolfgang.knauf@gmx.de" target="_blank">wolfgang.knauf@gmx.de</a>>> wrote:<br>
>>>>>>>>> <br>
>>>>>>>>> <br>
>>>>>>>>> Am 13.03.19 um 18:25 schrieb Eduardo Martins:<br>
>>>>>>>>>> <br>
>>>>>>>>>>> On 12 Mar 2019, at 19:12, Wolfgang Knauf<br>
>>>>>>> <<a href="mailto:wolfgang.knauf@gmx.de" target="_blank">wolfgang.knauf@gmx.de</a> <mailto:<a href="mailto:wolfgang.knauf@gmx.de" target="_blank">wolfgang.knauf@gmx.de</a>>> wrote:<br>
>>>>>>>>>>> <br>
>>>>>>>>>>> Hi Eduardo,<br>
>>>>>>>>>>> <br>
>>>>>>>>>>> Am 12.03.19 um 08:58 schrieb Eduardo Martins:<br>
>>>>>>>>>>>> Hi Wolfgang, the kitchensink QS truly depends on the QS<br>
>>>>>>> parent pom (dependency management, plugins, etc.), which means that<br>
>>>>>>> if we replace it with a “local” parent pom then, for each release,<br>
>>>>>>> we need to sync manually such parents poms content… I don’t see any<br>
>>>>>>> issue with using QS parent pom, it seems that those archetypes were<br>
>>>>>>> designed to generate clones of specific quickstarts with just<br>
>>>>>>> different Maven GAVs. Have you tried to install the SNAPSHOT<br>
>>>>>>> versioned QS parent first (mvn install -N at QS repo root), or<br>
>>>>>>> use a<br>
>>>>>>> tag such as 16.0.0.Final, which parent was released to Maven,<br>
>>>>>>> instead of pointing to QS master branch ?<br>
>>>>>>>>>>>> Honestly I’m not sure this kind of app archetype is of much<br>
>>>>>>> interest as it is, mostly due to the app's complexity, probably<br>
>>>>>>> would be more helpful almost “empty” apps, but if the idea is to<br>
>>>>>>> have a QS clone tool then perhaps a single generic archetype for<br>
>>>>>>> that would make more sense. I’m open to QS source changes needed to<br>
>>>>>>> be friendly with such archetype :-)<br>
>>>>>>>>>>>> —E<br>
>>>>>>>>>>> <br>
>>>>>>>>>>> <br>
>>>>>>>>>>> I agree that the "wildfly-javaee7-webapp-ear-archetype"<br>
>>>>>>> archetype is not really useful. But based on this archetype, an<br>
>>>>>>> empty archetype "wildfly-javaee7-webapp-ear-blank-archetype" is<br>
>>>>>>> generated, which consists of all necessary pom.xml files and some<br>
>>>>>>> deployment descriptor stubs. And *this* archetype is the reason why<br>
>>>>>>> I started working on it: it is a good starting point for a new<br>
>>>>>>> JavaEE application which already defines all necessary components.<br>
>>>>>>>>>>> <br>
>>>>>>>>>>> I am willing to maintain this archetype for the next few<br>
>>>>>>> years<br>
>>>>>>> and trying to release a version for each major WildFly version. As<br>
>>>>>>> suggested I would add a static root pom.xml to the archetype github<br>
>>>>>>> project which is independent of the quickstart files, as they are<br>
>>>>>>> not "standalone". This main pom.xml has to be updated for each<br>
>>>>>>> WildFly version, but all the other files still can be pulled from<br>
>>>>>>> the "KitchensinkEar" quickstart.<br>
>>>>>>>>>>> <br>
>>>>>>>>>> <br>
>>>>>>>>>> Then why get any sources from QS repo, having a proper<br>
>>>>>>> do-nothing app project all locally sounds better to me, probably<br>
>>>>>>> less effort needed on every release too.<br>
>>>>>>>>>> <br>
>>>>>>>>>> —E<br>
>>>>>>>>>> <br>
>>>>>>>>> <br>
>>>>>>>>> So you prefer to create a blank archetype which has no build<br>
>>>>>>>>> dependencies, just containing the relevant pom.xml files and<br>
>>>>>>> maybe some<br>
>>>>>>>>> required files (don't know if there are any)? And this<br>
>>>>>>> archetype is<br>
>>>>>>>>> updated by someone (e.g. me) each time a new major release<br>
>>>>>>> is done?<br>
>>>>>>>>> <br>
>>>>>>>>> Same applies to the other archetype,<br>
>>>>>>> "wildfly-javaee7-webapp-archetype”.<br>
>>>>>>>>> The wildfly-archetypes project contains two more archetypes<br>
>>>>>>>>> ("wildfly-html5-mobile-archetype",<br>
>>>>>>> "wildfly-subsystem-archetype"), but I<br>
>>>>>>>>> did not even take a look at those.<br>
>>>>>>>>> <br>
>>>>>>>>> Personally, I prefer the standalone approach, too. It means<br>
>>>>>>> more<br>
>>>>>>> work to<br>
>>>>>>>>> maintain it, but it is simpler ;-)<br>
>>>>>>>>> <br>
>>>>>>>>> Please vote for any of those solutions ;-):<br>
>>>>>>>>> a) continue pulling from KitchensinkEAR quickstart ("blank"<br>
>>>>>>> archetype<br>
>>>>>>>>> and archetype with a basic project)...<br>
>>>>>>>>> b) create standalone archetype (only "blank" archetype).<br>
>>>>>>>>> <br>
>>>>>>>>> <br>
>>>>>>>>> Best regards<br>
>>>>>>>>> <br>
>>>>>>>>> Wolfgang<br>
>>>>>> <br>
>>>>>> _______________________________________________<br>
>>>>>> wildfly-dev mailing list<br>
>>>>>> <a href="mailto:wildfly-dev@lists.jboss.org" target="_blank">wildfly-dev@lists.jboss.org</a><br>
>>>>>> <a href="https://lists.jboss.org/mailman/listinfo/wildfly-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/wildfly-dev</a><br>
>>>>>> <br>
>>>> <br>
>>>> _______________________________________________<br>
>>>> wildfly-dev mailing list<br>
>>>> <a href="mailto:wildfly-dev@lists.jboss.org" target="_blank">wildfly-dev@lists.jboss.org</a><br>
>>>> <a href="https://lists.jboss.org/mailman/listinfo/wildfly-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/wildfly-dev</a><br>
>>> <br>
>>> <br>
>> <br>
>> _______________________________________________<br>
>> wildfly-dev mailing list<br>
>> <a href="mailto:wildfly-dev@lists.jboss.org" target="_blank">wildfly-dev@lists.jboss.org</a><br>
>> <a href="https://lists.jboss.org/mailman/listinfo/wildfly-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/wildfly-dev</a><br>
> <br>
<br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail-m_4965788826300227035gmail-m_6500438122771242479m_4870920467673897466gmail_signature"><div dir="ltr">Brian Stansberry<div>Manager, Senior Principal Software Engineer</div><div>Red Hat</div></div></div>
</blockquote></div></div>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail-m_4965788826300227035gmail_signature"><div dir="ltr">Brian Stansberry<div>Manager, Senior Principal Software Engineer</div><div>Red Hat</div></div></div>
</div></blockquote></div><br></div></div></div></blockquote></div><br></div></div></blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr">Brian Stansberry<div>Manager, Senior Principal Software Engineer</div><div>Red Hat</div></div></div>