<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Nov 1, 2019 at 3:04 PM Brian Stansberry <<a href="mailto:brian.stansberry@redhat.com">brian.stansberry@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><div style="font-family:"trebuchet ms",sans-serif"><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Nov 1, 2019 at 3:32 PM James Perkins <<a href="mailto:jperkins@redhat.com" target="_blank">jperkins@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Nov 1, 2019 at 12:08 PM Brian Stansberry <<a href="mailto:brian.stansberry@redhat.com" target="_blank">brian.stansberry@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><div style="font-family:"trebuchet ms",sans-serif"><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Oct 31, 2019 at 7:10 PM James Perkins <<a href="mailto:jperkins@redhat.com" target="_blank">jperkins@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Oct 28, 2019 at 6:47 PM Brian Stansberry <<a href="mailto:brian.stansberry@redhat.com" target="_blank">brian.stansberry@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div style="font-family:"trebuchet ms",sans-serif">I'd like to add jobs to the automatic testing of PRs to run the testsuite using slimmed installations provisioned by Galleon. But, we already run a lot of jobs for each PR, enough so that our CI can overburdened during busy times around deadlines. So I don't want to just add jobs. Instead I also propose to drop the Windows + JDK 8 jobs.</div><div style="font-family:"trebuchet ms",sans-serif"><br></div><div style="font-family:"trebuchet ms",sans-serif">Galleon Testing</div><div style="font-family:"trebuchet ms",sans-serif"><br></div><div style="font-family:"trebuchet ms",sans-serif">During our work on WildFly 18 I added the ability to run portions of the WildFly and WildFly Core testsuites with the tests executing against slimmed server installations provisioned by Galleon instead of against the complete installations normally used. The point of that was to get test coverage of those slimmed installations.</div><div style="font-family:"trebuchet ms",sans-serif"><br></div><div style="font-family:"trebuchet ms",sans-serif">Currently we have nightly jobs that run the testsuite this way.[1] As we continue to evolve our set of Galleon layers, e.g. adding layers for MicroProfile specs, I want to be sure we catch problems before PRs get merged.</div><div style="font-family:"trebuchet ms",sans-serif"><br></div><div style="font-family:"trebuchet ms",sans-serif">To run tests locally this way you pass -Dts.layers as an arg to maven.</div><div style="font-family:"trebuchet ms",sans-serif"><br></div><div style="font-family:"trebuchet ms",sans-serif">Dropping Windows JDK 8 Jobs</div><div style="font-family:"trebuchet ms",sans-serif"><br></div><div style="font-family:"trebuchet ms",sans-serif">If we'd drop something in order to free up resources for these Galleon jobs, the Windows JDK 8 ones seem a good choice. We'd still run PRs against Windows JDK 11, and we'd still run PRs against Linux JDK 8. I can't recall any situation where CI found a regression that was specific to the Windows + JDK 8 combination.</div><div style="font-family:"trebuchet ms",sans-serif"><br></div><div style="font-family:"trebuchet ms",sans-serif">When CI gets overloaded during rush times, it's the Windows jobs that are most problematic. The Windows jobs take longer because the storage drives they use are slower. Plus we have fewer Windows agents. The effect is during a rush, overall CI for PRs ends up taking hours longer while we wait for Windows agents to come free and then run the job.</div><div style="font-family:"trebuchet ms",sans-serif"><br></div><div style="font-family:"trebuchet ms",sans-serif">We'd still run nightly jobs with Windows + JDK 8 so in the off chance there's a problem it would get noticed that way.</div></div></blockquote><div><br></div><div>This seems reasonable to me. One more option to add would be that before bulk PR's are merged maybe we run Windows JDK8 jobs against those. Though those jobs are slow so...</div><div><br></div></div></div></blockquote><div><span class="gmail_default" style="font-family:"trebuchet ms",sans-serif"></span></div><div><span class="gmail_default" style="font-family:"trebuchet ms",sans-serif">I'm not enthused about more steps in the merge process. :) Of course it's fine if people want to do it and it's good to do when dealing with a PR that has the look of possibly being different, e.g. windows script stuff.</span></div></div></div></blockquote><div><br></div><div>Yeah I almost removed this line before sending, but figured it didn't hurt to keep it open for discussion at least.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div><span class="gmail_default" style="font-family:"trebuchet ms",sans-serif"></span> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div></div><div>One other option too is maybe Windows JDK8 jobs just don't run the full test suite. The main place I could possibly see issues would be if scripts change since there are some decisions made based on the JVM. Though kicking off a manual job there isn't a huge deal as it's likely not common.</div></div></div></blockquote><div><br></div><div style="font-family:"trebuchet ms",sans-serif">If you have some ideas on how the ts + ci jobs could be configured to get that result, that would be good.</div><div style="font-family:"trebuchet ms",sans-serif"><br></div><div style="font-family:"trebuchet ms",sans-serif">What I did with ts.layers is the root pom has a profile that turns off the default surefire execution. And then in parts of the ts that I wanted to run, there's a profile that turns things on. You have to deal with a few maven modules that have more than the default surefire execution though.</div></div></div></blockquote><div><br></div><div>My initial thought was just to run without -DallTests, but I suppose using a more fine grained approach with profiles could work as well.</div></div></div></blockquote><div><br></div><div style="font-family:"trebuchet ms",sans-serif">Or a mix. It's true that without -DallTests the bulk of the ts doesn't run, which probably eliminates the maven modules I mentioned that have more than the default surefire execution.</div><div style="font-family:"trebuchet ms",sans-serif"><br></div><div style="font-family:"trebuchet ms",sans-serif">The -Dts.layers profile doesn't just turn off the testsuite/* stuff. It turns off surefire execution for all the other maven modules.</div><div style="font-family:"trebuchet ms",sans-serif"><br></div><div style="font-family:"trebuchet ms",sans-serif">Is it really just testsuite/scripts in WildFly Core that tests scripts?</div></div></div></blockquote><div><br></div><div>Yeah that's all it is. It honestly might not be a big deal as the scripts don't change that often. It was just the one place I had of concern.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div style="font-family:"trebuchet ms",sans-serif"><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div style="font-family:"trebuchet ms",sans-serif"><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div><br></div><div>Somewhat related if we do remove Windows JDK8 jobs I think we should just remove them from the aggreator job, but keep them under the Pull Request. The reason for this is if we do want to run a custom one we could use the PR number from "Changes" tab when running a custom job and it would report back to the PR.</div></div></div></blockquote><div><br></div><div style="font-family:"trebuchet ms",sans-serif">+1; I'll do it that way.</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><br></div><div><div style="font-family:"trebuchet ms",sans-serif">Specifics</div><div style="font-family:"trebuchet ms",sans-serif"><br></div><div style="font-family:"trebuchet ms",sans-serif">For PRs against wildfly/wildfly I'd add a job equivalent to <a href="https://ci.wildfly.org/viewType.html?buildTypeId=WF_GalleonLinuxJdk11" target="_blank">https://ci.wildfly.org/viewType.html?buildTypeId=WF_GalleonLinuxJdk11</a> and then drop <a href="https://ci.wildfly.org/viewType.html?buildTypeId=WildFlyCore_PullRequestWindows" style="font-family:Arial,Helvetica,sans-serif" target="_blank">https://ci.wildfly.org/viewType.html?buildTypeId=WildFlyCore_PullRequestWindows</a></div><div style="font-family:"trebuchet ms",sans-serif"><br></div><div style="font-family:"trebuchet ms",sans-serif">For PRs against wildfly/wildfly-core I'd add jobs equivalent to <a href="https://ci.wildfly.org/viewType.html?buildTypeId=WildFlyCore_GalleonLinuxJdk8" target="_blank">https://ci.wildfly.org/viewType.html?buildTypeId=WildFlyCore_GalleonLinuxJdk8</a> and <a href="https://ci.wildfly.org/viewType.html?buildTypeId=WF_GalleonLinuxJdk8" target="_blank">https://ci.wildfly.org/viewType.html?buildTypeId=WF_GalleonLinuxJdk8</a> and then drop <a href="https://ci.wildfly.org/viewType.html?buildTypeId=WildFlyCore_PullRequestWindows" style="font-family:Arial,Helvetica,sans-serif" target="_blank">https://ci.wildfly.org/viewType.html?buildTypeId=WildFlyCore_PullRequestWindows</a></div><br></div><div><div style="font-family:"trebuchet ms",sans-serif">Any thoughts on this?</div></div></div></blockquote><div><br></div><div>No objection from me.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><br></div><div><br></div><span class="gmail_default" style="font-family:"trebuchet ms",sans-serif">Best regards,</span><div><span class="gmail_default" style="font-family:"trebuchet ms",sans-serif">Brian</span></div><div><span class="gmail_default" style="font-family:"trebuchet ms",sans-serif"><br></span></div><div><span class="gmail_default" style="font-family:"trebuchet ms",sans-serif">[1] See</span></div><div><a href="https://ci.wildfly.org/viewType.html?buildTypeId=WF_GalleonLinuxJdk11" target="_blank">https://ci.wildfly.org/viewType.html?buildTypeId=WF_GalleonLinuxJdk11</a></div><div><a href="https://ci.wildfly.org/viewType.html?buildTypeId=WF_GalleonLinuxJdk8" target="_blank">https://ci.wildfly.org/viewType.html?buildTypeId=WF_GalleonLinuxJdk8</a><br></div><div><a href="https://ci.wildfly.org/viewType.html?buildTypeId=WF_GalleonWindowsJdk11" target="_blank">https://ci.wildfly.org/viewType.html?buildTypeId=WF_GalleonWindowsJdk11</a><br></div><div><a href="https://ci.wildfly.org/viewType.html?buildTypeId=WildFlyCore_GalleonLinuxJdk8" target="_blank">https://ci.wildfly.org/viewType.html?buildTypeId=WildFlyCore_GalleonLinuxJdk8</a><br></div><div><a href="https://ci.wildfly.org/viewType.html?buildTypeId=WildFlyCore_GalleonLinuxJdk11" target="_blank">https://ci.wildfly.org/viewType.html?buildTypeId=WildFlyCore_GalleonLinuxJdk11</a><br></div></div>
_______________________________________________<br>
wildfly-dev mailing list<br>
<a href="mailto:wildfly-dev@lists.jboss.org" target="_blank">wildfly-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/wildfly-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/wildfly-dev</a></blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr"><div dir="ltr"><div><div dir="ltr"><div>James R. Perkins</div><div>JBoss by Red Hat</div></div></div></div></div></div>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr"><div dir="ltr">Brian Stansberry<div>Manager, Senior Principal Software Engineer</div><div>Red Hat</div></div></div></div>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr"><div dir="ltr"><div><div dir="ltr"><div>James R. Perkins</div><div>JBoss by Red Hat</div></div></div></div></div></div>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr"><div dir="ltr">Brian Stansberry<div>Manager, Senior Principal Software Engineer</div><div>Red Hat</div></div></div></div>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>James R. Perkins</div><div>JBoss by Red Hat</div></div></div></div></div></div>