<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Apr 28, 2020 at 7:07 AM Emmanuel Hugonnet <<a href="mailto:ehugonne@redhat.com">ehugonne@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Le 28/04/2020 à 02:21, James Perkins a écrit :<br>
> I've got some concerns with this going through a logger. That means it's written to any handler that would process that logger including<br>
> the server.log by default. While I don't know if it is an issue, I could see this possibly being an issue for anything that scraps the log<br>
> files and attempts to put them into some kind of aggregator.<br>
<br>
We can use System.out if that's an issue, thus it shouldn't be processed by all handlers.<br></blockquote><div><br></div><div>We could do that, but by the time it gets to this point System.out is wrapped with a logger so it will processed by a stdout logger.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
><br>
> It also feels a bit weird to me to have this in the manifest. Not that anyone looks at it, but just seems weird :)<br>
It is no longer in the manifest, I've moved it to a banner.txt in the META-INF.<br>
><br>
> I'd also like to know how this works with OpenShift since there are options to use the EFK stack AIUI.<br>
<br>
We may exclude it from our image<br></blockquote><div><br></div><div>Ah okay. That could make sense.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
<br>
><br>
> On Mon, Apr 27, 2020 at 12:53 PM Emmanuel Hugonnet <<a href="mailto:ehugonne@redhat.com" target="_blank">ehugonne@redhat.com</a> <mailto:<a href="mailto:ehugonne@redhat.com" target="_blank">ehugonne@redhat.com</a>>> wrote:<br>
><br>
> Hello,<br>
><br>
> I have submitted a PR[1] to enable the use of a cool ASCII banner during WildFly startup.<br>
><br>
> The banner content is externalized to a banner.txt file and removing that file or its content is supported.<br>
><br>
> What do you think about this ? <br>
><br>
> 6:37:53,123 INFO [org.jboss.modules] (main) JBoss Modules version 1.10.0.Final<br>
> 16:37:53,587 INFO [org.jboss.msc] (main) JBoss MSC version 1.4.11.Final<br>
> 16:37:53,594 INFO [org.jboss.threads] (main) JBoss Threads version 2.3.3.Final<br>
> 16:37:53,706 INFO [<a href="http://org.jboss.as" rel="noreferrer" target="_blank">org.jboss.as</a> <<a href="http://org.jboss.as" rel="noreferrer" target="_blank">http://org.jboss.as</a>>] (MSC service thread 1-2) WFLYSRV0049: WildFly Core 12.0.0.Beta2-SNAPSHOT<br>
> (WildFly Core<br>
> 12.0.0.Beta2-SNAPSHOT) starting<br>
> _ ___ __ __________ ______<br>
> | | / (_) /___/ / ____/ /_ __ / ____/___ ________<br>
> | | /| / / / / __ / /_ / / / / / / / / __ \/ ___/ _ \<br>
> | |/ |/ / / / /_/ / __/ / / /_/ / / /___/ /_/ / / / __/<br>
> |__/|__/_/_/\__,_/_/ /_/\__, / \____/\____/_/ \___/<br>
> /____/<br>
><br>
> 16:37:54,319 INFO [org.wildfly.security] (ServerService Thread Pool -- 6) ELY00001: WildFly Elytron version 1.11.3.Final<br>
><br>
> ....<br>
><br>
><br>
> Emmanuel<br>
><br>
> [1]: <a href="https://github.com/wildfly/wildfly-core/pull/4145" rel="noreferrer" target="_blank">https://github.com/wildfly/wildfly-core/pull/4145</a><br>
><br>
> _______________________________________________<br>
> wildfly-dev mailing list<br>
> <a href="mailto:wildfly-dev@lists.jboss.org" target="_blank">wildfly-dev@lists.jboss.org</a> <mailto:<a href="mailto:wildfly-dev@lists.jboss.org" target="_blank">wildfly-dev@lists.jboss.org</a>><br>
> <a href="https://lists.jboss.org/mailman/listinfo/wildfly-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/wildfly-dev</a><br>
><br>
><br>
><br>
> -- <br>
> James R. Perkins<br>
> JBoss by Red Hat<br>
><br>
> _______________________________________________<br>
> wildfly-dev mailing list<br>
> <a href="mailto:wildfly-dev@lists.jboss.org" target="_blank">wildfly-dev@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/wildfly-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/wildfly-dev</a><br>
<br>
_______________________________________________<br>
wildfly-dev mailing list<br>
<a href="mailto:wildfly-dev@lists.jboss.org" target="_blank">wildfly-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/wildfly-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/wildfly-dev</a></blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>James R. Perkins</div><div>JBoss by Red Hat</div></div></div></div></div></div>