[windup-dev] Iteration*Managers

[Lincoln Baxter, III]

IterationPayloadManager manages getting/setting of the current iteration
payload (e.g. the current  cursor as you called it.)

IterationSelectionManager provides access to the specified selection
variable (e.g. something that was selected via GraphSearchConditionBuilder
(this name was initially "Selection" and we probably need to think about
changing the name to something else)

Regarding renaming SelectionFactory. I don't really like the name VarStack,
but I am open to suggestions. I think in looking at it again, it might even
need to be split into two types: "SelectionVariableStack" or
"IterationPayloadContext", because SelectionFactory currently does both of
those things, and they could actually be separate.

~Lincoln


On Wed, Jun 25, 2014 at 12:19 AM, Ondrej Zizka <ozizka at redhat.com> wrote:

>
> On 25.6.2014 04:58, Ondrej Zizka wrote:
> > Hi,
> >
> > what's the purpose of having IterationSelectionManager and
> > IterationPayloadManager?
> > I can only see Named~ and TypedNamed.
> > Wouldn't a simple method overload in SelectionFactory be enough for just
> > giving the option of type checking?
> > Or do we assume some other use case for that?
> > Also, the names don't fit - it's not manager, rather some kind of
> > filter, or getter.
> Regarding IterationSelectionManager, it looks like it was created for
> the Gremlin query API, which is  based on Iteration as it assumes it
> needs some initial vertices.
> True?
>
> >
> > Also, how about splitting SelectionFactory to VarStack and
> > CurrentPayloadManager? The variable stack and "current payload" seem to
> > be related only indirectly, by concept - at least in the current
> > implementation.
> >
> > And lastly, I'd rename "current payload" to something like "cursor"
> > (resembling DB result iteration) or "current item" or "current element"
> > (which is how XSLT refers to iterated nodes). Payload rather evokes that
> > there's some wrapper around it, which is not.
> >
> > Thanks,
> > Ondra
> > _______________________________________________
> > windup-dev mailing list
> > windup-dev at lists.jboss.org
> > https://lists.jboss.org/mailman/listinfo/windup-dev
>
> _______________________________________________
> windup-dev mailing list
> windup-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/windup-dev
>



-- 
Lincoln Baxter, III
http://ocpsoft.org
"Simpler is better."
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/windup-dev/attachments/20140625/849a5d93/attachment.html