From ozizka at redhat.com Mon Jan 5 08:08:33 2015 From: ozizka at redhat.com (Ondrej Zizka) Date: Mon, 05 Jan 2015 14:08:33 +0100 Subject: [windup-dev] Permanent links to latest release in Nexus... Message-ID: <54AA8CD1.5090200@redhat.com> Hi, We use Nexus as distribution channel. I've asked JBoss.org about $SUBJ, since having this handled by Nexus would be cool (always valid and up-to-date link in docs, mails, READMEs etc.) Currently there's no such option, as far as David Hladky knows, so he asked me to create https://issues.jboss.org/browse/ORG-2382 . FYI. Ondra From lincolnbaxter at gmail.com Mon Jan 5 10:51:47 2015 From: lincolnbaxter at gmail.com (Lincoln Baxter, III) Date: Mon, 5 Jan 2015 10:51:47 -0500 Subject: [windup-dev] Permanent links to latest release in Nexus... In-Reply-To: <54AA8CD1.5090200@redhat.com> References: <54AA8CD1.5090200@redhat.com> Message-ID: <CAEp_U4GEbLtr4FdQ-BkzShbXosn=5zt=kAsVDoKwbJ+h=tLmKQ@mail.gmail.com> What's wrong with this link? https://repository.jboss.org/nexus/service/local/artifact/maven/redirect?r=releases&g=org.jboss.windup&a=windup-distribution&v=LATEST&e=zip&c=offline On Mon, Jan 5, 2015 at 8:08 AM, Ondrej Zizka <ozizka at redhat.com> wrote: > Hi, > > We use Nexus as distribution channel. > I've asked JBoss.org about $SUBJ, since having this handled by Nexus > would be cool (always valid and up-to-date link in docs, mails, READMEs > etc.) > > Currently there's no such option, as far as David Hladky knows, > so he asked me to create https://issues.jboss.org/browse/ORG-2382 . > > FYI. > Ondra > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev > -- Lincoln Baxter, III http://ocpsoft.org "Simpler is better." -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/windup-dev/attachments/20150105/bf4851b1/attachment.html From sgilda at redhat.com Mon Jan 5 12:18:04 2015 From: sgilda at redhat.com (Sande Gilda) Date: Mon, 05 Jan 2015 12:18:04 -0500 Subject: [windup-dev] Permanent links to latest release in Nexus... In-Reply-To: <CAEp_U4GEbLtr4FdQ-BkzShbXosn=5zt=kAsVDoKwbJ+h=tLmKQ@mail.gmail.com> References: <54AA8CD1.5090200@redhat.com> <CAEp_U4GEbLtr4FdQ-BkzShbXosn=5zt=kAsVDoKwbJ+h=tLmKQ@mail.gmail.com> Message-ID: <54AAC74C.1050203@redhat.com> If we are always guaranteed that will point to the latest release, I'll update the docs to use it. Thanks! On 01/05/2015 10:51 AM, Lincoln Baxter, III wrote: > What's wrong with this link? > > https://repository.jboss.org/nexus/service/local/artifact/maven/redirect?r=releases&g=org.jboss.windup&a=windup-distribution&v=LATEST&e=zip&c=offline > > On Mon, Jan 5, 2015 at 8:08 AM, Ondrej Zizka <ozizka at redhat.com > <mailto:ozizka at redhat.com>> wrote: > > Hi, > > We use Nexus as distribution channel. > I've asked JBoss.org about $SUBJ, since having this handled by Nexus > would be cool (always valid and up-to-date link in docs, mails, > READMEs > etc.) > > Currently there's no such option, as far as David Hladky knows, > so he asked me to create https://issues.jboss.org/browse/ORG-2382 . > > FYI. > Ondra > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org <mailto:windup-dev at lists.jboss.org> > https://lists.jboss.org/mailman/listinfo/windup-dev > > > > > -- > Lincoln Baxter, III > http://ocpsoft.org > "Simpler is better." -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/windup-dev/attachments/20150105/f8735202/attachment.html From lincolnbaxter at gmail.com Mon Jan 5 12:41:19 2015 From: lincolnbaxter at gmail.com (Lincoln Baxter, III) Date: Mon, 5 Jan 2015 12:41:19 -0500 Subject: [windup-dev] Permanent links to latest release in Nexus... In-Reply-To: <54AAC74C.1050203@redhat.com> References: <54AA8CD1.5090200@redhat.com> <CAEp_U4GEbLtr4FdQ-BkzShbXosn=5zt=kAsVDoKwbJ+h=tLmKQ@mail.gmail.com> <54AAC74C.1050203@redhat.com> Message-ID: <CAEp_U4EQwArXFUgvdsk8ayCuaGwvpDdYETdVujzxL7Sjo9=u-w@mail.gmail.com> It is :) On Mon, Jan 5, 2015 at 12:18 PM, Sande Gilda <sgilda at redhat.com> wrote: > If we are always guaranteed that will point to the latest release, I'll > update the docs to use it. Thanks! > > > On 01/05/2015 10:51 AM, Lincoln Baxter, III wrote: > > What's wrong with this link? > > > https://repository.jboss.org/nexus/service/local/artifact/maven/redirect?r=releases&g=org.jboss.windup&a=windup-distribution&v=LATEST&e=zip&c=offline > > On Mon, Jan 5, 2015 at 8:08 AM, Ondrej Zizka <ozizka at redhat.com> wrote: > >> Hi, >> >> We use Nexus as distribution channel. >> I've asked JBoss.org about $SUBJ, since having this handled by Nexus >> would be cool (always valid and up-to-date link in docs, mails, READMEs >> etc.) >> >> Currently there's no such option, as far as David Hladky knows, >> so he asked me to create https://issues.jboss.org/browse/ORG-2382 . >> >> FYI. >> Ondra >> _______________________________________________ >> windup-dev mailing list >> windup-dev at lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/windup-dev >> > > > > -- > Lincoln Baxter, III > http://ocpsoft.org > "Simpler is better." > > > -- Lincoln Baxter, III http://ocpsoft.org "Simpler is better." -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/windup-dev/attachments/20150105/f40dd515/attachment.html From sgilda at redhat.com Mon Jan 5 12:48:20 2015 From: sgilda at redhat.com (Sande Gilda) Date: Mon, 05 Jan 2015 12:48:20 -0500 Subject: [windup-dev] Permanent links to latest release in Nexus... In-Reply-To: <CAEp_U4EQwArXFUgvdsk8ayCuaGwvpDdYETdVujzxL7Sjo9=u-w@mail.gmail.com> References: <54AA8CD1.5090200@redhat.com> <CAEp_U4GEbLtr4FdQ-BkzShbXosn=5zt=kAsVDoKwbJ+h=tLmKQ@mail.gmail.com> <54AAC74C.1050203@redhat.com> <CAEp_U4EQwArXFUgvdsk8ayCuaGwvpDdYETdVujzxL7Sjo9=u-w@mail.gmail.com> Message-ID: <54AACE64.7020502@redhat.com> Done! This is better than hard-coding the link. Thanks! On 01/05/2015 12:41 PM, Lincoln Baxter, III wrote: > It is :) > > On Mon, Jan 5, 2015 at 12:18 PM, Sande Gilda <sgilda at redhat.com > <mailto:sgilda at redhat.com>> wrote: > > If we are always guaranteed that will point to the latest release, > I'll update the docs to use it. Thanks! > > > On 01/05/2015 10:51 AM, Lincoln Baxter, III wrote: >> What's wrong with this link? >> >> https://repository.jboss.org/nexus/service/local/artifact/maven/redirect?r=releases&g=org.jboss.windup&a=windup-distribution&v=LATEST&e=zip&c=offline >> >> On Mon, Jan 5, 2015 at 8:08 AM, Ondrej Zizka <ozizka at redhat.com >> <mailto:ozizka at redhat.com>> wrote: >> >> Hi, >> >> We use Nexus as distribution channel. >> I've asked JBoss.org about $SUBJ, since having this handled >> by Nexus >> would be cool (always valid and up-to-date link in docs, >> mails, READMEs >> etc.) >> >> Currently there's no such option, as far as David Hladky knows, >> so he asked me to create >> https://issues.jboss.org/browse/ORG-2382 . >> >> FYI. >> Ondra >> _______________________________________________ >> windup-dev mailing list >> windup-dev at lists.jboss.org <mailto:windup-dev at lists.jboss.org> >> https://lists.jboss.org/mailman/listinfo/windup-dev >> >> >> >> >> -- >> Lincoln Baxter, III >> http://ocpsoft.org >> "Simpler is better." > > > > > -- > Lincoln Baxter, III > http://ocpsoft.org > "Simpler is better." -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/windup-dev/attachments/20150105/baf82d24/attachment-0001.html From ozizka at redhat.com Mon Jan 5 23:47:28 2015 From: ozizka at redhat.com (Ondrej Zizka) Date: Tue, 06 Jan 2015 05:47:28 +0100 Subject: [windup-dev] Permanent links to latest release in Nexus... In-Reply-To: <54AAC74C.1050203@redhat.com> References: <54AA8CD1.5090200@redhat.com> <CAEp_U4GEbLtr4FdQ-BkzShbXosn=5zt=kAsVDoKwbJ+h=tLmKQ@mail.gmail.com> <54AAC74C.1050203@redhat.com> Message-ID: <54AB68E0.7030900@redhat.com> Nice, I didn't know about this. And David did not either :) How did you get the link? Ondra On 5.1.2015 18:18, Sande Gilda wrote: > If we are always guaranteed that will point to the latest release, > I'll update the docs to use it. Thanks! > > On 01/05/2015 10:51 AM, Lincoln Baxter, III wrote: >> What's wrong with this link? >> >> https://repository.jboss.org/nexus/service/local/artifact/maven/redirect?r=releases&g=org.jboss.windup&a=windup-distribution&v=LATEST&e=zip&c=offline >> >> On Mon, Jan 5, 2015 at 8:08 AM, Ondrej Zizka <ozizka at redhat.com >> <mailto:ozizka at redhat.com>> wrote: >> >> Hi, >> >> We use Nexus as distribution channel. >> I've asked JBoss.org about $SUBJ, since having this handled by Nexus >> would be cool (always valid and up-to-date link in docs, mails, >> READMEs >> etc.) >> >> Currently there's no such option, as far as David Hladky knows, >> so he asked me to create https://issues.jboss.org/browse/ORG-2382 . >> >> FYI. >> Ondra >> _______________________________________________ >> windup-dev mailing list >> windup-dev at lists.jboss.org <mailto:windup-dev at lists.jboss.org> >> https://lists.jboss.org/mailman/listinfo/windup-dev >> >> >> >> >> -- >> Lincoln Baxter, III >> http://ocpsoft.org >> "Simpler is better." > > > > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/windup-dev/attachments/20150106/1c0b5d79/attachment.html From lincolnbaxter at gmail.com Tue Jan 6 00:06:07 2015 From: lincolnbaxter at gmail.com (Lincoln Baxter, III) Date: Tue, 6 Jan 2015 00:06:07 -0500 Subject: [windup-dev] Permanent links to latest release in Nexus... In-Reply-To: <54AB68E0.7030900@redhat.com> References: <54AA8CD1.5090200@redhat.com> <CAEp_U4GEbLtr4FdQ-BkzShbXosn=5zt=kAsVDoKwbJ+h=tLmKQ@mail.gmail.com> <54AAC74C.1050203@redhat.com> <54AB68E0.7030900@redhat.com> Message-ID: <CAEp_U4G3Lgzcr6NC3Lf-2fdJ-CaYdw5ur1nSgsP3TD+3b62awA@mail.gmail.com> I actually think George or I found it by playing with the nexus URLs a long time ago. We were trying to figure out how to do this same thing for the Forge website/docs. On Mon, Jan 5, 2015 at 11:47 PM, Ondrej Zizka <ozizka at redhat.com> wrote: > Nice, I didn't know about this. And David did not either :) > How did you get the link? > > Ondra > > > > > On 5.1.2015 18:18, Sande Gilda wrote: > > If we are always guaranteed that will point to the latest release, I'll > update the docs to use it. Thanks! > > On 01/05/2015 10:51 AM, Lincoln Baxter, III wrote: > > What's wrong with this link? > > > https://repository.jboss.org/nexus/service/local/artifact/maven/redirect?r=releases&g=org.jboss.windup&a=windup-distribution&v=LATEST&e=zip&c=offline > > On Mon, Jan 5, 2015 at 8:08 AM, Ondrej Zizka <ozizka at redhat.com> wrote: > >> Hi, >> >> We use Nexus as distribution channel. >> I've asked JBoss.org about $SUBJ, since having this handled by Nexus >> would be cool (always valid and up-to-date link in docs, mails, READMEs >> etc.) >> >> Currently there's no such option, as far as David Hladky knows, >> so he asked me to create https://issues.jboss.org/browse/ORG-2382 . >> >> FYI. >> Ondra >> _______________________________________________ >> windup-dev mailing list >> windup-dev at lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/windup-dev >> > > > > -- > Lincoln Baxter, III > http://ocpsoft.org > "Simpler is better." > > > > > _______________________________________________ > windup-dev mailing listwindup-dev at lists.jboss.orghttps://lists.jboss.org/mailman/listinfo/windup-dev > > > > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev > -- Lincoln Baxter, III http://ocpsoft.org "Simpler is better." -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/windup-dev/attachments/20150106/4531fe78/attachment.html From lincolnbaxter at gmail.com Wed Jan 7 10:42:38 2015 From: lincolnbaxter at gmail.com (Lincoln Baxter, III) Date: Wed, 7 Jan 2015 10:42:38 -0500 Subject: [windup-dev] Windup meeting minutes - 2015-01-07 Message-ID: <CAEp_U4HRDORYMHonM=ePSJV8W9fwNC0oJSvrJpB=xmBpm744dw@mail.gmail.com> Minutes: http://transcripts.jboss.org/meeting/irc.freenode.org/windup/2015/windup.2015-01-07-15.04.html Minutes (text): http://transcripts.jboss.org/meeting/irc.freenode.org/windup/2015/windup.2015-01-07-15.04.txt Log: http://transcripts.jboss.org/meeting/irc.freenode.org/windup/2015/windup.2015-01-07-15.04.log.html Meeting summary --------------- * Agenda (lincolnthree, 15:05:12) * Status Reports (lincolnthree, 15:06:35) * Previous 2 weeks - PTO (ozizka-mtg, 15:08:07) * Now finishing the "skip archives" quickstart/rulest; the part which does the scanning is done, (ozizka-mtg, 15:08:50) * Now I am putting together the part that gets data from Nexus (ozizka-mtg, 15:09:05) * I've been working on catching up with the business teams and getting back in touch with the teams doing migrations. I think we have something we can start working with actually. More on that under priorities. (lincolnthree, 15:11:17) * My next tasks are to review the PRs to fix JBDS NPE, review the Victi.ms plugin, and start getting things rolling with the field engagement teams. (lincolnthree, 15:12:00) * also, continuing to plan summit agenda with our BU team. (lincolnthree, 15:13:21) * I have also been on PTO since the last meeting (well, for most of that time) (jsightler, 15:16:40) * I have started back with bug fixes (WINDUP-452 and WINDUP-451) as well as with work on parameterizing XPath (XmlFile) (jsightler, 15:16:48) * The XPath parameterization thing is likely to be the main thing in the week ahead (jsightler, 15:17:00) * PTO also, then I fixed the problem with DTD match in XmlFile condition (it almost never worked till now) (WINDUP-445) (mbriskar, 15:17:58) * I have added tests for all the XmlHandlers that we have + added internal interfaces for operations/conditions where possible (WINDUP-424 - not merged yet) (mbriskar, 15:19:14) * and created Project addon, so now we can specify conditions based on the project dependencies (Project.dependsOnArtifact(...) completely with tests and report html files) (mbriskar, 15:20:14) * and xml handlers (mbriskar, 15:20:30) * I have also fixed Rexster to work properly in case the dependencies were unzipped.. (this happend sometimes, no idea why) (mbriskar, 15:22:26) * Next, I am going to try to investigate the IllegalStateException that is happens and is truly nondeterministic behaviour (mbriskar, 15:27:53) * Priorities (lincolnthree, 15:28:58) * Rule parameterization (jsightler is working on the next step of this) (lincolnthree, 15:29:56) * General performance and stability fixes (mostly focusing on stability) (lincolnthree, 15:30:14) * Rule review and improvement. (lincolnthree, 15:30:24) * The last priority is to work with the consulting teams (really this is a high priority, but I just listed it last) (lincolnthree, 15:36:21) * I'll be asking all of you to help with various parts of that, depending on timezone mostly for who gets what pieces. (lincolnthree, 15:36:42) * So this will just need to be worked in to the daily stuff we all do. We'll have to split our time between working on the project, and working with consultants, but I think it will be good to get our hands on running the product a little more frequenlty (lincolnthree, 15:37:33) -- Lincoln Baxter, III http://ocpsoft.org "Simpler is better." -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/windup-dev/attachments/20150107/8b6ff05c/attachment.html From robb.greathouse at redhat.com Wed Jan 7 12:19:36 2015 From: robb.greathouse at redhat.com (Robb Greathouse) Date: Wed, 7 Jan 2015 12:19:36 -0500 (EST) Subject: [windup-dev] org.springframework.context.ApplicationContext cannot be found by org.jboss.tools.windup.runtime_3.1.0.qualifier In-Reply-To: <CAEp_U4E3HgrOBJ1+Z-iDqo6+nnQVUZdAXjcaj074cLUnQDBipA@mail.gmail.com> References: <1801809267.9577967.1418517921739.JavaMail.zimbra@redhat.com> <2008717714.30838435.1418661333998.JavaMail.zimbra@redhat.com> <83087081.9928558.1418662563167.JavaMail.zimbra@redhat.com> <CAEp_U4Fp_PiwN7WFpyB-cB9pxy-Djf3TSz9SESxh--i=EUP+hw@mail.gmail.com> <1266274291.10188923.1418741384028.JavaMail.zimbra@redhat.com> <CAEp_U4GWu6zRp7S0E1+U3UJcE9OjUL5yWeP-G-3hiRiAqzYwWg@mail.gmail.com> <714147616.10388882.1418762147773.JavaMail.zimbra@redhat.com> <CAEp_U4E3HgrOBJ1+Z-iDqo6+nnQVUZdAXjcaj074cLUnQDBipA@mail.gmail.com> Message-ID: <602074868.5258516.1420651176656.JavaMail.zimbra@redhat.com> Eclipse 4.4 has also had a major upgrade to the plugin API. Might want to look at it and see if a rewrite is warranted given the big changes in both Eclipse and Windup. Robb Greathouse Chief Evangelist Middleware Business Unit JBoss, a Division of Red Hat cellphone 505-507-4906 ----- Original Message ----- > For the most part, Furnace is a black box that hands you objects :) No > special ClassLoading knowledge required, really. You can include as much as > you want on the OSGi ClassPath and furnace will give you objects just the > same (as long as you actually have those types on your class-path.) But I > think it's fine if we continue to try to get 1.0 working, I just don't want > to deplete your time and energy on this, because I think your time is very > valuable :) > A few things to know: > * Furnace is just a runtime & container. It handles object instantiation and > creates a modular classloading environment that is mostly transparent. > * Anything you take from inside Furnace and use outside, will be a proxy of > the actual object. This means that objects and services requested from and > passed in to Furnace must be proxy-able. > * Furnace can be started and stopped. Once stopped, you should immediately > drop all references and clean up any lingering registries where .class > instances might be held (otherwise you will get classloader memory leaks.) > But let's continue with the path we are on. I think that simply adding the > spring jars that contain ApplicationContext.class to the OSGi/eclipse > classpath will resolve this problem. > ~Lincoln > On Tue, Dec 16, 2014 at 3:35 PM, Ian Tewksbury < itewksbu at redhat.com > wrote: > > My only worry is I am still not understanding how to correctly leverage > > forge/furnace to do the class loading properly and trying to do that at the > > same time as switching APIs could make things even more difficult. In both > > the new windup I am assuming it has third party jar dependencies, just like > > windup 1.0 does, so I would run into the same issues. IF you think for some > > reason the design of 2.0 would be such that I am less likely to be hitting > > these class loading issues I will just bite the bullet and try and do the > > switch over at the same time. It would just help my brain a lot if I could > > get 1.0 working so I have a better baseline of comparison when I then break > > everything to work with 2.0. I am afraid I wont know whether I am debugging > > API changes or class loading forge/furnace changes if I am doing both at > > the > > same time. > > > From: "Lincoln Baxter, III" < lincolnbaxter at gmail.com > > > > To: "Windup-dev List" < windup-dev at lists.jboss.org > > > > Sent: Tuesday, December 16, 2014 1:13:01 PM > > > Subject: Re: [windup-dev] org.springframework.context.ApplicationContext > > cannot be found by org.jboss.tools.windup.runtime_3.1.0.qualifier > > > Since windup 2.0 is in no way backwards compatible with Windup 1.0, and the > > APIs you'll need probably don't exist in Windup 2.0 yet, I suspect that we > > will be solving unnecessary problems (like seemingly Spring related issues > > such as this one) by trying to stand up Windup 1 at this point, but that's > > fine, we can do this first. > > > ~Lincoln > > > On Tue, Dec 16, 2014 at 9:49 AM, Ian Tewksbury < itewksbu at redhat.com > > > wrote: > > > > Lincoln, > > > > > > I didn't want to try to bite off more then I can chew at once. Hence I > > > want > > > to make sure I can load windup via forge/furnace before I also try to > > > switch > > > over to using the new windup. If I can load one version with forge then I > > > can load any version. But right now I can't load the version I had > > > working, > > > which means if I tried to switch to loading Windup 2.0 I would be dealing > > > with new API and class loading issues at the same time. > > > > > > So first goal, load windup 1 via forge, once I can see I can do that, > > > then > > > I > > > can switch out for windup 2. > > > > > > I have a hunch about the class loading issues, but I will put that > > > conversation on the forge forum because it seems the best place. > > > > > > Blue Skies, > > > > > > ~Ian > > > > > > From: "Lincoln Baxter, III" < lincolnbaxter at gmail.com > > > > > > > To: "Windup-dev List" < windup-dev at lists.jboss.org > > > > > > > Sent: Monday, December 15, 2014 4:22:57 PM > > > > > > Subject: Re: [windup-dev] org.springframework.context.ApplicationContext > > > cannot be found by org.jboss.tools.windup.runtime_3.1.0.qualifier > > > > > > Hey Ian, > > > > > > Glad to see you! Sorry you're having trouble getting this up and running > > > again (as you said, not sure we ever did get it there.) > > > > > > At this point, I would abandon using the Legacy windup codebase. We've > > > long > > > since stopped working on it. My suggestion, now, would be to update to > > > the > > > Windup 2.0.0.Beta6 (or SNAPSHOT) version, and start picking things up > > > from > > > there. > > > > > > As I recall, we weren't ready at the time of your last attempt, to > > > produce > > > a > > > report, or information that you could consume in Eclipse, but I do > > > believe > > > we are at that point now. > > > > > > To answer some of your questions: > > > > > > * The addon needs to contain any required JARs from libraries that are > > > included. It won't go out and find things on the fly - everything must be > > > bundled. > > > > > > * The new entry point for Windup is used here in WindupCommand (you > > > should > > > be > > > able to use this as an example): > > > https://github.com/windup/windup/blob/master/ui/src/main/java/org/jboss/windup/ui/WindupCommand.java#L249 > > > - > > > > > > * You pretty much just need to ask Furnace for instances of: > > > > > > org.jboss.windup.graph.GraphContextFactory ; > > > > > > > > > > > > org.jboss.windup.exec.WindupProcessor ; > > > > > > The rest "should" be self explanatory via the example. > > > > > > ~Lincoln > > > > > > On Mon, Dec 15, 2014 at 11:56 AM, Ian Tewksbury < itewksbu at redhat.com > > > > wrote: > > > > > > > Robb, > > > > > > > > > > I am not using it. Windup is attempting to use it as it is loading its > > > > rules. > > > > This issue is not really spring specfic, spring just happens to be the > > > > first > > > > JAR that is having issues being loaded. The issue is indicitive of a > > > > larger > > > > problem. Forge/Furnace is not getting queried when trying to load > > > > classes > > > > that are in JARs provided by the addon. > > > > > > > > > > Blue Skies, > > > > > > > > > > ~Ian > > > > > > > > > > From: "Robb Greathouse" < robb.greathouse at redhat.com > > > > > > > > > > > To: "Windup-dev List" < windup-dev at lists.jboss.org > > > > > > > > > > > Sent: Monday, December 15, 2014 11:35:34 AM > > > > > > > > > > Subject: Re: [windup-dev] > > > > org.springframework.context.ApplicationContext > > > > cannot be found by org.jboss.tools.windup.runtime_3.1.0.qualifier > > > > > > > > > > Hi, > > > > > > > > > > Quick question. How do you use springframework in eclipse? > > > > > > > > > > Robb Greathouse > > > > > > > > > > Chief Evangelist > > > > > > > > > > Middleware Business Unit > > > > > > > > > > JBoss, a Division of Red Hat > > > > > > > > > > cellphone 505-507-4906 > > > > > > > > > > > Linconln, > > > > > > > > > > > > > > > I am trying to get Eclipse to be able to load windup legacy with > > > > > Forge > > > > > and > > > > > have run into the error I think I was running into months ago when I > > > > > last > > > > > tried this. The legacy-windup-engine depends on ApplicationContext as > > > > > a > > > > > maven dependency but Eclipse/Forage does not seem to be able find the > > > > > dependency. I have honestly forget how Forge is supposed to work at > > > > > this > > > > > point. I thought Forge should automatically be finding all the > > > > > required > > > > > dependencies of the jars in the add-on. But maybe I am crazy. Does > > > > > the > > > > > addon > > > > > need to include all the jars that the legacy-windup jars depend on? > > > > > > > > > > > > > > > Blue Skies, > > > > > > > > > > > > > > > ~Ian > > > > > > > > > > > > > > > java.lang.NoClassDefFoundError: > > > > > org/springframework/context/ApplicationContext > > > > > > > > > > > > > > > at java.lang.Class.getDeclaredMethods0(Native Method) > > > > > > > > > > > > > > > at java.lang.Class.privateGetDeclaredMethods(Class.java:2531) > > > > > > > > > > > > > > > at java.lang.Class.getDeclaredMethods(Class.java:1855) > > > > > > > > > > > > > > > at > > > > > org.jboss.forge.furnace.proxy.javassist.util.proxy.SecurityActions.getDeclaredMethods(SecurityActions.java:30) > > > > > > > > > > > > > > > at > > > > > org.jboss.forge.furnace.proxy.javassist.util.proxy.ProxyFactory.getMethods(ProxyFactory.java:1121) > > > > > > > > > > > > > > > at > > > > > org.jboss.forge.furnace.proxy.javassist.util.proxy.ProxyFactory.getMethods(ProxyFactory.java:1098) > > > > > > > > > > > > > > > at > > > > > org.jboss.forge.furnace.proxy.javassist.util.proxy.ProxyFactory.makeSortedMethodList(ProxyFactory.java:803) > > > > > > > > > > > > > > > at > > > > > org.jboss.forge.furnace.proxy.javassist.util.proxy.ProxyFactory.computeSignature(ProxyFactory.java:810) > > > > > > > > > > > > > > > at > > > > > org.jboss.forge.furnace.proxy.javassist.util.proxy.ProxyFactory.createClass(ProxyFactory.java:398) > > > > > > > > > > > > > > > at > > > > > org.jboss.forge.furnace.proxy.ClassLoaderAdapterCallback$3.call(ClassLoaderAdapterCallback.java:987) > > > > > > > > > > > > > > > at > > > > > org.jboss.forge.furnace.util.ClassLoaders.executeIn(ClassLoaders.java:42) > > > > > > > > > > > > > > > at > > > > > org.jboss.forge.furnace.proxy.ClassLoaderAdapterCallback.enhance(ClassLoaderAdapterCallback.java:900) > > > > > > > > > > > > > > > at > > > > > org.jboss.forge.furnace.proxy.ClassLoaderAdapterCallback.enhanceResult(ClassLoaderAdapterCallback.java:277) > > > > > > > > > > > > > > > at > > > > > org.jboss.forge.furnace.proxy.ClassLoaderAdapterCallback.access$200(ClassLoaderAdapterCallback.java:37) > > > > > > > > > > > > > > > at > > > > > org.jboss.forge.furnace.proxy.ClassLoaderAdapterCallback$2.call(ClassLoaderAdapterCallback.java:124) > > > > > > > > > > > > > > > at > > > > > org.jboss.forge.furnace.util.ClassLoaders.executeIn(ClassLoaders.java:42) > > > > > > > > > > > > > > > at > > > > > org.jboss.forge.furnace.proxy.ClassLoaderAdapterCallback.invoke(ClassLoaderAdapterCallback.java:96) > > > > > > > > > > > > > > > at > > > > > org.jboss.windup.WindupFactory_$$_javassist_ffb85582-a284-4183-a727-6db372ddc32c.createWindupEngine(WindupFactory_$$_javassist_ffb85582-a284-4183-a727-6db372ddc32c.java) > > > > > > > > > > > > > > > at > > > > > org.jboss.tools.windup.core.WindupService.getWindupEngine(WindupService.java:391) > > > > > > > > > > > > > > > at > > > > > org.jboss.tools.windup.core.WindupService.getWindupReportEngine(WindupService.java:412) > > > > > > > > > > > > > > > at > > > > > org.jboss.tools.windup.core.WindupService.generateReport(WindupService.java:250) > > > > > > > > > > > > > > > at > > > > > org.jboss.tools.windup.core.WindupService.generateReport(WindupService.java:186) > > > > > > > > > > > > > > > at > > > > > org.jboss.tools.windup.ui.internal.commands.GenerateWindupReportHandler$1.run(GenerateWindupReportHandler.java:78) > > > > > > > > > > > > > > > at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54) > > > > > > > > > > > > > > > Caused by: java.lang.ClassNotFoundException: > > > > > org.springframework.context.ApplicationContext cannot be found by > > > > > org.jboss.tools.windup.runtime_3.1.0.qualifier > > > > > > > > > > > > > > > at > > > > > org.eclipse.osgi.internal.loader.BundleLoader.findClassInternal(BundleLoader.java:432) > > > > > > > > > > > > > > > at > > > > > org.eclipse.osgi.internal.loader.BundleLoader.findClass(BundleLoader.java:345) > > > > > > > > > > > > > > > at > > > > > org.eclipse.osgi.internal.loader.BundleLoader.findClass(BundleLoader.java:337) > > > > > > > > > > > > > > > at > > > > > org.eclipse.osgi.internal.loader.ModuleClassLoader.loadClass(ModuleClassLoader.java:160) > > > > > > > > > > > > > > > at java.lang.ClassLoader.loadClass(ClassLoader.java:358) > > > > > > > > > > > > > > > ... 24 more > > > > > > > > > > > > > > > _______________________________________________ > > > > > > > > > > > > > > > windup-dev mailing list > > > > > > > > > > > > > > > windup-dev at lists.jboss.org > > > > > > > > > > > > > > > https://lists.jboss.org/mailman/listinfo/windup-dev > > > > > > > > > > > > > > _______________________________________________ > > > > > > > > > > windup-dev mailing list > > > > > > > > > > windup-dev at lists.jboss.org > > > > > > > > > > https://lists.jboss.org/mailman/listinfo/windup-dev > > > > > > > > > > _______________________________________________ > > > > > > > > > > windup-dev mailing list > > > > > > > > > > windup-dev at lists.jboss.org > > > > > > > > > > https://lists.jboss.org/mailman/listinfo/windup-dev > > > > > > > > > -- > > > > > > Lincoln Baxter, III > > > > > > http://ocpsoft.org > > > > > > "Simpler is better." > > > > > > _______________________________________________ > > > > > > windup-dev mailing list > > > > > > windup-dev at lists.jboss.org > > > > > > https://lists.jboss.org/mailman/listinfo/windup-dev > > > > > > _______________________________________________ > > > > > > windup-dev mailing list > > > > > > windup-dev at lists.jboss.org > > > > > > https://lists.jboss.org/mailman/listinfo/windup-dev > > > > > -- > > > Lincoln Baxter, III > > > http://ocpsoft.org > > > "Simpler is better." > > > _______________________________________________ > > > windup-dev mailing list > > > windup-dev at lists.jboss.org > > > https://lists.jboss.org/mailman/listinfo/windup-dev > > > _______________________________________________ > > > windup-dev mailing list > > > windup-dev at lists.jboss.org > > > https://lists.jboss.org/mailman/listinfo/windup-dev > > -- > Lincoln Baxter, III > http://ocpsoft.org > "Simpler is better." > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/windup-dev/attachments/20150107/c426eea0/attachment-0001.html From jsightle at redhat.com Fri Jan 9 11:16:53 2015 From: jsightle at redhat.com (Jess Sightler) Date: Fri, 09 Jan 2015 11:16:53 -0500 Subject: [windup-dev] Windup 2.0.0.Beta8 Released Message-ID: <54AFFEF5.2010900@redhat.com> Download: https://repository.jboss.org/nexus/service/local/repositories/releases/content/org/jboss/windup/windup-distribution/2.0.0.Beta8/windup-distribution-2.0.0.Beta8-offline.zip Issues resolved in this release: BugWINDUP-455 <https://issues.jboss.org/browse/WINDUP-455> Can't compile against Java 8 BugWINDUP-452 <https://issues.jboss.org/browse/WINDUP-452> NPE when executing windup from addon within Forge plugin in JBDS BugWINDUP-451 <https://issues.jboss.org/browse/WINDUP-451> Seeing NullPointerException when executing windup -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/windup-dev/attachments/20150109/778669b9/attachment.html -------------- next part -------------- A non-text attachment was scrubbed... Name: bug.png Type: image/png Size: 1017 bytes Desc: not available Url : http://lists.jboss.org/pipermail/windup-dev/attachments/20150109/778669b9/attachment.png From itewksbu at redhat.com Fri Jan 9 13:42:31 2015 From: itewksbu at redhat.com (Ian Tewksbury) Date: Fri, 9 Jan 2015 13:42:31 -0500 (EST) Subject: [windup-dev] JUnit errors In-Reply-To: <1715684841.5330635.1420828901865.JavaMail.zimbra@redhat.com> Message-ID: <1125324942.5330901.1420828951184.JavaMail.zimbra@redhat.com> I just synced with the latest from windup master and the following JUnits are failing on a mvn clean install. Is this a known problem? Am I possibly doing something wrong? Failed tests: XMLFileNestedConditionTest.testNestedCondition:128 expected:<1> but was:<0> GroovyExtensionXmlRulesTest.testHintsAndClassificationOperation:120 expected:<2> but was:<0> XMLHintsClassificationsTest.testHintAndClassificationOperation:130 expected:<2> but was:<0> XMLTransformationXMLRulesTest.testXSLTTransformation:118 null XMLTransformationTest.testXSLTTransformation:126 null Blue Skies, ~Ian -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/windup-dev/attachments/20150109/d76da668/attachment.html From jsightle at redhat.com Fri Jan 9 13:46:11 2015 From: jsightle at redhat.com (Jess Sightler) Date: Fri, 09 Jan 2015 13:46:11 -0500 Subject: [windup-dev] JUnit errors In-Reply-To: <1125324942.5330901.1420828951184.JavaMail.zimbra@redhat.com> References: <1125324942.5330901.1420828951184.JavaMail.zimbra@redhat.com> Message-ID: <54B021F3.6060009@redhat.com> The jenkins build completed successfully last night with 0 errors. It definitely isn't a known problem. Could these failures be Windows specific? What platform are you using for the tests? On 01/09/2015 01:42 PM, Ian Tewksbury wrote: > I just synced with the latest from windup master and the following > JUnits are failing on a mvn clean install. Is this a known problem? Am > I possibly doing something wrong? > > > Failed tests: > XMLFileNestedConditionTest.testNestedCondition:128 expected:<1> but > was:<0> > GroovyExtensionXmlRulesTest.testHintsAndClassificationOperation:120 > expected:<2> but was:<0> > XMLHintsClassificationsTest.testHintAndClassificationOperation:130 > expected:<2> but was:<0> > XMLTransformationXMLRulesTest.testXSLTTransformation:118 null > XMLTransformationTest.testXSLTTransformation:126 null > > > Blue Skies, > > ~Ian > > > > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev -- Calendar Free/Busy: https://www.google.com/calendar/embed?src=jsightle%40redhat.com&ctz=America/New_York -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/windup-dev/attachments/20150109/069501b9/attachment.html From itewksbu at redhat.com Fri Jan 9 15:10:21 2015 From: itewksbu at redhat.com (Ian Tewksbury) Date: Fri, 9 Jan 2015 15:10:21 -0500 (EST) Subject: [windup-dev] JUnit errors In-Reply-To: <54B021F3.6060009@redhat.com> References: <1125324942.5330901.1420828951184.JavaMail.zimbra@redhat.com> <54B021F3.6060009@redhat.com> Message-ID: <725645735.5354415.1420834221436.JavaMail.zimbra@redhat.com> Fedora 20 ----- Original Message ----- From: "Jess Sightler" <jsightle at redhat.com> To: "Windup-dev List" <windup-dev at lists.jboss.org> Sent: Friday, January 9, 2015 1:46:11 PM Subject: Re: [windup-dev] JUnit errors The jenkins build completed successfully last night with 0 errors. It definitely isn't a known problem. Could these failures be Windows specific? What platform are you using for the tests? On 01/09/2015 01:42 PM, Ian Tewksbury wrote: I just synced with the latest from windup master and the following JUnits are failing on a mvn clean install. Is this a known problem? Am I possibly doing something wrong? Failed tests: XMLFileNestedConditionTest.testNestedCondition:128 expected:<1> but was:<0> GroovyExtensionXmlRulesTest.testHintsAndClassificationOperation:120 expected:<2> but was:<0> XMLHintsClassificationsTest.testHintAndClassificationOperation:130 expected:<2> but was:<0> XMLTransformationXMLRulesTest.testXSLTTransformation:118 null XMLTransformationTest.testXSLTTransformation:126 null Blue Skies, ~Ian _______________________________________________ windup-dev mailing list windup-dev at lists.jboss.org https://lists.jboss.org/mailman/listinfo/windup-dev -- Calendar Free/Busy: https://www.google.com/calendar/embed?src=jsightle%40redhat.com&ctz=America/New_York _______________________________________________ windup-dev mailing list windup-dev at lists.jboss.org https://lists.jboss.org/mailman/listinfo/windup-dev -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/windup-dev/attachments/20150109/f68a0145/attachment.html From ozizka at redhat.com Wed Jan 14 08:37:56 2015 From: ozizka at redhat.com (Ondrej Zizka) Date: Wed, 14 Jan 2015 14:37:56 +0100 Subject: [windup-dev] JUnit errors In-Reply-To: <725645735.5354415.1420834221436.JavaMail.zimbra@redhat.com> References: <1125324942.5330901.1420828951184.JavaMail.zimbra@redhat.com> <54B021F3.6060009@redhat.com> <725645735.5354415.1420834221436.JavaMail.zimbra@redhat.com> Message-ID: <54B67134.2050106@redhat.com> Hi Ian, yesterday Jess was fixing something WRT repeated call of matching not taking parametrization into account. Not sure if that's in latest master already. Ondra On 9.1.2015 21:10, Ian Tewksbury wrote: > Fedora 20 > > ------------------------------------------------------------------------ > *From: *"Jess Sightler" <jsightle at redhat.com> > *To: *"Windup-dev List" <windup-dev at lists.jboss.org> > *Sent: *Friday, January 9, 2015 1:46:11 PM > *Subject: *Re: [windup-dev] JUnit errors > > The jenkins build completed successfully last night with 0 errors. It > definitely isn't a known problem. Could these failures be Windows > specific? What platform are you using for the tests? > > On 01/09/2015 01:42 PM, Ian Tewksbury wrote: > > I just synced with the latest from windup master and the following > JUnits are failing on a mvn clean install. Is this a known > problem? Am I possibly doing something wrong? > > > Failed tests: > XMLFileNestedConditionTest.testNestedCondition:128 expected:<1> > but was:<0> > GroovyExtensionXmlRulesTest.testHintsAndClassificationOperation:120 expected:<2> > but was:<0> > XMLHintsClassificationsTest.testHintAndClassificationOperation:130 > expected:<2> but was:<0> > XMLTransformationXMLRulesTest.testXSLTTransformation:118 null > XMLTransformationTest.testXSLTTransformation:126 null > > > Blue Skies, > > ~Ian > > > > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev > > > -- > Calendar Free/Busy:https://www.google.com/calendar/embed?src=jsightle%40redhat.com&ctz=America/New_York > > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev > > > > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/windup-dev/attachments/20150114/c395e1f2/attachment-0001.html From jsightle at redhat.com Wed Jan 14 10:15:00 2015 From: jsightle at redhat.com (Jess Sightler) Date: Wed, 14 Jan 2015 10:15:00 -0500 Subject: [windup-dev] JUnit errors In-Reply-To: <54B67134.2050106@redhat.com> References: <1125324942.5330901.1420828951184.JavaMail.zimbra@redhat.com> <54B021F3.6060009@redhat.com> <725645735.5354415.1420834221436.JavaMail.zimbra@redhat.com> <54B67134.2050106@redhat.com> Message-ID: <54B687F4.2090205@redhat.com> That was completely unrelated to master. We are not seeing unit test failures on master on the build box (which is RHEL 7). On 01/14/2015 08:37 AM, Ondrej Zizka wrote: > Hi Ian, > > yesterday Jess was fixing something WRT repeated call of matching not > taking parametrization into account. > Not sure if that's in latest master already. > > Ondra > > > On 9.1.2015 21:10, Ian Tewksbury wrote: >> Fedora 20 >> >> ------------------------------------------------------------------------ >> *From: *"Jess Sightler" <jsightle at redhat.com> >> *To: *"Windup-dev List" <windup-dev at lists.jboss.org> >> *Sent: *Friday, January 9, 2015 1:46:11 PM >> *Subject: *Re: [windup-dev] JUnit errors >> >> The jenkins build completed successfully last night with 0 errors. It >> definitely isn't a known problem. Could these failures be Windows >> specific? What platform are you using for the tests? >> >> On 01/09/2015 01:42 PM, Ian Tewksbury wrote: >> >> I just synced with the latest from windup master and the >> following JUnits are failing on a mvn clean install. Is this a >> known problem? Am I possibly doing something wrong? >> >> >> Failed tests: >> XMLFileNestedConditionTest.testNestedCondition:128 expected:<1> >> but was:<0> >> GroovyExtensionXmlRulesTest.testHintsAndClassificationOperation:120 >> expected:<2> but was:<0> >> XMLHintsClassificationsTest.testHintAndClassificationOperation:130 expected:<2> >> but was:<0> >> XMLTransformationXMLRulesTest.testXSLTTransformation:118 null >> XMLTransformationTest.testXSLTTransformation:126 null >> >> >> Blue Skies, >> >> ~Ian >> >> >> >> _______________________________________________ >> windup-dev mailing list >> windup-dev at lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/windup-dev >> >> >> -- >> Calendar Free/Busy:https://www.google.com/calendar/embed?src=jsightle%40redhat.com&ctz=America/New_York >> >> _______________________________________________ >> windup-dev mailing list >> windup-dev at lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/windup-dev >> >> >> >> _______________________________________________ >> windup-dev mailing list >> windup-dev at lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/windup-dev > > > > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev -- Calendar Free/Busy: https://www.google.com/calendar/embed?src=jsightle%40redhat.com&ctz=America/New_York -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/windup-dev/attachments/20150114/6b688152/attachment.html From lincolnbaxter at gmail.com Wed Jan 14 11:49:04 2015 From: lincolnbaxter at gmail.com (Lincoln Baxter, III) Date: Wed, 14 Jan 2015 11:49:04 -0500 Subject: [windup-dev] Windup Meeting Minutes - 2014-01-14 Message-ID: <CAEp_U4FWec690v405+g1WyWz-En1Cav-bwjDoz7iXcbWzpcP1A@mail.gmail.com> Minutes: http://transcripts.jboss.org/meeting/irc.freenode.org/windup/2015/windup.2015-01-14-15.08.html Minutes (text): http://transcripts.jboss.org/meeting/irc.freenode.org/windup/2015/windup.2015-01-14-15.08.txt Log: http://transcripts.jboss.org/meeting/irc.freenode.org/windup/2015/windup.2015-01-14-15.08.log.html Meeting summary --------------- * Agenda (lincolnthree, 15:09:21) * Status Reports (lincolnthree, 15:12:07) * (mbriskar) Working on the IllegalStateException issue thrown from Furnace. I have tried several tweaks in the test runner, none of which worked, so the problem is probably somewhere deep inside furnace states/race condition that causes addons to never be loaded. If that's not enough, after adding several printlns, some ModuleClassLoader issue happens in which some classes are not loaded (no idea why/what happened, somet (lincolnthree, 15:12:30) * I have been working on several things. I've performed a review of the Victi.ms addon and reported some feedback. There is still one more problem I am looking at related to runnign Victi.ms in Eclipse (it seems to crash for some reason, so I need to figure out why) (lincolnthree, 15:14:42) * I've also been brainstorming with jess and working on the XmlFile condition parameterization, which I think is almost there (due to Jess's diligence) (lincolnthree, 15:15:33) * I've also been meeting with RHC teams in Europe to get apps and feedback from them, but feedback comes very slowly. (lincolnthree, 15:16:00) * Lastly, I've been preparing for our Rule Review, which I'll talk about in next steps. (lincolnthree, 15:16:23) * I worked on: (ozizka, 15:18:16) * WINDUP-398 Rules request: Ignored jars by G:A:V and hashes - done (ozizka, 15:18:17) * WINDUP-355 Rules request: Report artifacts/jars that contain security vulnerabilities; use Victi.ms - applying Lincoln's review notes (ozizka, 15:18:17) * (these are in the windup/windup-quickstarts repo) (ozizka, 15:18:47) * I have worked on parameters with XmlFile (parameterized xpath) - WINDUP-448, along with quite a bit of help from lincolnthree (jsightler, 15:20:27) * We have a first implementation now that seems to work pretty well (although it needs more testing), so hopefully the main remaining tasks here are to clean things up and make the code better (jsightler, 15:22:07) * Priorities and Next Steps (lincolnthree, 15:23:55) * #1. Rule review, storage, and organizatiopn (lincolnthree, 15:25:08) * I've prepared a document to track our rule review, here on GDrive: https://docs.google.com/spreadsheets/d/19xaibv1xZr1L3ss256A9ak08oqg-zFxuvzlmOHiMtHw/edit#gid=1133431410 (lincolnthree, 15:25:43) * So what this rule review means is that we need to evaluate all of the rules we currently store in XML in Windup addons, organize them, fill in missing information, add KBase links and links to relevant documentation, and figure out where they should be stored. (lincolnthree, 15:27:58) * this needs to be done before we release Windup 2.0.0.Final at the end of this month. (lincolnthree, 15:28:13) * #2. Adding a default ignore list to the distribution, in $WINDUP_HOME/ignore/ (lincolnthree, 15:28:54) * This ignore list should skip every JAR in Maven central (if possible) (lincolnthree, 15:29:18) * #3. Finish the rule parameterization for XML files. (lincolnthree, 15:30:51) * #4. Continue to fix any bugs or crashes that we find. (lincolnthree, 15:30:59) * How to store ruleset metadata/docs - or - when we plan to start building an online (web)app (lincolnthree, 15:36:34) * An online app that would allow users to suggest new rules, store the existing rules + metadata, bundle and release latest set of rules, etc is way ahead of where we are now. (ozizka, 15:41:40) * But it is really something that I think would help people contribute, so definitely worth investing in when we get to that stage of maturity (lincolnthree, 15:42:12) -- Lincoln Baxter, III http://ocpsoft.org "Simpler is better." -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/windup-dev/attachments/20150114/da091cb8/attachment.html From lincoln at redhat.com Thu Jan 15 18:20:52 2015 From: lincoln at redhat.com (Lincoln Baxter, III) Date: Thu, 15 Jan 2015 18:20:52 -0500 (EST) Subject: [windup-dev] New rule when merging PRs - Close the issue! Message-ID: <605962565.11470457.1421364052150.JavaMail.zimbra@redhat.com> If you merge a pull request, also close the related issue and make sure the Fix Version and Assignee fields are set. Thanks guys, -- Lincoln Baxter, III JBoss, by Red Hat lbaxter at redhat.com "If you want something, you'll find a way; if you don't, you'll find an excuse." From lincolnbaxter at gmail.com Thu Jan 15 19:11:07 2015 From: lincolnbaxter at gmail.com (Lincoln Baxter, III) Date: Thu, 15 Jan 2015 19:11:07 -0500 Subject: [windup-dev] New rule when merging PRs - Close the issue! In-Reply-To: <605962565.11470457.1421364052150.JavaMail.zimbra@redhat.com> References: <605962565.11470457.1421364052150.JavaMail.zimbra@redhat.com> Message-ID: <CAEp_U4GQR+cWF==QP0K6MfAeqz+4Qg5CCZrNNS3QigWkiVATuw@mail.gmail.com> Better yet. If it's unclear if there's more work, actually ask if the issue is closed. Use common sense here. If you're not sure if it's done, have a conversation. But the point is. We have WAY too many issues open in JIRA that are actually fixed or finished. We can do better. On Thu, Jan 15, 2015 at 6:20 PM, Lincoln Baxter, III <lincoln at redhat.com> wrote: > If you merge a pull request, also close the related issue and make sure > the Fix Version and Assignee fields are set. > > Thanks guys, > -- > Lincoln Baxter, III > JBoss, by Red Hat > lbaxter at redhat.com > > "If you want something, you'll find a way; if you don't, you'll find an > excuse." > > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev > -- Lincoln Baxter, III http://ocpsoft.org "Simpler is better." -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/windup-dev/attachments/20150115/f22c89c7/attachment.html From lincoln at redhat.com Thu Jan 15 19:48:43 2015 From: lincoln at redhat.com (Lincoln Baxter, III) Date: Thu, 15 Jan 2015 19:48:43 -0500 (EST) Subject: [windup-dev] Preliminary list of issues to resolve for 2.0.0.Final Message-ID: <889749325.11494643.1421369323356.JavaMail.zimbra@redhat.com> Please see attached list - subject to discussion and change: https://issues.jboss.org/issues/?jql=project%20%3D%20WINDUP%20AND%20resolution%20%3D%20Unresolved%20AND%20fixVersion%20%3D%202.0.0.Final%20ORDER%20BY%20key%20ASC%2C%20priority%20DESC ~Lincoln -- Lincoln Baxter, III JBoss, by Red Hat lbaxter at redhat.com "If you want something, you'll find a way; if you don't, you'll find an excuse." From lincolnbaxter at gmail.com Thu Jan 15 23:11:55 2015 From: lincolnbaxter at gmail.com (Lincoln Baxter, III) Date: Thu, 15 Jan 2015 23:11:55 -0500 Subject: [windup-dev] JIRA Cleanup Message-ID: <CAEp_U4HHoG86viqpOHSz3t_tYb_WazTSWvSMuCuQ+-=4GfGCJA@mail.gmail.com> Hey Team, Just wanted to let you know that I did some (quite a bit of) JIRA cleanup. I've close a lot of old issues that hadn't seen any progress in a long time. That's not to say that they can't be reopened if we want to implement one, but I wanted to reduce the noise in JIRA and make it easier to find things. Additionally, I probably closed about 30 issues that were already completed. So let's try (as I mentioned in my other email) to do a better job with closing issues when they are completed. I'm going to be continuing to sort issues into the 2.0.0.Final version tag so that we can focus on getting this release out. I know I missed a few things that people are currently working on, but I'll get to it, or remind me and I'll put it in (or tag it yourselves.) Cheers! -- Lincoln Baxter, III http://ocpsoft.org "Simpler is better." -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/windup-dev/attachments/20150115/b3636f1a/attachment.html From ozizka at redhat.com Fri Jan 16 11:53:09 2015 From: ozizka at redhat.com (Ondrej Zizka) Date: Fri, 16 Jan 2015 17:53:09 +0100 Subject: [windup-dev] JIRA Cleanup In-Reply-To: <CAEp_U4HHoG86viqpOHSz3t_tYb_WazTSWvSMuCuQ+-=4GfGCJA@mail.gmail.com> References: <CAEp_U4HHoG86viqpOHSz3t_tYb_WazTSWvSMuCuQ+-=4GfGCJA@mail.gmail.com> Message-ID: <54B941F5.8050300@redhat.com> On a related note, would it be acceptable not to create JIRAs for small changes like typos or changes in wording of messages? That clutters the jira and inflates the volume of items to review regularly. Could just a PR be enough? Ondra On 16.1.2015 05:11, Lincoln Baxter, III wrote: > Hey Team, > > Just wanted to let you know that I did some (quite a bit of) JIRA > cleanup. I've close a lot of old issues that hadn't seen any progress > in a long time. That's not to say that they can't be reopened if we > want to implement one, but I wanted to reduce the noise in JIRA and > make it easier to find things. > > Additionally, I probably closed about 30 issues that were already > completed. So let's try (as I mentioned in my other email) to do a > better job with closing issues when they are completed. > > I'm going to be continuing to sort issues into the 2.0.0.Final version > tag so that we can focus on getting this release out. I know I missed > a few things that people are currently working on, but I'll get to it, > or remind me and I'll put it in (or tag it yourselves.) > > Cheers! > > -- > Lincoln Baxter, III > http://ocpsoft.org > "Simpler is better." > > > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/windup-dev/attachments/20150116/f44e1f19/attachment.html From ozizka at redhat.com Fri Jan 16 11:54:49 2015 From: ozizka at redhat.com (Ondrej Zizka) Date: Fri, 16 Jan 2015 17:54:49 +0100 Subject: [windup-dev] New rule when merging PRs - Close the issue! In-Reply-To: <CAEp_U4GQR+cWF==QP0K6MfAeqz+4Qg5CCZrNNS3QigWkiVATuw@mail.gmail.com> References: <605962565.11470457.1421364052150.JavaMail.zimbra@redhat.com> <CAEp_U4GQR+cWF==QP0K6MfAeqz+4Qg5CCZrNNS3QigWkiVATuw@mail.gmail.com> Message-ID: <54B94259.1000906@redhat.com> +1. Also - if unsure, how about Resolving and asking to close? I think that's what that state is supposed to be for, or at least we can use it that way. Ondra On 16.1.2015 01:11, Lincoln Baxter, III wrote: > Better yet. If it's unclear if there's more work, actually ask if the > issue is closed. Use common sense here. If you're not sure if it's > done, have a conversation. But the point is. We have WAY too many > issues open in JIRA that are actually fixed or finished. We can do better. > > On Thu, Jan 15, 2015 at 6:20 PM, Lincoln Baxter, III > <lincoln at redhat.com <mailto:lincoln at redhat.com>> wrote: > > If you merge a pull request, also close the related issue and make > sure the Fix Version and Assignee fields are set. > > Thanks guys, > -- > Lincoln Baxter, III > JBoss, by Red Hat > lbaxter at redhat.com <mailto:lbaxter at redhat.com> > > "If you want something, you'll find a way; if you don't, you'll > find an excuse." > > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org <mailto:windup-dev at lists.jboss.org> > https://lists.jboss.org/mailman/listinfo/windup-dev > > > > > -- > Lincoln Baxter, III > http://ocpsoft.org > "Simpler is better." > > > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/windup-dev/attachments/20150116/8250ec95/attachment.html From lincolnbaxter at gmail.com Fri Jan 16 12:19:36 2015 From: lincolnbaxter at gmail.com (Lincoln Baxter, III) Date: Fri, 16 Jan 2015 12:19:36 -0500 Subject: [windup-dev] JIRA Cleanup In-Reply-To: <54B941F5.8050300@redhat.com> References: <CAEp_U4HHoG86viqpOHSz3t_tYb_WazTSWvSMuCuQ+-=4GfGCJA@mail.gmail.com> <54B941F5.8050300@redhat.com> Message-ID: <CAEp_U4GrC_VmUtYtV0M1Dcp+BDjw9dt=hUFP7bDONRBAeGocmg@mail.gmail.com> Yeah I think that's fair. In general though, I'd prefer to only see those changes happen as part of another PR or issue where you are already touching that code. Submitting lots of small PRs to change names and do menial refactoring is more disruptive than beneficial IMO (in most cases). If something is really a problem, we should talk about it first before doing a PR, and at that point probably deserves a JIRA if it is really that big a deal that it "has to be changed on its own." On Fri, Jan 16, 2015 at 11:53 AM, Ondrej Zizka <ozizka at redhat.com> wrote: > On a related note, would it be acceptable not to create JIRAs for small > changes like typos or changes in wording of messages? That clutters the > jira and inflates the volume of items to review regularly. Could just a PR > be enough? > > Ondra > > > > On 16.1.2015 05:11, Lincoln Baxter, III wrote: > > Hey Team, > > Just wanted to let you know that I did some (quite a bit of) JIRA > cleanup. I've close a lot of old issues that hadn't seen any progress in a > long time. That's not to say that they can't be reopened if we want to > implement one, but I wanted to reduce the noise in JIRA and make it easier > to find things. > > Additionally, I probably closed about 30 issues that were already > completed. So let's try (as I mentioned in my other email) to do a better > job with closing issues when they are completed. > > I'm going to be continuing to sort issues into the 2.0.0.Final version > tag so that we can focus on getting this release out. I know I missed a few > things that people are currently working on, but I'll get to it, or remind > me and I'll put it in (or tag it yourselves.) > > Cheers! > > -- > Lincoln Baxter, III > http://ocpsoft.org > "Simpler is better." > > > _______________________________________________ > windup-dev mailing listwindup-dev at lists.jboss.orghttps://lists.jboss.org/mailman/listinfo/windup-dev > > > > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev > -- Lincoln Baxter, III http://ocpsoft.org "Simpler is better." -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/windup-dev/attachments/20150116/ba34cfad/attachment.html From lincolnbaxter at gmail.com Fri Jan 16 12:21:16 2015 From: lincolnbaxter at gmail.com (Lincoln Baxter, III) Date: Fri, 16 Jan 2015 12:21:16 -0500 Subject: [windup-dev] New rule when merging PRs - Close the issue! In-Reply-To: <54B94259.1000906@redhat.com> References: <605962565.11470457.1421364052150.JavaMail.zimbra@redhat.com> <CAEp_U4GQR+cWF==QP0K6MfAeqz+4Qg5CCZrNNS3QigWkiVATuw@mail.gmail.com> <54B94259.1000906@redhat.com> Message-ID: <CAEp_U4EzEt_UZ3dFMCmEoR=cvfRWfyuyfRbST7P1hiUBwO5Q4A@mail.gmail.com> If you prefer to mark resolved at the time of closing the PR, that's fine (I probably won't be doing that because I consider it a useless step - there're enough fields/states in JIRA that get ignored as is), but you should still track down the owner and make sure it ends up closed. In short, if you want to add an extra work for yourself, fine, but it's not required and I probably won't be doing it unless we start to see some value in doing so :) On Fri, Jan 16, 2015 at 11:54 AM, Ondrej Zizka <ozizka at redhat.com> wrote: > +1. Also - if unsure, how about Resolving and asking to close? I think > that's what that state is supposed to be for, or at least we can use it > that way. > > Ondra > > > > > On 16.1.2015 01:11, Lincoln Baxter, III wrote: > > Better yet. If it's unclear if there's more work, actually ask if the > issue is closed. Use common sense here. If you're not sure if it's done, > have a conversation. But the point is. We have WAY too many issues open in > JIRA that are actually fixed or finished. We can do better. > > On Thu, Jan 15, 2015 at 6:20 PM, Lincoln Baxter, III <lincoln at redhat.com> > wrote: > >> If you merge a pull request, also close the related issue and make sure >> the Fix Version and Assignee fields are set. >> >> Thanks guys, >> -- >> Lincoln Baxter, III >> JBoss, by Red Hat >> lbaxter at redhat.com >> >> "If you want something, you'll find a way; if you don't, you'll find an >> excuse." >> >> _______________________________________________ >> windup-dev mailing list >> windup-dev at lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/windup-dev >> > > > > -- > Lincoln Baxter, III > http://ocpsoft.org > "Simpler is better." > > > _______________________________________________ > windup-dev mailing listwindup-dev at lists.jboss.orghttps://lists.jboss.org/mailman/listinfo/windup-dev > > > > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev > -- Lincoln Baxter, III http://ocpsoft.org "Simpler is better." -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/windup-dev/attachments/20150116/791d0fdf/attachment-0001.html From jsightle at redhat.com Fri Jan 16 14:02:24 2015 From: jsightle at redhat.com (Jess Sightler) Date: Fri, 16 Jan 2015 14:02:24 -0500 Subject: [windup-dev] JIRA Cleanup In-Reply-To: <54B941F5.8050300@redhat.com> References: <CAEp_U4HHoG86viqpOHSz3t_tYb_WazTSWvSMuCuQ+-=4GfGCJA@mail.gmail.com> <54B941F5.8050300@redhat.com> Message-ID: <54B96040.4060406@redhat.com> I don't think typos in comments and things like that should need a JIRA. Refactoring of any kind really should have a JIRA, though, IMO (although it may not be a directly related JIRA if the refactoring is part of some other work). Just my .02 :) On 01/16/2015 11:53 AM, Ondrej Zizka wrote: > On a related note, would it be acceptable not to create JIRAs for > small changes like typos or changes in wording of messages? That > clutters the jira and inflates the volume of items to review > regularly. Could just a PR be enough? > > Ondra > > > On 16.1.2015 05:11, Lincoln Baxter, III wrote: >> Hey Team, >> >> Just wanted to let you know that I did some (quite a bit of) JIRA >> cleanup. I've close a lot of old issues that hadn't seen any progress >> in a long time. That's not to say that they can't be reopened if we >> want to implement one, but I wanted to reduce the noise in JIRA and >> make it easier to find things. >> >> Additionally, I probably closed about 30 issues that were already >> completed. So let's try (as I mentioned in my other email) to do a >> better job with closing issues when they are completed. >> >> I'm going to be continuing to sort issues into the 2.0.0.Final >> version tag so that we can focus on getting this release out. I know >> I missed a few things that people are currently working on, but I'll >> get to it, or remind me and I'll put it in (or tag it yourselves.) >> >> Cheers! >> >> -- >> Lincoln Baxter, III >> http://ocpsoft.org >> "Simpler is better." >> >> >> _______________________________________________ >> windup-dev mailing list >> windup-dev at lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/windup-dev > > > > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev -- Calendar Free/Busy: https://www.google.com/calendar/embed?src=jsightle%40redhat.com&ctz=America/New_York -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/windup-dev/attachments/20150116/1c78d580/attachment.html From lincolnbaxter at gmail.com Fri Jan 16 18:03:11 2015 From: lincolnbaxter at gmail.com (Lincoln Baxter, III) Date: Fri, 16 Jan 2015 18:03:11 -0500 Subject: [windup-dev] JIRA Cleanup In-Reply-To: <54B96040.4060406@redhat.com> References: <CAEp_U4HHoG86viqpOHSz3t_tYb_WazTSWvSMuCuQ+-=4GfGCJA@mail.gmail.com> <54B941F5.8050300@redhat.com> <54B96040.4060406@redhat.com> Message-ID: <CAEp_U4GW6qsOt8ShQrKyxgKQvoL-4k6o1HkkUzrSjqQNW7_yvA@mail.gmail.com> Right. On Fri, Jan 16, 2015 at 2:02 PM, Jess Sightler <jsightle at redhat.com> wrote: > I don't think typos in comments and things like that should need a JIRA. > Refactoring of any kind really should have a JIRA, though, IMO (although it > may not be a directly related JIRA if the refactoring is part of some other > work). > > Just my .02 :) > > > On 01/16/2015 11:53 AM, Ondrej Zizka wrote: > > On a related note, would it be acceptable not to create JIRAs for small > changes like typos or changes in wording of messages? That clutters the > jira and inflates the volume of items to review regularly. Could just a PR > be enough? > > Ondra > > > On 16.1.2015 05:11, Lincoln Baxter, III wrote: > > Hey Team, > > Just wanted to let you know that I did some (quite a bit of) JIRA > cleanup. I've close a lot of old issues that hadn't seen any progress in a > long time. That's not to say that they can't be reopened if we want to > implement one, but I wanted to reduce the noise in JIRA and make it easier > to find things. > > Additionally, I probably closed about 30 issues that were already > completed. So let's try (as I mentioned in my other email) to do a better > job with closing issues when they are completed. > > I'm going to be continuing to sort issues into the 2.0.0.Final version > tag so that we can focus on getting this release out. I know I missed a few > things that people are currently working on, but I'll get to it, or remind > me and I'll put it in (or tag it yourselves.) > > Cheers! > > -- > Lincoln Baxter, III > http://ocpsoft.org > "Simpler is better." > > > _______________________________________________ > windup-dev mailing listwindup-dev at lists.jboss.orghttps://lists.jboss.org/mailman/listinfo/windup-dev > > > > > _______________________________________________ > windup-dev mailing listwindup-dev at lists.jboss.orghttps://lists.jboss.org/mailman/listinfo/windup-dev > > > -- > Calendar Free/Busy: https://www.google.com/calendar/embed?src=jsightle%40redhat.com&ctz=America/New_York > > > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev > -- Lincoln Baxter, III http://ocpsoft.org "Simpler is better." -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/windup-dev/attachments/20150116/55c36f7e/attachment.html From lincolnbaxter at gmail.com Wed Jan 21 10:41:59 2015 From: lincolnbaxter at gmail.com (Lincoln Baxter, III) Date: Wed, 21 Jan 2015 10:41:59 -0500 Subject: [windup-dev] Windup Meeting Minutes - 2015-01-21 Message-ID: <CAEp_U4Go2dzZeHobHrSEsotJz=KrK9YrdK0Swqi_xz3g+sNyQw@mail.gmail.com> Minutes: http://transcripts.jboss.org/meeting/irc.freenode.org/windup/2015/windup.2015-01-21-15.03.html Minutes (text): http://transcripts.jboss.org/meeting/irc.freenode.org/windup/2015/windup.2015-01-21-15.03.txt Log: http://transcripts.jboss.org/meeting/irc.freenode.org/windup/2015/windup.2015-01-21-15.03.log.html Meeting summary --------------- * Agenda (lincolnthree, 15:04:02) * Status Reports (lincolnthree, 15:06:10) * Last week I worked mostly on preparing and giving two SA outreach presentations on Thursday and Friday (lincolnthree, 15:07:14) * This week I've been working on PR review, some design review, and setting up some more relationships with consulting teams. (lincolnthree, 15:07:36) * Today and for the rest of this week, my plan is to fix the relative paths bug in our UI, start working on the rule organization issues, and hopefully review the default ignore list. (lincolnthree, 15:08:23) * I have finished WINDUP-462 (removing now redundant org.windup @Property annotation) (jsightler, 15:09:36) * I have also finished WINDUP-448 (XmlFile parameterization) (jsightler, 15:09:50) * I am presently working on WINDUP-367 (jsightler, 15:10:13) * I will resume WINDUP-277 shortly (replacing the windup RulePhase enumeration with marker implementations of WindupRuleProvider) (jsightler, 15:10:46) * I was working on IllegalStateException, I think we are together reaching to some solution, however I can't continue now because of other things comming up (mbriskar, 15:13:02) * I worked on WINDUP-454, that means being able to ignore according to the file path (mbriskar, 15:13:25) * and worked on the rexster tests. I need to clean a little bit the commit and then I can send PR (mbriskar, 15:18:01) * I am mainly going to help people to use windup and write rules next week (mbriskar, 15:18:39) * I am continuing on SkipArchives ruleset: (ozizka, 15:21:10) * - created the Nexus index extractor (ozizka, 15:21:10) * - written the library to read the files and resolve G:A:V from SHA1 hash (ozizka, 15:21:10) * - written the HTTP retriever which would need a servlet that would find G:A:V by SHA1 hash (ozizka, 15:21:10) * - Also added another way to retrieve the same data - Solr, not sure which one is better. (ozizka, 15:21:10) * - I'll also make this depending on the --offline param (ozizka, 15:21:11) * - Writing the POM stuff that will pack the extracted mapping file into an artifact (ozizka, 15:21:11) * - Started writing the tests for SkipArchives (ozizka, 15:21:12) * Priorities & Windup 2.0.0.Final Next Steps (lincolnthree, 15:32:16) * we have a list of JIRA tasks that should get finished by .Final if possible (lincolnthree, 15:32:39) * https://issues.jboss.org/issues/?jql=project%20%3D%20WINDUP%20AND%20resolution%20%3D%20Unresolved%20AND%20fixVersion%20%3D%202.0.0.Final%20ORDER%20BY%20priority%20DESC (lincolnthree, 15:33:03) * I'll be working on some of the UI issues, and also working on restructuring the addons to fit the api/impl split layout (lincolnthree, 15:35:04) * Please focus on this list of tasks :) (lincolnthree, 15:35:20) * LINK: https://github.com/windup/windup/pull/411/files#diff-35f7c9dd98edecb1bcfdd82e2c75f12fR38 (lincolnthree, 15:40:19) -- Lincoln Baxter, III http://ocpsoft.org "Simpler is better." -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/windup-dev/attachments/20150121/46ae99e2/attachment.html From lincolnbaxter at gmail.com Thu Jan 22 00:00:05 2015 From: lincolnbaxter at gmail.com (Lincoln Baxter, III) Date: Thu, 22 Jan 2015 00:00:05 -0500 Subject: [windup-dev] Build failure question (answer) Message-ID: <CAEp_U4Eat+ybn0Y_EweP41JfNmRSGOQEh8cmx1X3+_u-o4j_FQ@mail.gmail.com> As far as I know, this is a dependency failure exception because a dependency could not be found, but it doesn't specifically say it failed in a given repository, so I'm guessing this is not the same issue. Possible that snapshots were deploying while the build was running. > hey Lincoln, can you just briefly check the output here https://10.3.9.192/job/windup-illegalstate-fix/5/console ? Is that the problem with nexus we have now? [ERROR] Failed to execute goal org.jboss.forge.furnace:furnace-maven-plugin:2.13.2-SNAPSHOT:generate-dot (generate-dot) on project facets: Execution generate-dot of goal org.jboss.forge.furnace:furnace-maven-plugin:2.13.2-SNAPSHOT:generate-dot failed: Plugin org.jboss.forge.furnace:furnace-maven-plugin:2.13.2-SNAPSHOT or one of its dependencies could not be resolved: The following artifacts could not be resolved: org.jboss.forge.furnace:furnace-api:jar:2.13.2-SNAPSHOT, org.jboss.forge.furnace:furnace-manager-spi:jar:2.13.2-SNAPSHOT: Could not find artifact org.jboss.forge.furnace:furnace-api:jar:2.13.2-SNAPSHOT -> [Help 1] -- Lincoln Baxter, III http://ocpsoft.org "Simpler is better." -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/windup-dev/attachments/20150122/7f3a3536/attachment-0001.html From ozizka at redhat.com Thu Jan 22 05:00:07 2015 From: ozizka at redhat.com (Ondrej Zizka) Date: Thu, 22 Jan 2015 11:00:07 +0100 Subject: [windup-dev] Discussion: Data files in maven repo Message-ID: <54C0CA27.4020206@redhat.com> Hi, WRT WINDUP-459 <https://issues.jboss.org/browse/WINDUP-459> Rules request: Identify archives by their hash: I guess this need (for bulk data from an external source) will appear in more rulesets. We agreed that the best way to build, store and distribute the offline data will be best through artifacts, resp. through a maven repo. 1) Should it have independent release cycle? IMO it should. 2) If so - which git repo to put it to? 3) Can Forge/Furnace work well with ZIP artifacts? I.e, if there's a <packaging>zip</packaging>, can that be an addon? 4) If something is an addon, is it better to access it as a resource on classpath, or as a zip file, after figuring out where it is on local FS? FYI, currently I just create a zip assembly windup-nexusindexreader-mappings-<V>.jar, next to windup-nexusindexreader-<V>.jar The artifact size is 45 MB. Regards, Ondra -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/windup-dev/attachments/20150122/81189b0a/attachment.html From lincolnbaxter at gmail.com Fri Jan 23 13:25:29 2015 From: lincolnbaxter at gmail.com (Lincoln Baxter, III) Date: Fri, 23 Jan 2015 13:25:29 -0500 Subject: [windup-dev] Discussion: Data files in maven repo In-Reply-To: <54C0CA27.4020206@redhat.com> References: <54C0CA27.4020206@redhat.com> Message-ID: <CAEp_U4HxPAUsjjLHMKWetKYGR_XHvLqg17uvsem6A21na0EHVQ@mail.gmail.com> 1) Eventually yes, but for now I think it's fine to tie this information to our releases. Don't worry about this for now. Businesses don't typically use the newest JARs in the legacy apps they are trying to migrate ;) We'd probably even be fine with data from 3 years ago. 2) Just put it in our main windup/windup repo for now, in the same module as the addon you're building. 3) Bundle it in the same addon that provides the functionality for now, it will be easier to include in our build. We can worry about externalizing it later. This will also allow us to create a separate distribution just in case people are worried about file size. (With Maven JAR identification / Without Maven JAR identification) 4) Better to access on the classpath because you know its location within the classloader. We can worry about externalizing it later. 45 MB is not terrible. Nice job. On Thu, Jan 22, 2015 at 5:00 AM, Ondrej Zizka <ozizka at redhat.com> wrote: > Hi, > > WRT WINDUP-459 <https://issues.jboss.org/browse/WINDUP-459> Rules > request: Identify archives by their hash: > > I guess this need (for bulk data from an external source) will appear in > more rulesets. > > We agreed that the best way to build, store and distribute the offline > data will be best through artifacts, resp. through a maven repo. > > 1) Should it have independent release cycle? IMO it should. > 2) If so - which git repo to put it to? > 3) Can Forge/Furnace work well with ZIP artifacts? I.e, if there's a > <packaging>zip</packaging>, can that be an addon? > 4) If something is an addon, is it better to access it as a resource on > classpath, or as a zip file, after figuring out where it is on local FS? > > FYI, currently I just create a zip assembly > windup-nexusindexreader-mappings-<V>.jar, next to windup-nexusindexreader > -<V>.jar > The artifact size is 45 MB. > > Regards, > Ondra > > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev > -- Lincoln Baxter, III http://ocpsoft.org "Simpler is better." -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/windup-dev/attachments/20150123/fd6d50dc/attachment.html From ozizka at redhat.com Mon Jan 26 10:04:42 2015 From: ozizka at redhat.com (Ondrej Zizka) Date: Mon, 26 Jan 2015 16:04:42 +0100 Subject: [windup-dev] WRT RulePhase changes Message-ID: <54C6578A.8030808@redhat.com> Hi, I am updating the quickstarts to match the recent changes WINDUP-277 <https://issues.jboss.org/browse/WINDUP-277> Replace Migration "Phases" with dependencies <https://issues.jboss.org/browse/WINDUP-277> . The subclasses are small and just a few. Could we move them as inner classes of RulePhase? This would be beneficial: 1) One could write "RulePhase." to get a list of built-in phases instead of going to the documentation. 2) We would get rid of several small .java files Ondra -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/windup-dev/attachments/20150126/427cd343/attachment.html From sgilda at redhat.com Mon Jan 26 11:09:26 2015 From: sgilda at redhat.com (Sande Gilda) Date: Mon, 26 Jan 2015 11:09:26 -0500 Subject: [windup-dev] WRT RulePhase changes In-Reply-To: <54C6578A.8030808@redhat.com> References: <54C6578A.8030808@redhat.com> Message-ID: <54C666B6.1030503@redhat.com> Hi Ondra, Thanks for doing this. Let me know when it's figured out and I'll update the README files and the Wiki Documentation. I don't think we ever created the XML version of Jesse's quickstart either. At that time, it wasn't possible. Do you plan to do that too? Thanks again, Sande On 01/26/2015 10:04 AM, Ondrej Zizka wrote: > Hi, > > I am updating the quickstarts to match the recent changes > WINDUP-277 <https://issues.jboss.org/browse/WINDUP-277> Replace > Migration "Phases" with dependencies > <https://issues.jboss.org/browse/WINDUP-277> . > > The subclasses are small and just a few. > Could we move them as inner classes of RulePhase? > This would be beneficial: > 1) One could write "RulePhase." to get a list of built-in phases > instead of going to the documentation. > 2) We would get rid of several small .java files > > Ondra > > > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/windup-dev/attachments/20150126/04d43495/attachment.html From lincolnbaxter at gmail.com Mon Jan 26 22:39:48 2015 From: lincolnbaxter at gmail.com (Lincoln Baxter, III) Date: Mon, 26 Jan 2015 22:39:48 -0500 Subject: [windup-dev] WRT RulePhase changes In-Reply-To: <54C6578A.8030808@redhat.com> References: <54C6578A.8030808@redhat.com> Message-ID: <CAEp_U4EfAMq6ezE94V1CUR0xUWr6U0fie6cDSWcWhSCWJ7vhHA@mail.gmail.com> Hey, good question, but no. You can always look in that package and see all of the phases we have. Or use the IDE to quick-search for types implementing RulePhase, etc. Not worth making ugly code for that when the IDE or GitHub will tell you exactly the same information. On Mon, Jan 26, 2015 at 10:04 AM, Ondrej Zizka <ozizka at redhat.com> wrote: > Hi, > > I am updating the quickstarts to match the recent changes > WINDUP-277 <https://issues.jboss.org/browse/WINDUP-277> Replace Migration > "Phases" with dependencies <https://issues.jboss.org/browse/WINDUP-277> . > > The subclasses are small and just a few. > Could we move them as inner classes of RulePhase? > This would be beneficial: > 1) One could write "RulePhase." to get a list of built-in phases instead > of going to the documentation. > 2) We would get rid of several small .java files > > Ondra > > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev > -- Lincoln Baxter, III http://ocpsoft.org "Simpler is better." -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/windup-dev/attachments/20150126/18e102d3/attachment.html From ozizka at redhat.com Tue Jan 27 16:26:59 2015 From: ozizka at redhat.com (Ondrej Zizka) Date: Tue, 27 Jan 2015 22:26:59 +0100 Subject: [windup-dev] Common parent for windup core and windup BOM? Message-ID: <54C802A3.1040500@redhat.com> Hi, to keep the Forge versions aligned, and generally let those two share some properties, plugin configs, versions etc., we could let them have a common parent. To prevent issues like we were solving now - with <version.forge> differing in those two, causing https://issues.jboss.org/browse/FORGE-2206 . Note that it would not mean moving everything under a new directory level - parent can be in a sibling directory. WDYT? Ondra From ozizka at redhat.com Tue Jan 27 20:18:22 2015 From: ozizka at redhat.com (Ondrej Zizka) Date: Wed, 28 Jan 2015 02:18:22 +0100 Subject: [windup-dev] Shortening of iteration Message-ID: <54C838DE.9090805@redhat.com> Hi all, could this .addRule() .when(Query.fromType(ArchiveModel.class)) .perform(Iteration.over(ArchiveModel.class) .perform(new AbstractIterationOperation<ArchiveModel>() { @Override public void perform(GraphRewrite event, EvaluationContext evCtx, ArchiveModel arch) { be just .addRule() .perform(new IterationOver(ArchiveModel.class) { @Override public void perform(GraphRewrite event, EvaluationContext evCtx, ArchiveModel arch) { ? If it can ( a. principially, b. nobody objects), I could try coding it. Thanks, Ondra From ozizka at redhat.com Tue Jan 27 22:15:12 2015 From: ozizka at redhat.com (Ondrej Zizka) Date: Wed, 28 Jan 2015 04:15:12 +0100 Subject: [windup-dev] IdentifyArchives / SkipArchives - state Message-ID: <54C85440.7020001@redhat.com> Hi, sorry to say I'm a bit late with this due to the Forge issue. Since I'll be on training tomorrow and this could block release (?), here's the status: What's freshly done: The data bundle - something that creates a fresh .zip artifact with the SHA1 -> GAV mapping from Maven Central during the build. What's missing: Loading this bundle into the class which does actual identification. Not tested in rules - only pieces. Both should be relatively easy to fix: Loading is probably matter of adding the right addon to classpath and feeding the resource to ArchiveGAVIdentifier.addMappingsFrom(is); in IdentifyArchivesLoadConfigRules. Tests are roughly written IIRC, only I got stuck with the mentioned issue and then was debugging them. Need to go sleep, the training starts in 4,5 hours. Ondra From ozizka at redhat.com Tue Jan 27 22:37:46 2015 From: ozizka at redhat.com (Ondrej Zizka) Date: Wed, 28 Jan 2015 04:37:46 +0100 Subject: [windup-dev] Zip archive as resource in Forge? Re: Discussion: Data files in maven repo In-Reply-To: <CAEp_U4HxPAUsjjLHMKWetKYGR_XHvLqg17uvsem6A21na0EHVQ@mail.gmail.com> References: <54C0CA27.4020206@redhat.com> <CAEp_U4HxPAUsjjLHMKWetKYGR_XHvLqg17uvsem6A21na0EHVQ@mail.gmail.com> Message-ID: <54C8598A.5050703@redhat.com> Reading this late; I already "externalized". There are 3 parts: 1st is the actual code to read nexus index 2nd executes it and creates a ZIP artifact 3rd is the ruleset which needs it. And here comes my question: Can I make that ZIP (in step 2) a Forge addon, and then put it as addon dep? Or is it somehow hardcoded to just handle jars. (didn't try) Ondra On 23.1.2015 19:25, Lincoln Baxter, III wrote: > 1) Eventually yes, but for now I think it's fine to tie this > information to our releases. Don't worry about this for now. > Businesses don't typically use the newest JARs in the legacy apps they > are trying to migrate ;) We'd probably even be fine with data from 3 > years ago. > > 2) Just put it in our main windup/windup repo for now, in the same > module as the addon you're building. > > 3) Bundle it in the same addon that provides the functionality for > now, it will be easier to include in our build. We can worry about > externalizing it later. This will also allow us to create a separate > distribution just in case people are worried about file size. (With > Maven JAR identification / Without Maven JAR identification) > > 4) Better to access on the classpath because you know its location > within the classloader. We can worry about externalizing it later. > > 45 MB is not terrible. Nice job. > > On Thu, Jan 22, 2015 at 5:00 AM, Ondrej Zizka <ozizka at redhat.com > <mailto:ozizka at redhat.com>> wrote: > > Hi, > > WRT WINDUP-459 <https://issues.jboss.org/browse/WINDUP-459> Rules > request: Identify archives by their hash: > > I guess this need (for bulk data from an external source) will > appear in more rulesets. > > We agreed that the best way to build, store and distribute the > offline data will be best through artifacts, resp. through a maven > repo. > > 1) Should it have independent release cycle? IMO it should. > 2) If so - which git repo to put it to? > 3) Can Forge/Furnace work well with ZIP artifacts? I.e, if there's > a <packaging>zip</packaging>, can that be an addon? > 4) If something is an addon, is it better to access it as a > resource on classpath, or as a zip file, after figuring out where > it is on local FS? > > FYI, currently I just create a zip assembly > windup-nexusindexreader-mappings-<V>.jar, next to > windup-nexusindexreader-<V>.jar > The artifact size is 45 MB. > > Regards, > Ondra > > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org <mailto:windup-dev at lists.jboss.org> > https://lists.jboss.org/mailman/listinfo/windup-dev > > > > > -- > Lincoln Baxter, III > http://ocpsoft.org > "Simpler is better." > > > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/windup-dev/attachments/20150128/8206a807/attachment.html From ozizka at redhat.com Tue Jan 27 22:40:23 2015 From: ozizka at redhat.com (Ondrej Zizka) Date: Wed, 28 Jan 2015 04:40:23 +0100 Subject: [windup-dev] WRT RulePhase changes In-Reply-To: <54C666B6.1030503@redhat.com> References: <54C6578A.8030808@redhat.com> <54C666B6.1030503@redhat.com> Message-ID: <54C85A27.3050801@redhat.com> Hi, it should be okay now. At least the tests for the 2 existing QS pass locally. XML version - perhaps? At least we would have something for DevConf :) Matej? Ondra On 26.1.2015 17:09, Sande Gilda wrote: > Hi Ondra, > > Thanks for doing this. Let me know when it's figured out and I'll > update the README files and the Wiki Documentation. > > I don't think we ever created the XML version of Jesse's quickstart > either. At that time, it wasn't possible. Do you plan to do that too? > > Thanks again, > Sande > > On 01/26/2015 10:04 AM, Ondrej Zizka wrote: >> Hi, >> >> I am updating the quickstarts to match the recent changes >> WINDUP-277 <https://issues.jboss.org/browse/WINDUP-277> Replace >> Migration "Phases" with dependencies >> <https://issues.jboss.org/browse/WINDUP-277> . >> >> The subclasses are small and just a few. >> Could we move them as inner classes of RulePhase? >> This would be beneficial: >> 1) One could write "RulePhase." to get a list of built-in phases >> instead of going to the documentation. >> 2) We would get rid of several small .java files >> >> Ondra >> >> >> _______________________________________________ >> windup-dev mailing list >> windup-dev at lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/windup-dev > > > > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/windup-dev/attachments/20150128/6e495c2a/attachment.html From ozizka at redhat.com Tue Jan 27 22:48:43 2015 From: ozizka at redhat.com (Ondrej Zizka) Date: Wed, 28 Jan 2015 04:48:43 +0100 Subject: [windup-dev] WRT RulePhase changes In-Reply-To: <CAEp_U4EfAMq6ezE94V1CUR0xUWr6U0fie6cDSWcWhSCWJ7vhHA@mail.gmail.com> References: <54C6578A.8030808@redhat.com> <CAEp_U4EfAMq6ezE94V1CUR0xUWr6U0fie6cDSWcWhSCWJ7vhHA@mail.gmail.com> Message-ID: <54C85C1B.9000202@redhat.com> If I may state my humble opinion: 1) users, even java-based ruleset authors, do not care l about how ugly our internal code is :) 1b) I like single concise class with few entries more than a pack of 5-line .java files. 2) RulePhase.<Ctrl+space> is much much quicker than looking up the information. The thing is, that our users do not even know that there's some superclass they can look for, they will just copy the quickstarts, and seeing RulePhase.Initial.class suggests very clearly that there are more to pick from in RulePhase. Whereas "InitialPhase.class" doesn't. 3) Keeping them in one file will make it easier for us to maintain - the order will be hinted by the order of appearance, and potential errors getExecuteAfter() will be more obvious. my2c. Ondra On 27.1.2015 04:39, Lincoln Baxter, III wrote: > Hey, good question, but no. You can always look in that package and > see all of the phases we have. Or use the IDE to quick-search for > types implementing RulePhase, etc. Not worth making ugly code for that > when the IDE or GitHub will tell you exactly the same information. > > On Mon, Jan 26, 2015 at 10:04 AM, Ondrej Zizka <ozizka at redhat.com > <mailto:ozizka at redhat.com>> wrote: > > Hi, > > I am updating the quickstarts to match the recent changes > WINDUP-277 <https://issues.jboss.org/browse/WINDUP-277> Replace > Migration "Phases" with dependencies > <https://issues.jboss.org/browse/WINDUP-277> . > > The subclasses are small and just a few. > Could we move them as inner classes of RulePhase? > This would be beneficial: > 1) One could write "RulePhase." to get a list of built-in phases > instead of going to the documentation. > 2) We would get rid of several small .java files > > Ondra > > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org <mailto:windup-dev at lists.jboss.org> > https://lists.jboss.org/mailman/listinfo/windup-dev > > > > > -- > Lincoln Baxter, III > http://ocpsoft.org > "Simpler is better." > > > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/windup-dev/attachments/20150128/baf3cdc9/attachment.html From ozizka at redhat.com Tue Jan 27 22:51:36 2015 From: ozizka at redhat.com (Ondrej Zizka) Date: Wed, 28 Jan 2015 04:51:36 +0100 Subject: [windup-dev] Zip archive as resource in Forge? Re: Discussion: Data files in maven repo In-Reply-To: <54C8598A.5050703@redhat.com> References: <54C0CA27.4020206@redhat.com> <CAEp_U4HxPAUsjjLHMKWetKYGR_XHvLqg17uvsem6A21na0EHVQ@mail.gmail.com> <54C8598A.5050703@redhat.com> Message-ID: <54C85CC8.7030903@redhat.com> PS: Still it can be easily put back using dependency:copy . On 28.1.2015 04:37, Ondrej Zizka wrote: > Reading this late; I already "externalized". > > There are 3 parts: > 1st is the actual code to read nexus index > 2nd executes it and creates a ZIP artifact > 3rd is the ruleset which needs it. > > And here comes my question: Can I make that ZIP (in step 2) a Forge > addon, and then put it as addon dep? Or is it somehow hardcoded to > just handle jars. (didn't try) > > Ondra > > > On 23.1.2015 19:25, Lincoln Baxter, III wrote: >> 1) Eventually yes, but for now I think it's fine to tie this >> information to our releases. Don't worry about this for now. >> Businesses don't typically use the newest JARs in the legacy apps >> they are trying to migrate ;) We'd probably even be fine with data >> from 3 years ago. >> >> 2) Just put it in our main windup/windup repo for now, in the same >> module as the addon you're building. >> >> 3) Bundle it in the same addon that provides the functionality for >> now, it will be easier to include in our build. We can worry about >> externalizing it later. This will also allow us to create a separate >> distribution just in case people are worried about file size. (With >> Maven JAR identification / Without Maven JAR identification) >> >> 4) Better to access on the classpath because you know its location >> within the classloader. We can worry about externalizing it later. >> >> 45 MB is not terrible. Nice job. >> >> On Thu, Jan 22, 2015 at 5:00 AM, Ondrej Zizka <ozizka at redhat.com >> <mailto:ozizka at redhat.com>> wrote: >> >> Hi, >> >> WRT WINDUP-459 <https://issues.jboss.org/browse/WINDUP-459> Rules >> request: Identify archives by their hash: >> >> I guess this need (for bulk data from an external source) will >> appear in more rulesets. >> >> We agreed that the best way to build, store and distribute the >> offline data will be best through artifacts, resp. through a >> maven repo. >> >> 1) Should it have independent release cycle? IMO it should. >> 2) If so - which git repo to put it to? >> 3) Can Forge/Furnace work well with ZIP artifacts? I.e, if >> there's a <packaging>zip</packaging>, can that be an addon? >> 4) If something is an addon, is it better to access it as a >> resource on classpath, or as a zip file, after figuring out where >> it is on local FS? >> >> FYI, currently I just create a zip assembly >> windup-nexusindexreader-mappings-<V>.jar, next to >> windup-nexusindexreader-<V>.jar >> The artifact size is 45 MB. >> >> Regards, >> Ondra >> >> _______________________________________________ >> windup-dev mailing list >> windup-dev at lists.jboss.org <mailto:windup-dev at lists.jboss.org> >> https://lists.jboss.org/mailman/listinfo/windup-dev >> >> >> >> >> -- >> Lincoln Baxter, III >> http://ocpsoft.org >> "Simpler is better." >> >> >> _______________________________________________ >> windup-dev mailing list >> windup-dev at lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/windup-dev > > > > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/windup-dev/attachments/20150128/01d2b948/attachment-0001.html From mbriskar at redhat.com Wed Jan 28 04:40:46 2015 From: mbriskar at redhat.com (Matej Briskar) Date: Wed, 28 Jan 2015 04:40:46 -0500 (EST) Subject: [windup-dev] WRT RulePhase changes In-Reply-To: <54C85A27.3050801@redhat.com> References: <54C6578A.8030808@redhat.com> <54C666B6.1030503@redhat.com> <54C85A27.3050801@redhat.com> Message-ID: <1904021833.1432376.1422438046541.JavaMail.zimbra@redhat.com> I confirm that having some of these quickstarts may be good for Devconf :) Matej ----- Original Message ----- From: "Ondrej Zizka" <ozizka at redhat.com> To: windup-dev at lists.jboss.org, "Matej Bri?k?r" <mbriskar at gmail.com>, "Sande Gilda" <sgilda at redhat.com> Sent: Wednesday, January 28, 2015 4:40:23 AM Subject: Re: [windup-dev] WRT RulePhase changes Hi, it should be okay now. At least the tests for the 2 existing QS pass locally. XML version - perhaps? At least we would have something for DevConf :) Matej? Ondra On 26.1.2015 17:09, Sande Gilda wrote: Hi Ondra, Thanks for doing this. Let me know when it's figured out and I'll update the README files and the Wiki Documentation. I don't think we ever created the XML version of Jesse's quickstart either. At that time, it wasn't possible. Do you plan to do that too? Thanks again, Sande On 01/26/2015 10:04 AM, Ondrej Zizka wrote: Hi, I am updating the quickstarts to match the recent changes WINDUP-277 Replace Migration "Phases" with dependencies . The subclasses are small and just a few. Could we move them as inner classes of RulePhase? This would be beneficial: 1) One could write "RulePhase." to get a list of built-in phases instead of going to the documentation. 2) We would get rid of several small .java files Ondra _______________________________________________ windup-dev mailing list windup-dev at lists.jboss.org https://lists.jboss.org/mailman/listinfo/windup-dev _______________________________________________ windup-dev mailing list windup-dev at lists.jboss.org https://lists.jboss.org/mailman/listinfo/windup-dev _______________________________________________ windup-dev mailing list windup-dev at lists.jboss.org https://lists.jboss.org/mailman/listinfo/windup-dev From ozizka at redhat.com Wed Jan 28 06:18:55 2015 From: ozizka at redhat.com (Ondrej Zizka) Date: Wed, 28 Jan 2015 12:18:55 +0100 Subject: [windup-dev] Status Message-ID: <54C8C59F.80201@redhat.com> I'm on a training today so here's my status if I don't make it to the meeting: #info I was working on the SkipArchives / IdentifyArchives ruleset, according to the plan in last status / meeting. #info Namely, I was working on the tests, on the data retrieval, on data bundle. Delayed a bit by BOM Forge version not updated along with Windup core. #info See the mail "[windup-dev] IdentifyArchives / SkipArchives - state" for details. #info Plan: Finish that ASAP. Regards, Ondra From jsightle at redhat.com Wed Jan 28 10:33:44 2015 From: jsightle at redhat.com (Jess Sightler) Date: Wed, 28 Jan 2015 10:33:44 -0500 Subject: [windup-dev] WRT RulePhase changes In-Reply-To: <54C85C1B.9000202@redhat.com> References: <54C6578A.8030808@redhat.com> <CAEp_U4EfAMq6ezE94V1CUR0xUWr6U0fie6cDSWcWhSCWJ7vhHA@mail.gmail.com> <54C85C1B.9000202@redhat.com> Message-ID: <54C90158.2010202@redhat.com> External addons may add their own phases as well. I don't think that it is feasible to keep more than the basic list in the RulePhase source itself, and putting them all in there may actually be misleading. I do think that we need to store a list of all phases and their default order of execution in our documentation, and provide an easy way to generate this doc. On 01/27/2015 10:48 PM, Ondrej Zizka wrote: > If I may state my humble opinion: > > 1) users, even java-based ruleset authors, do not care l about how > ugly our internal code is :) > 1b) I like single concise class with few entries more than a pack > of 5-line .java files. > > 2) RulePhase.<Ctrl+space> is much much quicker than looking up the > information. > The thing is, that our users do not even know that there's some > superclass they can look for, they will just copy the quickstarts, and > seeing > RulePhase.Initial.class suggests very clearly that there are more to > pick from in RulePhase. Whereas "InitialPhase.class" doesn't. > > 3) Keeping them in one file will make it easier for us to maintain - > the order will be hinted by the order of appearance, and potential > errors getExecuteAfter() will be more obvious. > > my2c. > Ondra > > > On 27.1.2015 04:39, Lincoln Baxter, III wrote: >> Hey, good question, but no. You can always look in that package and >> see all of the phases we have. Or use the IDE to quick-search for >> types implementing RulePhase, etc. Not worth making ugly code for >> that when the IDE or GitHub will tell you exactly the same information. >> >> On Mon, Jan 26, 2015 at 10:04 AM, Ondrej Zizka <ozizka at redhat.com >> <mailto:ozizka at redhat.com>> wrote: >> >> Hi, >> >> I am updating the quickstarts to match the recent changes >> WINDUP-277 <https://issues.jboss.org/browse/WINDUP-277> Replace >> Migration "Phases" with dependencies >> <https://issues.jboss.org/browse/WINDUP-277> . >> >> The subclasses are small and just a few. >> Could we move them as inner classes of RulePhase? >> This would be beneficial: >> 1) One could write "RulePhase." to get a list of built-in phases >> instead of going to the documentation. >> 2) We would get rid of several small .java files >> >> Ondra >> >> _______________________________________________ >> windup-dev mailing list >> windup-dev at lists.jboss.org <mailto:windup-dev at lists.jboss.org> >> https://lists.jboss.org/mailman/listinfo/windup-dev >> >> >> >> >> -- >> Lincoln Baxter, III >> http://ocpsoft.org >> "Simpler is better." >> >> >> _______________________________________________ >> windup-dev mailing list >> windup-dev at lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/windup-dev > > > > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev -- Calendar Free/Busy: https://www.google.com/calendar/embed?src=jsightle%40redhat.com&ctz=America/New_York -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/windup-dev/attachments/20150128/b70e6cf7/attachment.html From lincolnbaxter at gmail.com Wed Jan 28 11:44:10 2015 From: lincolnbaxter at gmail.com (Lincoln Baxter, III) Date: Wed, 28 Jan 2015 11:44:10 -0500 Subject: [windup-dev] Windup Meeting Minutes - 2015-01-28 Message-ID: <CAEp_U4FBHCPMBBz83hL_RsC1DO1TRNGn_ywtJjfsf0Fn1ziceg@mail.gmail.com> (If you are only looking for the release status update, here it is.) * GA Release Status (lincolnthree, 16:01:07) * Assuming we can get the skipjars functionality merged in today, we are on schedule for releasing GA on FRIDAY (lincolnthree, 16:06:04) Minutes: http://transcripts.jboss.org/meeting/irc.freenode.org/windup/2015/windup.2015-01-28-15.14.html Minutes (text): http://transcripts.jboss.org/meeting/irc.freenode.org/windup/2015/windup.2015-01-28-15.14.txt Log: http://transcripts.jboss.org/meeting/irc.freenode.org/windup/2015/windup.2015-01-28-15.14.log.html Meeting summary --------------- * Agenda (lincolnthree, 15:15:03) * Status Reports (lincolnthree, 15:15:37) * was working with Roman (our consultant) to create some new rules (all counter are about 14). One I was not able to deliver and one only partly, because we don't have functionality yet (mbriskar, 15:17:06) * cleaned and pushed WINDUP-435: Rexster tests (mbriskar, 15:17:32) * cleaned and pushed WINDUP-424 (mbriskar, 15:17:50) * Last week I worked on setting up more relationships with teams starting to use Windup, so hopefully we'll get some more feedback soon. (lincolnthree, 15:23:38) * I also worked on reviewing quite a few PRs, implemented WINDUP-484, and WINDUP-312 (lincolnthree, 15:25:34) * I'm working on our product integration plan, such as how other teams will be required to contribute rules for new product releases (lincolnthree, 15:26:13) * I'm also working on the GA release tasks, code cleanup, and making sure that our release is actually including the right stuff, and that what we include/exclude is properly "messaged" to people who are waiting on the release :) (lincolnthree, 15:26:58) * I have worked on WINDUP-164 (Query.fromType(...).excludingType(...)) (jsightler, 15:28:25) * Also, WINDUP-267 (Adding EJB lists, spring bean lists, and hibernate information to the reports) (jsightler, 15:28:50) * WINDUP-367 - FileContent searches (and support for this in our XML rules) (jsightler, 15:29:07) * Also, various bugfixes and working through some PRs and the transition to the new extensible RulePhase system (WINDUP-277) (jsightler, 15:29:55) * I am currently working on RulePhase documentation, and then I'll be working on testing (and any remaining issues) for the release (jsightler, 15:30:56) * (ozizka) I was working on the SkipArchives / IdentifyArchives ruleset, (jsightler, 15:37:50) * (ozizka) Namely, I was working on the tests, on the data retrieval, on data (jsightler, 15:37:50) * (ozizka) See the mail "[windup-dev] IdentifyArchives / SkipArchives - (jsightler, 15:37:51) * (ozizka) Plan: Finish that ASAP. (jsightler, 15:37:57) * (ozizka) I was working on the SkipArchives / IdentifyArchives ruleset, according to the plan in last status / meeting. (jsightler, 15:38:43) * (ozizka) Namely, I was working on the tests, on the data retrieval, on data bundle. Delayed a bit by BOM Forge version not updated along with Windup core. (jsightler, 15:38:43) * (ozizka) See the mail "[windup-dev] IdentifyArchives / SkipArchives - state" for details. (jsightler, 15:38:43) * (ozizka) Plan: Finish that ASAP. (jsightler, 15:38:43) * I have created 18 migration KBase articles here: https://access.redhat.com/search/browse/articles#?&col=portal_articles&language=All&portal_language=en&portal_tag=windup (sgilda, 15:43:31) * I've updated the spreadsheet with the Kbase article links: https://docs.google.com/spreadsheets/d/19xaibv1xZr1L3ss256A9ak08oqg-zFxuvzlmOHiMtHw/edit#gid=1133431410 (sgilda, 15:45:02) * Priorities (lincolnthree, 15:52:10) * Getting the GA release out (lincolnthree, 15:52:20) * Continuing to support windup users / etc (lincolnthree, 15:52:40) * GA Release Status (lincolnthree, 16:01:07) * Assuming we can get the skipjars functionality merged in today, we are on schedule for releasing GA on FRIDAY (lincolnthree, 16:06:04) -- Lincoln Baxter, III http://ocpsoft.org "Simpler is better." -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/windup-dev/attachments/20150128/54420d4b/attachment.html From lincolnbaxter at gmail.com Wed Jan 28 12:30:15 2015 From: lincolnbaxter at gmail.com (Lincoln Baxter, III) Date: Wed, 28 Jan 2015 12:30:15 -0500 Subject: [windup-dev] Shortening of iteration In-Reply-To: <54C838DE.9090805@redhat.com> References: <54C838DE.9090805@redhat.com> Message-ID: <CAEp_U4FithoA5k4ECxQRCbSX0XyQiOJ4p+xLmud-GH4pi37DjQ@mail.gmail.com> There's already no need to use Iteration.over() anymore. It's implicit if the operation passed in is an AbstractIterationOperation. We improved this a few months ago :) For example: https://github.com/windup/windup/blob/master/rules-java/src/main/java/org/jboss/windup/rules/apps/java/scan/provider/IndexClassFilesRuleProvider.java#L47 public Configuration getConfiguration(GraphContext context) { return ConfigurationBuilder.begin() .addRule() .when(Query.fromType(FileModel. class) .withProperty(FileModel.IS_DIRECTORY, false) .withProperty(FileModel. FILE_PATH, QueryPropertyComparisonType.REGEX, ".*\\.class") ) .perform( new AddClassFileMetadata() .and(Commit.every(10)) .and(IterationProgress. monitoring("Indexed class file: ", 1000)) ); } On Tue, Jan 27, 2015 at 8:18 PM, Ondrej Zizka <ozizka at redhat.com> wrote: > Hi all, > > could this > > .addRule() > .when(Query.fromType(ArchiveModel.class)) > .perform(Iteration.over(ArchiveModel.class) > .perform(new AbstractIterationOperation<ArchiveModel>() > { > @Override > public void perform(GraphRewrite event, > EvaluationContext evCtx, ArchiveModel arch) > { > > be just > > .addRule() > .perform(new IterationOver(ArchiveModel.class) { > @Override > public void perform(GraphRewrite event, > EvaluationContext evCtx, ArchiveModel arch) > { > > ? > If it can ( a. principially, b. nobody objects), I could try coding it. > > > Thanks, > Ondra > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev > -- Lincoln Baxter, III http://ocpsoft.org "Simpler is better." -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/windup-dev/attachments/20150128/095224de/attachment-0001.html From lincolnbaxter at gmail.com Wed Jan 28 12:32:48 2015 From: lincolnbaxter at gmail.com (Lincoln Baxter, III) Date: Wed, 28 Jan 2015 12:32:48 -0500 Subject: [windup-dev] Common parent for windup core and windup BOM? In-Reply-To: <54C802A3.1040500@redhat.com> References: <54C802A3.1040500@redhat.com> Message-ID: <CAEp_U4EGdsjbJXxnS=f=f9Nu5bDDOObC+aFA8p-tzg-LCkW1uQ@mail.gmail.com> No, but what we can do is remove the <version.forge> property in the BOM itself, and in the windup-parent POM, and instead specify the version on the command line using -Dversion.forge=2.13.X.Y On Tue, Jan 27, 2015 at 4:26 PM, Ondrej Zizka <ozizka at redhat.com> wrote: > Hi, > > to keep the Forge versions aligned, and generally let those two share > some properties, plugin configs, versions etc., > > we could let them have a common parent. To prevent issues like we were > solving now - with <version.forge> differing in those two, causing > https://issues.jboss.org/browse/FORGE-2206 . > > Note that it would not mean moving everything under a new directory > level - parent can be in a sibling directory. > > WDYT? > Ondra > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev > -- Lincoln Baxter, III http://ocpsoft.org "Simpler is better." -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/windup-dev/attachments/20150128/b7e1a5b2/attachment.html From lincolnbaxter at gmail.com Wed Jan 28 13:00:03 2015 From: lincolnbaxter at gmail.com (Lincoln Baxter, III) Date: Wed, 28 Jan 2015 13:00:03 -0500 Subject: [windup-dev] WRT RulePhase changes In-Reply-To: <54C85C1B.9000202@redhat.com> References: <54C6578A.8030808@redhat.com> <CAEp_U4EfAMq6ezE94V1CUR0xUWr6U0fie6cDSWcWhSCWJ7vhHA@mail.gmail.com> <54C85C1B.9000202@redhat.com> Message-ID: <CAEp_U4EQvjmqh2MUGL_mCTOprHiMsnNgvm1=WqZ7gPJ285cirA@mail.gmail.com> On Tue, Jan 27, 2015 at 10:48 PM, Ondrej Zizka <ozizka at redhat.com> wrote: > If I may state my humble opinion: > > 1) java-based ruleset authors do not care about how ugly our internal code > is :) > I beg to differ, and I feel strongly that as a high-end software company, we need to present a *very* professional image. Even if it's "just internal code." > 2) RulePhase.<Ctrl+space> is much much quicker than looking up the > information. > The thing is, that our users do not even know that there's some > superclass they can look for, they will just copy the quickstarts, and > seeing > <CTRL>-T > RulePhase.Initial.class suggests very clearly that there are more to pick > from in RulePhase. Whereas "InitialPhase.class" doesn't. > > 3) Keeping them in one file will make it easier for us to maintain > Again I beg to differ. > > > On 27.1.2015 04:39, Lincoln Baxter, III wrote: > > Hey, good question, but no. You can always look in that package and see > all of the phases we have. Or use the IDE to quick-search for types > implementing RulePhase, etc. Not worth making ugly code for that when the > IDE or GitHub will tell you exactly the same information. > > On Mon, Jan 26, 2015 at 10:04 AM, Ondrej Zizka <ozizka at redhat.com> wrote: > >> Hi, >> >> I am updating the quickstarts to match the recent changes >> WINDUP-277 <https://issues.jboss.org/browse/WINDUP-277> Replace >> Migration "Phases" with dependencies >> <https://issues.jboss.org/browse/WINDUP-277> . >> >> The subclasses are small and just a few. >> Could we move them as inner classes of RulePhase? >> This would be beneficial: >> 1) One could write "RulePhase." to get a list of built-in phases instead >> of going to the documentation. >> 2) We would get rid of several small .java files >> >> Ondra >> >> _______________________________________________ >> windup-dev mailing list >> windup-dev at lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/windup-dev >> > > > > -- > Lincoln Baxter, III > http://ocpsoft.org > "Simpler is better." > > > _______________________________________________ > windup-dev mailing listwindup-dev at lists.jboss.orghttps://lists.jboss.org/mailman/listinfo/windup-dev > > > > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev > -- Lincoln Baxter, III http://ocpsoft.org "Simpler is better." -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/windup-dev/attachments/20150128/4afc12c2/attachment.html From lincolnbaxter at gmail.com Wed Jan 28 13:00:13 2015 From: lincolnbaxter at gmail.com (Lincoln Baxter, III) Date: Wed, 28 Jan 2015 13:00:13 -0500 Subject: [windup-dev] Status In-Reply-To: <54C8C59F.80201@redhat.com> References: <54C8C59F.80201@redhat.com> Message-ID: <CAEp_U4EVcNdJQxF1-2V67skPL_K95agwgiqMV5xLaRK4Ra8UMA@mail.gmail.com> Thanks! On Wed, Jan 28, 2015 at 6:18 AM, Ondrej Zizka <ozizka at redhat.com> wrote: > I'm on a training today so here's my status if I don't make it to the > meeting: > > #info I was working on the SkipArchives / IdentifyArchives ruleset, > according to the plan in last status / meeting. > #info Namely, I was working on the tests, on the data retrieval, on data > bundle. Delayed a bit by BOM Forge version not updated along with Windup > core. > #info See the mail "[windup-dev] IdentifyArchives / SkipArchives - > state" for details. > #info Plan: Finish that ASAP. > > Regards, > Ondra > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev > -- Lincoln Baxter, III http://ocpsoft.org "Simpler is better." -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/windup-dev/attachments/20150128/70c6b770/attachment.html From lincolnbaxter at gmail.com Wed Jan 28 13:00:33 2015 From: lincolnbaxter at gmail.com (Lincoln Baxter, III) Date: Wed, 28 Jan 2015 13:00:33 -0500 Subject: [windup-dev] Status In-Reply-To: <CAEp_U4EVcNdJQxF1-2V67skPL_K95agwgiqMV5xLaRK4Ra8UMA@mail.gmail.com> References: <54C8C59F.80201@redhat.com> <CAEp_U4EVcNdJQxF1-2V67skPL_K95agwgiqMV5xLaRK4Ra8UMA@mail.gmail.com> Message-ID: <CAEp_U4EEV3seOsLFTxfYQ4Sfjuaq3jb6WdM_rvt7nP7ph=h6rQ@mail.gmail.com> PS. I plan to finish the skiparchives merge today if everything goes smoothly. On Wed, Jan 28, 2015 at 1:00 PM, Lincoln Baxter, III < lincolnbaxter at gmail.com> wrote: > Thanks! > > On Wed, Jan 28, 2015 at 6:18 AM, Ondrej Zizka <ozizka at redhat.com> wrote: > >> I'm on a training today so here's my status if I don't make it to the >> meeting: >> >> #info I was working on the SkipArchives / IdentifyArchives ruleset, >> according to the plan in last status / meeting. >> #info Namely, I was working on the tests, on the data retrieval, on data >> bundle. Delayed a bit by BOM Forge version not updated along with Windup >> core. >> #info See the mail "[windup-dev] IdentifyArchives / SkipArchives - >> state" for details. >> #info Plan: Finish that ASAP. >> >> Regards, >> Ondra >> _______________________________________________ >> windup-dev mailing list >> windup-dev at lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/windup-dev >> > > > > -- > Lincoln Baxter, III > http://ocpsoft.org > "Simpler is better." > -- Lincoln Baxter, III http://ocpsoft.org "Simpler is better." -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/windup-dev/attachments/20150128/3c37246c/attachment.html From lincolnbaxter at gmail.com Wed Jan 28 13:01:35 2015 From: lincolnbaxter at gmail.com (Lincoln Baxter, III) Date: Wed, 28 Jan 2015 13:01:35 -0500 Subject: [windup-dev] Zip archive as resource in Forge? Re: Discussion: Data files in maven repo In-Reply-To: <54C8598A.5050703@redhat.com> References: <54C0CA27.4020206@redhat.com> <CAEp_U4HxPAUsjjLHMKWetKYGR_XHvLqg17uvsem6A21na0EHVQ@mail.gmail.com> <54C8598A.5050703@redhat.com> Message-ID: <CAEp_U4EmGou22+0qLjegs5q1zSurqdaxfOtQUSdWCaoXmSOjUw@mail.gmail.com> 3) You can put the zip file in an Addon on the classpath to accomplish that goal. On Tue, Jan 27, 2015 at 10:37 PM, Ondrej Zizka <ozizka at redhat.com> wrote: > Reading this late; I already "externalized". > > There are 3 parts: > 1st is the actual code to read nexus index > 2nd executes it and creates a ZIP artifact > 3rd is the ruleset which needs it. > > And here comes my question: Can I make that ZIP (in step 2) a Forge addon, > and then put it as addon dep? Or is it somehow hardcoded to just handle > jars. (didn't try) > > Ondra > > > On 23.1.2015 19:25, Lincoln Baxter, III wrote: > > 1) Eventually yes, but for now I think it's fine to tie this information > to our releases. Don't worry about this for now. Businesses don't typically > use the newest JARs in the legacy apps they are trying to migrate ;) We'd > probably even be fine with data from 3 years ago. > > 2) Just put it in our main windup/windup repo for now, in the same module > as the addon you're building. > > 3) Bundle it in the same addon that provides the functionality for now, > it will be easier to include in our build. We can worry about externalizing > it later. This will also allow us to create a separate distribution just in > case people are worried about file size. (With Maven JAR identification / > Without Maven JAR identification) > > 4) Better to access on the classpath because you know its location > within the classloader. We can worry about externalizing it later. > > 45 MB is not terrible. Nice job. > > On Thu, Jan 22, 2015 at 5:00 AM, Ondrej Zizka <ozizka at redhat.com> wrote: > >> Hi, >> >> WRT WINDUP-459 <https://issues.jboss.org/browse/WINDUP-459> Rules >> request: Identify archives by their hash: >> >> I guess this need (for bulk data from an external source) will appear in >> more rulesets. >> >> We agreed that the best way to build, store and distribute the offline >> data will be best through artifacts, resp. through a maven repo. >> >> 1) Should it have independent release cycle? IMO it should. >> 2) If so - which git repo to put it to? >> 3) Can Forge/Furnace work well with ZIP artifacts? I.e, if there's a >> <packaging>zip</packaging>, can that be an addon? >> 4) If something is an addon, is it better to access it as a resource on >> classpath, or as a zip file, after figuring out where it is on local FS? >> >> FYI, currently I just create a zip assembly >> windup-nexusindexreader-mappings-<V>.jar, next to windup-nexusindexreader >> -<V>.jar >> The artifact size is 45 MB. >> >> Regards, >> Ondra >> >> _______________________________________________ >> windup-dev mailing list >> windup-dev at lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/windup-dev >> > > > > -- > Lincoln Baxter, III > http://ocpsoft.org > "Simpler is better." > > > _______________________________________________ > windup-dev mailing listwindup-dev at lists.jboss.orghttps://lists.jboss.org/mailman/listinfo/windup-dev > > > > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev > -- Lincoln Baxter, III http://ocpsoft.org "Simpler is better." -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/windup-dev/attachments/20150128/4571a4b1/attachment-0001.html From lincolnbaxter at gmail.com Wed Jan 28 13:02:29 2015 From: lincolnbaxter at gmail.com (Lincoln Baxter, III) Date: Wed, 28 Jan 2015 13:02:29 -0500 Subject: [windup-dev] IdentifyArchives / SkipArchives - state In-Reply-To: <54C85440.7020001@redhat.com> References: <54C85440.7020001@redhat.com> Message-ID: <CAEp_U4FiCLNTksC2aGprwJ5Sfrf92KG6at-yTxZsqxdCkf9C+Q@mail.gmail.com> Thanks for your hard work. Good luck with training. I'm going to try to finish this today. On Tue, Jan 27, 2015 at 10:15 PM, Ondrej Zizka <ozizka at redhat.com> wrote: > Hi, > > sorry to say I'm a bit late with this due to the Forge issue. > Since I'll be on training tomorrow and this could block release (?), > here's the status: > > What's freshly done: > The data bundle - something that creates a fresh .zip artifact with > the SHA1 -> GAV mapping from Maven Central during the build. > > What's missing: > Loading this bundle into the class which does actual identification. > Not tested in rules - only pieces. > > Both should be relatively easy to fix: > Loading is probably matter of adding the right addon to classpath > and feeding the resource to ArchiveGAVIdentifier.addMappingsFrom(is); in > IdentifyArchivesLoadConfigRules. > Tests are roughly written IIRC, only I got stuck with the mentioned > issue and then was debugging them. > > Need to go sleep, the training starts in 4,5 hours. > Ondra > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev > -- Lincoln Baxter, III http://ocpsoft.org "Simpler is better." -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/windup-dev/attachments/20150128/86feaf00/attachment.html From sgilda at redhat.com Wed Jan 28 13:04:31 2015 From: sgilda at redhat.com (Sande Gilda) Date: Wed, 28 Jan 2015 13:04:31 -0500 Subject: [windup-dev] WRT RulePhase changes In-Reply-To: <1904021833.1432376.1422438046541.JavaMail.zimbra@redhat.com> References: <54C6578A.8030808@redhat.com> <54C666B6.1030503@redhat.com> <54C85A27.3050801@redhat.com> <1904021833.1432376.1422438046541.JavaMail.zimbra@redhat.com> Message-ID: <54C924AF.1030008@redhat.com> At least one of the quickstarts does not work at this point. It's waiting on a merge. On 01/28/2015 04:40 AM, Matej Briskar wrote: > I confirm that having some of these quickstarts may be good for Devconf :) > > Matej > > ----- Original Message ----- > From: "Ondrej Zizka" <ozizka at redhat.com> > To: windup-dev at lists.jboss.org, "Matej Bri?k?r" <mbriskar at gmail.com>, "Sande Gilda" <sgilda at redhat.com> > Sent: Wednesday, January 28, 2015 4:40:23 AM > Subject: Re: [windup-dev] WRT RulePhase changes > > Hi, it should be okay now. At least the tests for the 2 existing QS pass locally. > > XML version - perhaps? At least we would have something for DevConf :) Matej? > > Ondra > > > > On 26.1.2015 17:09, Sande Gilda wrote: > > > Hi Ondra, > > Thanks for doing this. Let me know when it's figured out and I'll update the README files and the Wiki Documentation. > > I don't think we ever created the XML version of Jesse's quickstart either. At that time, it wasn't possible. Do you plan to do that too? > > Thanks again, > Sande > > On 01/26/2015 10:04 AM, Ondrej Zizka wrote: > > > Hi, > > I am updating the quickstarts to match the recent changes > WINDUP-277 Replace Migration "Phases" with dependencies . > > The subclasses are small and just a few. > Could we move them as inner classes of RulePhase? > This would be beneficial: > 1) One could write "RulePhase." to get a list of built-in phases instead of going to the documentation. > 2) We would get rid of several small .java files > > Ondra > > > _______________________________________________ > windup-dev mailing list windup-dev at lists.jboss.org https://lists.jboss.org/mailman/listinfo/windup-dev > > > > _______________________________________________ > windup-dev mailing list windup-dev at lists.jboss.org https://lists.jboss.org/mailman/listinfo/windup-dev > > > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev From jsightle at redhat.com Wed Jan 28 13:04:34 2015 From: jsightle at redhat.com (Jess Sightler) Date: Wed, 28 Jan 2015 13:04:34 -0500 Subject: [windup-dev] Common parent for windup core and windup BOM? In-Reply-To: <CAEp_U4EGdsjbJXxnS=f=f9Nu5bDDOObC+aFA8p-tzg-LCkW1uQ@mail.gmail.com> References: <54C802A3.1040500@redhat.com> <CAEp_U4EGdsjbJXxnS=f=f9Nu5bDDOObC+aFA8p-tzg-LCkW1uQ@mail.gmail.com> Message-ID: <54C924B2.8060303@redhat.com> That sounds worse than maintaining it in two places. On 01/28/2015 12:32 PM, Lincoln Baxter, III wrote: > No, but what we can do is remove the <version.forge> property in the > BOM itself, and in the windup-parent POM, and instead specify the > version on the command line using -Dversion.forge=2.13.X.Y > > On Tue, Jan 27, 2015 at 4:26 PM, Ondrej Zizka <ozizka at redhat.com > <mailto:ozizka at redhat.com>> wrote: > > Hi, > > to keep the Forge versions aligned, and generally let those two share > some properties, plugin configs, versions etc., > > we could let them have a common parent. To prevent issues like we were > solving now - with <version.forge> differing in those two, causing > https://issues.jboss.org/browse/FORGE-2206 . > > Note that it would not mean moving everything under a new directory > level - parent can be in a sibling directory. > > WDYT? > Ondra > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org <mailto:windup-dev at lists.jboss.org> > https://lists.jboss.org/mailman/listinfo/windup-dev > > > > > -- > Lincoln Baxter, III > http://ocpsoft.org > "Simpler is better." > > > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev -- Calendar Free/Busy: https://www.google.com/calendar/embed?src=jsightle%40redhat.com&ctz=America/New_York -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/windup-dev/attachments/20150128/4d74a18c/attachment.html From lincolnbaxter at gmail.com Wed Jan 28 13:05:55 2015 From: lincolnbaxter at gmail.com (Lincoln Baxter, III) Date: Wed, 28 Jan 2015 13:05:55 -0500 Subject: [windup-dev] WRT RulePhase changes In-Reply-To: <CAEp_U4EQvjmqh2MUGL_mCTOprHiMsnNgvm1=WqZ7gPJ285cirA@mail.gmail.com> References: <54C6578A.8030808@redhat.com> <CAEp_U4EfAMq6ezE94V1CUR0xUWr6U0fie6cDSWcWhSCWJ7vhHA@mail.gmail.com> <54C85C1B.9000202@redhat.com> <CAEp_U4EQvjmqh2MUGL_mCTOprHiMsnNgvm1=WqZ7gPJ285cirA@mail.gmail.com> Message-ID: <CAEp_U4GXKKkWuayRaPHnXDemEcPv6xjxQOPjzwD4rLvZGM63uA@mail.gmail.com> That said, you are right that as far as end users are concerned, having "perfect" code is not a requirement as long as it works, but I refuse to play the "deferred maintainance" / "code debt" game. On Wed, Jan 28, 2015 at 1:00 PM, Lincoln Baxter, III < lincolnbaxter at gmail.com> wrote: > On Tue, Jan 27, 2015 at 10:48 PM, Ondrej Zizka <ozizka at redhat.com> wrote: > >> If I may state my humble opinion: >> >> 1) java-based ruleset authors do not care about how ugly our internal >> code is :) >> > > I beg to differ, and I feel strongly that as a high-end software company, > we need to present a *very* professional image. Even if it's "just internal > code." > > >> 2) RulePhase.<Ctrl+space> is much much quicker than looking up the >> information. >> The thing is, that our users do not even know that there's some >> superclass they can look for, they will just copy the quickstarts, and >> seeing >> > > <CTRL>-T > > >> RulePhase.Initial.class suggests very clearly that there are more to pick >> from in RulePhase. Whereas "InitialPhase.class" doesn't. >> >> 3) Keeping them in one file will make it easier for us to maintain >> > > Again I beg to differ. > > >> >> >> On 27.1.2015 04:39, Lincoln Baxter, III wrote: >> >> Hey, good question, but no. You can always look in that package and see >> all of the phases we have. Or use the IDE to quick-search for types >> implementing RulePhase, etc. Not worth making ugly code for that when the >> IDE or GitHub will tell you exactly the same information. >> >> On Mon, Jan 26, 2015 at 10:04 AM, Ondrej Zizka <ozizka at redhat.com> wrote: >> >>> Hi, >>> >>> I am updating the quickstarts to match the recent changes >>> WINDUP-277 <https://issues.jboss.org/browse/WINDUP-277> Replace >>> Migration "Phases" with dependencies >>> <https://issues.jboss.org/browse/WINDUP-277> . >>> >>> The subclasses are small and just a few. >>> Could we move them as inner classes of RulePhase? >>> This would be beneficial: >>> 1) One could write "RulePhase." to get a list of built-in phases instead >>> of going to the documentation. >>> 2) We would get rid of several small .java files >>> >>> Ondra >>> >>> _______________________________________________ >>> windup-dev mailing list >>> windup-dev at lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/windup-dev >>> >> >> >> >> -- >> Lincoln Baxter, III >> http://ocpsoft.org >> "Simpler is better." >> >> >> _______________________________________________ >> windup-dev mailing listwindup-dev at lists.jboss.orghttps://lists.jboss.org/mailman/listinfo/windup-dev >> >> >> >> _______________________________________________ >> windup-dev mailing list >> windup-dev at lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/windup-dev >> > > > > -- > Lincoln Baxter, III > http://ocpsoft.org > "Simpler is better." > -- Lincoln Baxter, III http://ocpsoft.org "Simpler is better." -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/windup-dev/attachments/20150128/d15ed056/attachment.html From lincolnbaxter at gmail.com Wed Jan 28 13:06:09 2015 From: lincolnbaxter at gmail.com (Lincoln Baxter, III) Date: Wed, 28 Jan 2015 13:06:09 -0500 Subject: [windup-dev] WRT RulePhase changes In-Reply-To: <54C924AF.1030008@redhat.com> References: <54C6578A.8030808@redhat.com> <54C666B6.1030503@redhat.com> <54C85A27.3050801@redhat.com> <1904021833.1432376.1422438046541.JavaMail.zimbra@redhat.com> <54C924AF.1030008@redhat.com> Message-ID: <CAEp_U4F4_aZ4SmCd-Z++zkQa3KDBW_mE2dvuFow1zSWcYkj35Q@mail.gmail.com> Yep. Working on that now. On Wed, Jan 28, 2015 at 1:04 PM, Sande Gilda <sgilda at redhat.com> wrote: > At least one of the quickstarts does not work at this point. It's > waiting on a merge. > > On 01/28/2015 04:40 AM, Matej Briskar wrote: > > I confirm that having some of these quickstarts may be good for Devconf > :) > > > > Matej > > > > ----- Original Message ----- > > From: "Ondrej Zizka" <ozizka at redhat.com> > > To: windup-dev at lists.jboss.org, "Matej Bri?k?r" <mbriskar at gmail.com>, > "Sande Gilda" <sgilda at redhat.com> > > Sent: Wednesday, January 28, 2015 4:40:23 AM > > Subject: Re: [windup-dev] WRT RulePhase changes > > > > Hi, it should be okay now. At least the tests for the 2 existing QS pass > locally. > > > > XML version - perhaps? At least we would have something for DevConf :) > Matej? > > > > Ondra > > > > > > > > On 26.1.2015 17:09, Sande Gilda wrote: > > > > > > Hi Ondra, > > > > Thanks for doing this. Let me know when it's figured out and I'll update > the README files and the Wiki Documentation. > > > > I don't think we ever created the XML version of Jesse's quickstart > either. At that time, it wasn't possible. Do you plan to do that too? > > > > Thanks again, > > Sande > > > > On 01/26/2015 10:04 AM, Ondrej Zizka wrote: > > > > > > Hi, > > > > I am updating the quickstarts to match the recent changes > > WINDUP-277 Replace Migration "Phases" with dependencies . > > > > The subclasses are small and just a few. > > Could we move them as inner classes of RulePhase? > > This would be beneficial: > > 1) One could write "RulePhase." to get a list of built-in phases instead > of going to the documentation. > > 2) We would get rid of several small .java files > > > > Ondra > > > > > > _______________________________________________ > > windup-dev mailing list windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev > > > > > > > > _______________________________________________ > > windup-dev mailing list windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev > > > > > > _______________________________________________ > > windup-dev mailing list > > windup-dev at lists.jboss.org > > https://lists.jboss.org/mailman/listinfo/windup-dev > > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev > -- Lincoln Baxter, III http://ocpsoft.org "Simpler is better." -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/windup-dev/attachments/20150128/87133581/attachment-0001.html From lincolnbaxter at gmail.com Wed Jan 28 13:25:26 2015 From: lincolnbaxter at gmail.com (Lincoln Baxter, III) Date: Wed, 28 Jan 2015 13:25:26 -0500 Subject: [windup-dev] Common parent for windup core and windup BOM? In-Reply-To: <54C924B2.8060303@redhat.com> References: <54C802A3.1040500@redhat.com> <CAEp_U4EGdsjbJXxnS=f=f9Nu5bDDOObC+aFA8p-tzg-LCkW1uQ@mail.gmail.com> <54C924B2.8060303@redhat.com> Message-ID: <CAEp_U4FDXkFPFShVRD0fwWavD8DjdFo0ecTeZZg-aWAHu_ScoQ@mail.gmail.com> Ah woops. I was confused - I thought that's how we did it in Forge, but we don't - had a crazy moment there. A more likely solution would be to import the BOM into the Windup-parent POM. Not the other way around. On Wed, Jan 28, 2015 at 1:04 PM, Jess Sightler <jsightle at redhat.com> wrote: > That sounds worse than maintaining it in two places. > > > On 01/28/2015 12:32 PM, Lincoln Baxter, III wrote: > > No, but what we can do is remove the <version.forge> property in the BOM > itself, and in the windup-parent POM, and instead specify the version on > the command line using -Dversion.forge=2.13.X.Y > > On Tue, Jan 27, 2015 at 4:26 PM, Ondrej Zizka <ozizka at redhat.com> wrote: > >> Hi, >> >> to keep the Forge versions aligned, and generally let those two share >> some properties, plugin configs, versions etc., >> >> we could let them have a common parent. To prevent issues like we were >> solving now - with <version.forge> differing in those two, causing >> https://issues.jboss.org/browse/FORGE-2206 . >> >> Note that it would not mean moving everything under a new directory >> level - parent can be in a sibling directory. >> >> WDYT? >> Ondra >> _______________________________________________ >> windup-dev mailing list >> windup-dev at lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/windup-dev >> > > > > -- > Lincoln Baxter, III > http://ocpsoft.org > "Simpler is better." > > > _______________________________________________ > windup-dev mailing listwindup-dev at lists.jboss.orghttps://lists.jboss.org/mailman/listinfo/windup-dev > > > -- > Calendar Free/Busy: https://www.google.com/calendar/embed?src=jsightle%40redhat.com&ctz=America/New_York > > > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev > -- Lincoln Baxter, III http://ocpsoft.org "Simpler is better." -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/windup-dev/attachments/20150128/750b7013/attachment.html From jsightle at redhat.com Wed Jan 28 14:03:12 2015 From: jsightle at redhat.com (Jess Sightler) Date: Wed, 28 Jan 2015 14:03:12 -0500 Subject: [windup-dev] Common parent for windup core and windup BOM? In-Reply-To: <CAEp_U4FDXkFPFShVRD0fwWavD8DjdFo0ecTeZZg-aWAHu_ScoQ@mail.gmail.com> References: <54C802A3.1040500@redhat.com> <CAEp_U4EGdsjbJXxnS=f=f9Nu5bDDOObC+aFA8p-tzg-LCkW1uQ@mail.gmail.com> <54C924B2.8060303@redhat.com> <CAEp_U4FDXkFPFShVRD0fwWavD8DjdFo0ecTeZZg-aWAHu_ScoQ@mail.gmail.com> Message-ID: <54C93270.4050202@redhat.com> Ah, that sounds like a good idea. I'm not sure why we didn't do it earlier. :) On 01/28/2015 01:25 PM, Lincoln Baxter, III wrote: > Ah woops. I was confused - I thought that's how we did it in Forge, > but we don't - had a crazy moment there. A more likely solution would > be to import the BOM into the Windup-parent POM. Not the other way around. > > On Wed, Jan 28, 2015 at 1:04 PM, Jess Sightler <jsightle at redhat.com > <mailto:jsightle at redhat.com>> wrote: > > That sounds worse than maintaining it in two places. > > > On 01/28/2015 12:32 PM, Lincoln Baxter, III wrote: >> No, but what we can do is remove the <version.forge> property in >> the BOM itself, and in the windup-parent POM, and instead specify >> the version on the command line using -Dversion.forge=2.13.X.Y >> >> On Tue, Jan 27, 2015 at 4:26 PM, Ondrej Zizka <ozizka at redhat.com >> <mailto:ozizka at redhat.com>> wrote: >> >> Hi, >> >> to keep the Forge versions aligned, and generally let those >> two share >> some properties, plugin configs, versions etc., >> >> we could let them have a common parent. To prevent issues >> like we were >> solving now - with <version.forge> differing in those two, >> causing >> https://issues.jboss.org/browse/FORGE-2206 . >> >> Note that it would not mean moving everything under a new >> directory >> level - parent can be in a sibling directory. >> >> WDYT? >> Ondra >> _______________________________________________ >> windup-dev mailing list >> windup-dev at lists.jboss.org <mailto:windup-dev at lists.jboss.org> >> https://lists.jboss.org/mailman/listinfo/windup-dev >> >> >> >> >> -- >> Lincoln Baxter, III >> http://ocpsoft.org >> "Simpler is better." >> >> >> _______________________________________________ >> windup-dev mailing list >> windup-dev at lists.jboss.org <mailto:windup-dev at lists.jboss.org> >> https://lists.jboss.org/mailman/listinfo/windup-dev > > -- > Calendar Free/Busy:https://www.google.com/calendar/embed?src=jsightle%40redhat.com&ctz=America/New_York > > > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org <mailto:windup-dev at lists.jboss.org> > https://lists.jboss.org/mailman/listinfo/windup-dev > > > > > -- > Lincoln Baxter, III > http://ocpsoft.org > "Simpler is better." > > > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev -- Calendar Free/Busy: https://www.google.com/calendar/embed?src=jsightle%40redhat.com&ctz=America/New_York -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/windup-dev/attachments/20150128/b6141617/attachment.html From zizka at seznam.cz Thu Jan 29 09:07:24 2015 From: zizka at seznam.cz (=?UTF-8?B?IkluZy4gT25kxZllaiDFvWnFvmthIg==?=) Date: Thu, 29 Jan 2015 15:07:24 +0100 Subject: [windup-dev] Phases, after, before Message-ID: <54CA3E9C.2000800@seznam.cz> Hi all, see the code below. Originally I thought that getPhase() was removed entirely. Now I see that we have all of getExecuteAfter(), getExecuteBefore() and getPhase(). I suggest that we do NOT set the default phase MigrationRules in case both getExecuteAfter() and getExecuteBefore() are overriden (return something). That will allow users to omit getPhase(). See the code and exception below for motivation. WDYT? =============================== public class SkipArchivesRules extends WindupRuleProvider { @Override public List<Class<? extends WindupRuleProvider>> getExecuteAfter() { return asClassList(IdentifyArchivesRules.class, SkipArchivesLoadConfigRules.class); } @Override public List<Class<? extends WindupRuleProvider>> getExecuteBefore() { return asClassList(DecompileArchivesRuleProvider.class); } java.lang.RuntimeException: Dependency cycles detected: Found dependency cycle involving: _DEFAULT_.SkipArchivesRules Subcycle: _DEFAULT_.SkipArchivesRules Subcycle: org.jboss.windup.rules.apps:rules-java.DecompileArchivesRuleProvider Subcycle: org.jboss.windup.quickstarts:windup-skiparchives.IdentifyArchivesRules Subcycle: InitialAnalysis Subcycle: org.jboss.windup.quickstarts:windup-skiparchives.SkipArchivesLoadConfigRules Subcycle: org.jboss.windup.quickstarts:windup-skiparchives.SkipArchivesRules Subcycle: MigrationRules Subcycle: org.jboss.windup.rules.apps:rules-java.AnalyzeJavaFilesRuleProvider From ozizka at redhat.com Thu Jan 29 09:08:35 2015 From: ozizka at redhat.com (Ondrej Zizka) Date: Thu, 29 Jan 2015 15:08:35 +0100 Subject: [windup-dev] Phases, after, before In-Reply-To: <54CA3E9C.2000800@seznam.cz> References: <54CA3E9C.2000800@seznam.cz> Message-ID: <54CA3EE3.7090409@redhat.com> (Re-sending from my RH account, pls reply to this, thx) On 29.1.2015 15:07, "Ing. Ond?ej ?i?ka" wrote: > Hi all, > > see the code below. > > Originally I thought that getPhase() was removed entirely. > Now I see that we have all of getExecuteAfter(), getExecuteBefore() and > getPhase(). > > I suggest that we do NOT set the default phase MigrationRules in case > both getExecuteAfter() and getExecuteBefore() are overriden (return > something). > That will allow users to omit getPhase(). > See the code and exception below for motivation. > > WDYT? > > =============================== > public class SkipArchivesRules extends WindupRuleProvider > { > @Override > public List<Class<? extends WindupRuleProvider>> getExecuteAfter() > { > return asClassList(IdentifyArchivesRules.class, > SkipArchivesLoadConfigRules.class); > } > > @Override > public List<Class<? extends WindupRuleProvider>> getExecuteBefore() > { > return asClassList(DecompileArchivesRuleProvider.class); > } > > java.lang.RuntimeException: Dependency cycles detected: Found dependency > cycle involving: _DEFAULT_.SkipArchivesRules > Subcycle: _DEFAULT_.SkipArchivesRules > Subcycle: > org.jboss.windup.rules.apps:rules-java.DecompileArchivesRuleProvider > Subcycle: > org.jboss.windup.quickstarts:windup-skiparchives.IdentifyArchivesRules > Subcycle: InitialAnalysis > Subcycle: > org.jboss.windup.quickstarts:windup-skiparchives.SkipArchivesLoadConfigRules > Subcycle: > org.jboss.windup.quickstarts:windup-skiparchives.SkipArchivesRules > Subcycle: MigrationRules > Subcycle: > org.jboss.windup.rules.apps:rules-java.AnalyzeJavaFilesRuleProvider > > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev From ozizka at redhat.com Thu Jan 29 09:09:55 2015 From: ozizka at redhat.com (Ondrej Zizka) Date: Thu, 29 Jan 2015 15:09:55 +0100 Subject: [windup-dev] Common parent for windup core and windup BOM? In-Reply-To: <54C93270.4050202@redhat.com> References: <54C802A3.1040500@redhat.com> <CAEp_U4EGdsjbJXxnS=f=f9Nu5bDDOObC+aFA8p-tzg-LCkW1uQ@mail.gmail.com> <54C924B2.8060303@redhat.com> <CAEp_U4FDXkFPFShVRD0fwWavD8DjdFo0ecTeZZg-aWAHu_ScoQ@mail.gmail.com> <54C93270.4050202@redhat.com> Message-ID: <54CA3F33.9010404@redhat.com> +1, hopefully no maven bug will pop up :) On 28.1.2015 20:03, Jess Sightler wrote: > Ah, that sounds like a good idea. I'm not sure why we didn't do it > earlier. :) > > On 01/28/2015 01:25 PM, Lincoln Baxter, III wrote: >> Ah woops. I was confused - I thought that's how we did it in Forge, >> but we don't - had a crazy moment there. A more likely solution would >> be to import the BOM into the Windup-parent POM. Not the other way >> around. >> >> On Wed, Jan 28, 2015 at 1:04 PM, Jess Sightler <jsightle at redhat.com >> <mailto:jsightle at redhat.com>> wrote: >> >> That sounds worse than maintaining it in two places. >> >> >> On 01/28/2015 12:32 PM, Lincoln Baxter, III wrote: >>> No, but what we can do is remove the <version.forge> property in >>> the BOM itself, and in the windup-parent POM, and instead >>> specify the version on the command line using >>> -Dversion.forge=2.13.X.Y >>> >>> On Tue, Jan 27, 2015 at 4:26 PM, Ondrej Zizka <ozizka at redhat.com >>> <mailto:ozizka at redhat.com>> wrote: >>> >>> Hi, >>> >>> to keep the Forge versions aligned, and generally let those >>> two share >>> some properties, plugin configs, versions etc., >>> >>> we could let them have a common parent. To prevent issues >>> like we were >>> solving now - with <version.forge> differing in those two, >>> causing >>> https://issues.jboss.org/browse/FORGE-2206 . >>> >>> Note that it would not mean moving everything under a new >>> directory >>> level - parent can be in a sibling directory. >>> >>> WDYT? >>> Ondra >>> _______________________________________________ >>> windup-dev mailing list >>> windup-dev at lists.jboss.org <mailto:windup-dev at lists.jboss.org> >>> https://lists.jboss.org/mailman/listinfo/windup-dev >>> >>> >>> >>> >>> -- >>> Lincoln Baxter, III >>> http://ocpsoft.org >>> "Simpler is better." >>> >>> >>> _______________________________________________ >>> windup-dev mailing list >>> windup-dev at lists.jboss.org <mailto:windup-dev at lists.jboss.org> >>> https://lists.jboss.org/mailman/listinfo/windup-dev >> >> -- >> Calendar Free/Busy:https://www.google.com/calendar/embed?src=jsightle%40redhat.com&ctz=America/New_York >> >> >> _______________________________________________ >> windup-dev mailing list >> windup-dev at lists.jboss.org <mailto:windup-dev at lists.jboss.org> >> https://lists.jboss.org/mailman/listinfo/windup-dev >> >> >> >> >> -- >> Lincoln Baxter, III >> http://ocpsoft.org >> "Simpler is better." >> >> >> _______________________________________________ >> windup-dev mailing list >> windup-dev at lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/windup-dev > > -- > Calendar Free/Busy:https://www.google.com/calendar/embed?src=jsightle%40redhat.com&ctz=America/New_York > > > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/windup-dev/attachments/20150129/6e46d998/attachment-0001.html From ozizka at redhat.com Thu Jan 29 09:15:41 2015 From: ozizka at redhat.com (Ondrej Zizka) Date: Thu, 29 Jan 2015 15:15:41 +0100 Subject: [windup-dev] Phases, after, before In-Reply-To: <54CA3EE3.7090409@redhat.com> References: <54CA3E9C.2000800@seznam.cz> <54CA3EE3.7090409@redhat.com> Message-ID: <54CA408D.7050207@redhat.com> In other words: It is a bit useless to figure out what phase it is in case you know both bounds, and find the right phase to fit it in. Sometimes the bounds span over multiple phases. Even if you do not have the upper (execute before) bound, we could just set ReportingPhase as the upper bound automatically. IIUC, the phases now can be used in getBefore() and getAfter(). Correct me please if I get that incorrectly. Thanks, Ondra On 29.1.2015 15:08, Ondrej Zizka wrote: > (Re-sending from my RH account, pls reply to this, thx) > > > On 29.1.2015 15:07, "Ing. Ond?ej ?i?ka" wrote: >> Hi all, >> >> see the code below. >> >> Originally I thought that getPhase() was removed entirely. >> Now I see that we have all of getExecuteAfter(), getExecuteBefore() and >> getPhase(). >> >> I suggest that we do NOT set the default phase MigrationRules in case >> both getExecuteAfter() and getExecuteBefore() are overriden (return >> something). >> That will allow users to omit getPhase(). >> See the code and exception below for motivation. >> >> WDYT? >> >> =============================== >> public class SkipArchivesRules extends WindupRuleProvider >> { >> @Override >> public List<Class<? extends WindupRuleProvider>> getExecuteAfter() >> { >> return asClassList(IdentifyArchivesRules.class, >> SkipArchivesLoadConfigRules.class); >> } >> >> @Override >> public List<Class<? extends WindupRuleProvider>> getExecuteBefore() >> { >> return asClassList(DecompileArchivesRuleProvider.class); >> } >> >> java.lang.RuntimeException: Dependency cycles detected: Found dependency >> cycle involving: _DEFAULT_.SkipArchivesRules >> Subcycle: _DEFAULT_.SkipArchivesRules >> Subcycle: >> org.jboss.windup.rules.apps:rules-java.DecompileArchivesRuleProvider >> Subcycle: >> org.jboss.windup.quickstarts:windup-skiparchives.IdentifyArchivesRules >> Subcycle: InitialAnalysis >> Subcycle: >> org.jboss.windup.quickstarts:windup-skiparchives.SkipArchivesLoadConfigRules >> Subcycle: >> org.jboss.windup.quickstarts:windup-skiparchives.SkipArchivesRules >> Subcycle: MigrationRules >> Subcycle: >> org.jboss.windup.rules.apps:rules-java.AnalyzeJavaFilesRuleProvider >> >> _______________________________________________ >> windup-dev mailing list >> windup-dev at lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/windup-dev > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev From ozizka at redhat.com Thu Jan 29 09:18:49 2015 From: ozizka at redhat.com (Ondrej Zizka) Date: Thu, 29 Jan 2015 15:18:49 +0100 Subject: [windup-dev] IdentifyArchives / SkipArchives - state In-Reply-To: <CAEp_U4FiCLNTksC2aGprwJ5Sfrf92KG6at-yTxZsqxdCkf9C+Q@mail.gmail.com> References: <54C85440.7020001@redhat.com> <CAEp_U4FiCLNTksC2aGprwJ5Sfrf92KG6at-yTxZsqxdCkf9C+Q@mail.gmail.com> Message-ID: <54CA4149.1050107@redhat.com> Hi Lincoln, I have few more changes, could you please create a PR into windup-quickstarts and I will then merge and create PR into windup? Thanks, Ondra On 28.1.2015 19:02, Lincoln Baxter, III wrote: > Thanks for your hard work. Good luck with training. I'm going to try > to finish this today. > > On Tue, Jan 27, 2015 at 10:15 PM, Ondrej Zizka <ozizka at redhat.com > <mailto:ozizka at redhat.com>> wrote: > > Hi, > > sorry to say I'm a bit late with this due to the Forge issue. > Since I'll be on training tomorrow and this could block release (?), > here's the status: > > What's freshly done: > The data bundle - something that creates a fresh .zip > artifact with > the SHA1 -> GAV mapping from Maven Central during the build. > > What's missing: > Loading this bundle into the class which does actual > identification. > Not tested in rules - only pieces. > > Both should be relatively easy to fix: > Loading is probably matter of adding the right addon to classpath > and feeding the resource to > ArchiveGAVIdentifier.addMappingsFrom(is); in > IdentifyArchivesLoadConfigRules. > Tests are roughly written IIRC, only I got stuck with the > mentioned > issue and then was debugging them. > > Need to go sleep, the training starts in 4,5 hours. > Ondra > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org <mailto:windup-dev at lists.jboss.org> > https://lists.jboss.org/mailman/listinfo/windup-dev > > > > > -- > Lincoln Baxter, III > http://ocpsoft.org > "Simpler is better." > > > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/windup-dev/attachments/20150129/28a7371c/attachment.html From ozizka at redhat.com Thu Jan 29 10:08:31 2015 From: ozizka at redhat.com (Ondrej Zizka) Date: Thu, 29 Jan 2015 16:08:31 +0100 Subject: [windup-dev] Phases, after, before In-Reply-To: <54CA408D.7050207@redhat.com> References: <54CA3E9C.2000800@seznam.cz> <54CA3EE3.7090409@redhat.com> <54CA408D.7050207@redhat.com> Message-ID: <54CA4CEF.3060406@redhat.com> Notes: 1) Phase classes could perhaps end with ...Phase 2) Phases should be printed, sorted, before all rules are printed, because if a cycle or rule deps error is detected, this message is not printed and user doesn't have a hit on what's the right phase to put the rule to. 3) I've updated https://github.com/windup/windup/wiki/Rules-Rule-Execution-Lifecycle with the list of phases, as a temporary info. Ondra On 29.1.2015 15:15, Ondrej Zizka wrote: > In other words: > > It is a bit useless to figure out what phase it is in case you know both > bounds, and find the right phase to fit it in. > Sometimes the bounds span over multiple phases. > > Even if you do not have the upper (execute before) bound, we could just > set ReportingPhase as the upper bound automatically. > > IIUC, the phases now can be used in getBefore() and getAfter(). > Correct me please if I get that incorrectly. > > Thanks, > Ondra > > > On 29.1.2015 15:08, Ondrej Zizka wrote: >> (Re-sending from my RH account, pls reply to this, thx) >> >> >> On 29.1.2015 15:07, "Ing. Ond?ej ?i?ka" wrote: >>> Hi all, >>> >>> see the code below. >>> >>> Originally I thought that getPhase() was removed entirely. >>> Now I see that we have all of getExecuteAfter(), getExecuteBefore() and >>> getPhase(). >>> >>> I suggest that we do NOT set the default phase MigrationRules in case >>> both getExecuteAfter() and getExecuteBefore() are overriden (return >>> something). >>> That will allow users to omit getPhase(). >>> See the code and exception below for motivation. >>> >>> WDYT? >>> >>> =============================== >>> public class SkipArchivesRules extends WindupRuleProvider >>> { >>> @Override >>> public List<Class<? extends WindupRuleProvider>> getExecuteAfter() >>> { >>> return asClassList(IdentifyArchivesRules.class, >>> SkipArchivesLoadConfigRules.class); >>> } >>> >>> @Override >>> public List<Class<? extends WindupRuleProvider>> getExecuteBefore() >>> { >>> return asClassList(DecompileArchivesRuleProvider.class); >>> } >>> >>> java.lang.RuntimeException: Dependency cycles detected: Found dependency >>> cycle involving: _DEFAULT_.SkipArchivesRules >>> Subcycle: _DEFAULT_.SkipArchivesRules >>> Subcycle: >>> org.jboss.windup.rules.apps:rules-java.DecompileArchivesRuleProvider >>> Subcycle: >>> org.jboss.windup.quickstarts:windup-skiparchives.IdentifyArchivesRules >>> Subcycle: InitialAnalysis >>> Subcycle: >>> org.jboss.windup.quickstarts:windup-skiparchives.SkipArchivesLoadConfigRules >>> Subcycle: >>> org.jboss.windup.quickstarts:windup-skiparchives.SkipArchivesRules >>> Subcycle: MigrationRules >>> Subcycle: >>> org.jboss.windup.rules.apps:rules-java.AnalyzeJavaFilesRuleProvider >>> >>> _______________________________________________ >>> windup-dev mailing list >>> windup-dev at lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/windup-dev >> _______________________________________________ >> windup-dev mailing list >> windup-dev at lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/windup-dev > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev From ozizka at redhat.com Thu Jan 29 10:11:01 2015 From: ozizka at redhat.com (Ondrej Zizka) Date: Thu, 29 Jan 2015 16:11:01 +0100 Subject: [windup-dev] Phases, after, before In-Reply-To: <54CA4CEF.3060406@redhat.com> References: <54CA3E9C.2000800@seznam.cz> <54CA3EE3.7090409@redhat.com> <54CA408D.7050207@redhat.com> <54CA4CEF.3060406@redhat.com> Message-ID: <54CA4D85.6070500@redhat.com> On 29.1.2015 16:08, Ondrej Zizka wrote: > Notes: > > 1) Phase classes could perhaps end with ...Phase > 2) Phases should be printed, sorted, before all rules are printed, > because if a cycle or rule deps error is detected, this message is not > printed and user doesn't have a hit on what's the right phase to put the > rule to. > 3) I've updated > https://github.com/windup/windup/wiki/Rules-Rule-Execution-Lifecycle > with the list of phases, as a temporary info. 4) The Implicit phase should be returned by getPhase() for rules whose both after/before return something. See below. > > > I suggest that we do NOT set the default phase MigrationRules in case > both getExecuteAfter() and getExecuteBefore() are overriden (return > something). > That will allow users to omit getPhase(). > See the code and exception below for motivation. > > WDYT? > From lincolnbaxter at gmail.com Thu Jan 29 15:25:54 2015 From: lincolnbaxter at gmail.com (Lincoln Baxter, III) Date: Thu, 29 Jan 2015 15:25:54 -0500 Subject: [windup-dev] IdentifyArchives / SkipArchives - state In-Reply-To: <54CA4149.1050107@redhat.com> References: <54C85440.7020001@redhat.com> <CAEp_U4FiCLNTksC2aGprwJ5Sfrf92KG6at-yTxZsqxdCkf9C+Q@mail.gmail.com> <54CA4149.1050107@redhat.com> Message-ID: <CAEp_U4GEzWELdE8xu8Q44QVPpoN+jW_OK1TXjgm6URHqpjMUFQ@mail.gmail.com> I never got around to this. Too much other stuff. On Thu, Jan 29, 2015 at 9:18 AM, Ondrej Zizka <ozizka at redhat.com> wrote: > Hi Lincoln, > > I have few more changes, could you please create a PR into > windup-quickstarts and I will then merge and create PR into windup? > > Thanks, > Ondra > > > > On 28.1.2015 19:02, Lincoln Baxter, III wrote: > > Thanks for your hard work. Good luck with training. I'm going to try to > finish this today. > > On Tue, Jan 27, 2015 at 10:15 PM, Ondrej Zizka <ozizka at redhat.com> wrote: > >> Hi, >> >> sorry to say I'm a bit late with this due to the Forge issue. >> Since I'll be on training tomorrow and this could block release (?), >> here's the status: >> >> What's freshly done: >> The data bundle - something that creates a fresh .zip artifact with >> the SHA1 -> GAV mapping from Maven Central during the build. >> >> What's missing: >> Loading this bundle into the class which does actual identification. >> Not tested in rules - only pieces. >> >> Both should be relatively easy to fix: >> Loading is probably matter of adding the right addon to classpath >> and feeding the resource to ArchiveGAVIdentifier.addMappingsFrom(is); in >> IdentifyArchivesLoadConfigRules. >> Tests are roughly written IIRC, only I got stuck with the mentioned >> issue and then was debugging them. >> >> Need to go sleep, the training starts in 4,5 hours. >> Ondra >> _______________________________________________ >> windup-dev mailing list >> windup-dev at lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/windup-dev >> > > > > -- > Lincoln Baxter, III > http://ocpsoft.org > "Simpler is better." > > > _______________________________________________ > windup-dev mailing listwindup-dev at lists.jboss.orghttps://lists.jboss.org/mailman/listinfo/windup-dev > > > > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev > -- Lincoln Baxter, III http://ocpsoft.org "Simpler is better." -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/windup-dev/attachments/20150129/0be75da9/attachment.html From jsightle at redhat.com Thu Jan 29 15:35:40 2015 From: jsightle at redhat.com (Jess Sightler) Date: Thu, 29 Jan 2015 15:35:40 -0500 Subject: [windup-dev] Phases, after, before In-Reply-To: <54CA408D.7050207@redhat.com> References: <54CA3E9C.2000800@seznam.cz> <54CA3EE3.7090409@redhat.com> <54CA408D.7050207@redhat.com> Message-ID: <54CA999C.9090107@redhat.com> Yes, I think this fits with the way phases are designed now. I do think that it should only happen if both an executeBefore and an executeAfter are specified, though. On 01/29/2015 09:15 AM, Ondrej Zizka wrote: > In other words: > > It is a bit useless to figure out what phase it is in case you know both > bounds, and find the right phase to fit it in. > Sometimes the bounds span over multiple phases. > > Even if you do not have the upper (execute before) bound, we could just > set ReportingPhase as the upper bound automatically. > > IIUC, the phases now can be used in getBefore() and getAfter(). > Correct me please if I get that incorrectly. > > Thanks, > Ondra > > > On 29.1.2015 15:08, Ondrej Zizka wrote: >> (Re-sending from my RH account, pls reply to this, thx) >> >> >> On 29.1.2015 15:07, "Ing. Ond?ej ?i?ka" wrote: >>> Hi all, >>> >>> see the code below. >>> >>> Originally I thought that getPhase() was removed entirely. >>> Now I see that we have all of getExecuteAfter(), getExecuteBefore() and >>> getPhase(). >>> >>> I suggest that we do NOT set the default phase MigrationRules in case >>> both getExecuteAfter() and getExecuteBefore() are overriden (return >>> something). >>> That will allow users to omit getPhase(). >>> See the code and exception below for motivation. >>> >>> WDYT? >>> >>> =============================== >>> public class SkipArchivesRules extends WindupRuleProvider >>> { >>> @Override >>> public List<Class<? extends WindupRuleProvider>> getExecuteAfter() >>> { >>> return asClassList(IdentifyArchivesRules.class, >>> SkipArchivesLoadConfigRules.class); >>> } >>> >>> @Override >>> public List<Class<? extends WindupRuleProvider>> getExecuteBefore() >>> { >>> return asClassList(DecompileArchivesRuleProvider.class); >>> } >>> >>> java.lang.RuntimeException: Dependency cycles detected: Found dependency >>> cycle involving: _DEFAULT_.SkipArchivesRules >>> Subcycle: _DEFAULT_.SkipArchivesRules >>> Subcycle: >>> org.jboss.windup.rules.apps:rules-java.DecompileArchivesRuleProvider >>> Subcycle: >>> org.jboss.windup.quickstarts:windup-skiparchives.IdentifyArchivesRules >>> Subcycle: InitialAnalysis >>> Subcycle: >>> org.jboss.windup.quickstarts:windup-skiparchives.SkipArchivesLoadConfigRules >>> Subcycle: >>> org.jboss.windup.quickstarts:windup-skiparchives.SkipArchivesRules >>> Subcycle: MigrationRules >>> Subcycle: >>> org.jboss.windup.rules.apps:rules-java.AnalyzeJavaFilesRuleProvider >>> >>> _______________________________________________ >>> windup-dev mailing list >>> windup-dev at lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/windup-dev >> _______________________________________________ >> windup-dev mailing list >> windup-dev at lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/windup-dev > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev -- Calendar Free/Busy: https://www.google.com/calendar/embed?src=jsightle%40redhat.com&ctz=America/New_York