[windup-dev] FileMapping.getId()

Ondrej Zizka ozizka at redhat.com
Tue Mar 24 21:31:23 EDT 2015


     @Override
     public String getId()
     {
         return this.getClass().getName() + "_" + 
UUID.randomUUID().toString();
     }

Isn't it a potential problem that this returns different values on each 
call?
Shouldn't it store a value once called? Or derive the value from, say, a 
class object? Or just use Class#hashCode()?
And maybe this method's default impl should move to GraphRule?
What if we refrained from using UUID which gives unnecessary long 
strings, and used RandomStringUtils.randomAlphanumeric(6) or such?
And lastly, this could be

Regards,
Ondra


More information about the windup-dev mailing list