From mbriskar at redhat.com Tue Sep 1 09:41:56 2015 From: mbriskar at redhat.com (Matej Briskar) Date: Tue, 1 Sep 2015 09:41:56 -0400 (EDT) Subject: [windup-dev] EAP6-EAP7 migration In-Reply-To: <2075059446.16249084.1441114044079.JavaMail.zimbra@redhat.com> Message-ID: <150033025.16264940.1441114916320.JavaMail.zimbra@redhat.com> Hello team, there are new issues in the jira issues tracker for migrating EAP6->EAP7 thanks to Eduardo. Currently we have 3 new issues (https://issues.jboss.org/browse/WINDUPRULE-66). We have two ways we may resolve them: a) create XSLT - this will take a lot of time, but user may love us for it b) put there only hint - simple to do. Not sure which way to go and if we have some time to spend doing XSLT. (estimation is 1 week for 1 XSLT transformation). From ozizka at redhat.com Wed Sep 2 11:43:34 2015 From: ozizka at redhat.com (Ondrej Zizka) Date: Wed, 2 Sep 2015 17:43:34 +0200 Subject: [windup-dev] EAP6-EAP7 migration In-Reply-To: <150033025.16264940.1441114916320.JavaMail.zimbra@redhat.com> References: <150033025.16264940.1441114916320.JavaMail.zimbra@redhat.com> Message-ID: <55E71926.7000707@redhat.com> I am adding 3rd way: We could read the EAP 6 config using CLI, and write the EAP 7 config using CLI. That would need us to get the location of the EAP 6 dir and the new EAP 7 dir, and then run both in host controller mode, or how is it called. Is that viable? Ondra On 1.9.2015 15:41, Matej Briskar wrote: > Hello team, > there are new issues in the jira issues tracker for migrating EAP6->EAP7 thanks to Eduardo. Currently we have 3 new issues (https://issues.jboss.org/browse/WINDUPRULE-66). > > We have two ways we may resolve them: > a) create XSLT - this will take a lot of time, but user may love us for it > b) put there only hint - simple to do. > > Not sure which way to go and if we have some time to spend doing XSLT. (estimation is 1 week for 1 XSLT transformation). > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev From lincolnbaxter at gmail.com Wed Sep 2 11:45:34 2015 From: lincolnbaxter at gmail.com (Lincoln Baxter, III) Date: Wed, 2 Sep 2015 11:45:34 -0400 Subject: [windup-dev] EAP6-EAP7 migration In-Reply-To: <55E71926.7000707@redhat.com> References: <150033025.16264940.1441114916320.JavaMail.zimbra@redhat.com> <55E71926.7000707@redhat.com> Message-ID: <CAEp_U4FjRPZJB1P1h_BTEZeEyML4dK-CxKpoUrmwNior4e2VRA@mail.gmail.com> I think that generating the configuration is a good idea. I don't have a strong preference about how it is done. On Wed, Sep 2, 2015 at 11:43 AM, Ondrej Zizka <ozizka at redhat.com> wrote: > I am adding 3rd way: > > We could read the EAP 6 config using CLI, and write the EAP 7 config > using CLI. > > That would need us to get the location of the EAP 6 dir and the new EAP > 7 dir, > and then run both in host controller mode, or how is it called. > > Is that viable? > > Ondra > > > On 1.9.2015 15:41, Matej Briskar wrote: > > Hello team, > > there are new issues in the jira issues tracker for migrating EAP6->EAP7 > thanks to Eduardo. Currently we have 3 new issues ( > https://issues.jboss.org/browse/WINDUPRULE-66). > > > > We have two ways we may resolve them: > > a) create XSLT - this will take a lot of time, but user may love us for > it > > b) put there only hint - simple to do. > > > > Not sure which way to go and if we have some time to spend doing XSLT. > (estimation is 1 week for 1 XSLT transformation). > > _______________________________________________ > > windup-dev mailing list > > windup-dev at lists.jboss.org > > https://lists.jboss.org/mailman/listinfo/windup-dev > > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev > -- Lincoln Baxter, III http://ocpsoft.org "Simpler is better." -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/windup-dev/attachments/20150902/30bdef08/attachment.html From emartins at redhat.com Wed Sep 2 12:08:49 2015 From: emartins at redhat.com (Eduardo Martins) Date: Wed, 2 Sep 2015 17:08:49 +0100 Subject: [windup-dev] EAP6-EAP7 migration In-Reply-To: <55E71926.7000707@redhat.com> References: <150033025.16264940.1441114916320.JavaMail.zimbra@redhat.com> <55E71926.7000707@redhat.com> Message-ID: <DC7F141C-D1C0-48EE-B02C-7E8631133D41@redhat.com> Besides depending on EAP binaries, you would also need an embeddable EAP, and that is only on WildFly (and doesn?t integrate with windup due to logging issues). ?E > On 02 Sep 2015, at 16:43, Ondrej Zizka <ozizka at redhat.com> wrote: > > I am adding 3rd way: > > We could read the EAP 6 config using CLI, and write the EAP 7 config using CLI. > > That would need us to get the location of the EAP 6 dir and the new EAP 7 dir, > and then run both in host controller mode, or how is it called. > > Is that viable? > > Ondra > > > On 1.9.2015 15:41, Matej Briskar wrote: >> Hello team, >> there are new issues in the jira issues tracker for migrating EAP6->EAP7 thanks to Eduardo. Currently we have 3 new issues (https://issues.jboss.org/browse/WINDUPRULE-66). >> >> We have two ways we may resolve them: >> a) create XSLT - this will take a lot of time, but user may love us for it >> b) put there only hint - simple to do. >> >> Not sure which way to go and if we have some time to spend doing XSLT. (estimation is 1 week for 1 XSLT transformation). >> _______________________________________________ >> windup-dev mailing list >> windup-dev at lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/windup-dev > From ozizka at redhat.com Wed Sep 2 12:35:10 2015 From: ozizka at redhat.com (Ondrej Zizka) Date: Wed, 2 Sep 2015 18:35:10 +0200 Subject: [windup-dev] Features for Discussion In-Reply-To: <977551341.7749345.1438699298660.JavaMail.zimbra@redhat.com> References: <977551341.7749345.1438699298660.JavaMail.zimbra@redhat.com> Message-ID: <55E7253E.4090706@redhat.com> Is it based on some particular case? The Java-based rules are currently mostly those generic which are later needed by the XML-based rules... But maybe cases like disabling the failing tattletale java-based rule could be useful. Is that what you mean? Ondra On 4.8.2015 16:41, Brad Davis wrote: > I'd like to have the following features, but wanted to get everyone's feedback. > > 1) The ability to read in effort from the XML files. > > User Story: User runs Windup report and doesn't agree with the effort estimate. They would like to change the effort for a Java rule and rerun Windup, but aren't technical enough to recompile Windup. > Proposed Solution: Having a utility that we could use to easily look up a property from the Windup XML configuration would be a great solution for this. That way, it makes it easy for people to modify the effort. > > > 2) The ability to override and disable rules from the XML. > > User Story: A Java rule is not providing anticipated output and needs to be excluded from the report. > Proposed Solution: Have a simple registry of disabled rules in the XML, where the qualified Java class is provided that needs to be disabled / skipped. > > > Brad Davis > Senior Manager, Red Hat Consulting > Email: bdavis at redhat.com | c: 980.226.7865 | http://www.redhat.com > > > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev From ozizka at redhat.com Wed Sep 2 12:39:51 2015 From: ozizka at redhat.com (Ondrej Zizka) Date: Wed, 2 Sep 2015 18:39:51 +0200 Subject: [windup-dev] EAP6-EAP7 migration In-Reply-To: <CAEp_U4FjRPZJB1P1h_BTEZeEyML4dK-CxKpoUrmwNior4e2VRA@mail.gmail.com> References: <150033025.16264940.1441114916320.JavaMail.zimbra@redhat.com> <55E71926.7000707@redhat.com> <CAEp_U4FjRPZJB1P1h_BTEZeEyML4dK-CxKpoUrmwNior4e2VRA@mail.gmail.com> Message-ID: <55E72657.4030309@redhat.com> How it's done affects how the user uses it. A) With the XSLT approach, user will have to point windup to the single standalone.xml file I guess. But it can be done "statically", nothing really running. B) With CLI, the user will point Windup to the 2 directories (EAP 6, EAP 7). And the operation will try to run some CLI. B is imo more convenient, and also will reuse the existing code handing the standalone.xml read/write (and take care of namespaces), but will take longer to implement correctly. So I guess it's something for later sprints? Ondra On 2.9.2015 17:45, Lincoln Baxter, III wrote: > I think that generating the configuration is a good idea. I don't have > a strong preference about how it is done. > > On Wed, Sep 2, 2015 at 11:43 AM, Ondrej Zizka <ozizka at redhat.com > <mailto:ozizka at redhat.com>> wrote: > > I am adding 3rd way: > > We could read the EAP 6 config using CLI, and write the EAP 7 config > using CLI. > > That would need us to get the location of the EAP 6 dir and the > new EAP > 7 dir, > and then run both in host controller mode, or how is it called. > > Is that viable? > > Ondra > > > On 1.9.2015 15:41, Matej Briskar wrote: > > Hello team, > > there are new issues in the jira issues tracker for migrating > EAP6->EAP7 thanks to Eduardo. Currently we have 3 new issues > (https://issues.jboss.org/browse/WINDUPRULE-66). > > > > We have two ways we may resolve them: > > a) create XSLT - this will take a lot of time, but user may love > us for it > > b) put there only hint - simple to do. > > > > Not sure which way to go and if we have some time to spend doing > XSLT. (estimation is 1 week for 1 XSLT transformation). > > _______________________________________________ > > windup-dev mailing list > > windup-dev at lists.jboss.org <mailto:windup-dev at lists.jboss.org> > > https://lists.jboss.org/mailman/listinfo/windup-dev > > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org <mailto:windup-dev at lists.jboss.org> > https://lists.jboss.org/mailman/listinfo/windup-dev > > > > > -- > Lincoln Baxter, III > http://ocpsoft.org > "Simpler is better." > > > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/windup-dev/attachments/20150902/429fbff5/attachment.html From jsightle at redhat.com Wed Sep 2 14:01:47 2015 From: jsightle at redhat.com (Jess Sightler) Date: Wed, 2 Sep 2015 14:01:47 -0400 Subject: [windup-dev] Features for Discussion In-Reply-To: <977551341.7749345.1438699298660.JavaMail.zimbra@redhat.com> References: <977551341.7749345.1438699298660.JavaMail.zimbra@redhat.com> Message-ID: <55E7398B.80707@redhat.com> On 08/04/2015 10:41 AM, Brad Davis wrote: > I'd like to have the following features, but wanted to get everyone's feedback. > > 1) The ability to read in effort from the XML files. > > User Story: User runs Windup report and doesn't agree with the effort estimate. They would like to change the effort for a Java rule and rerun Windup, but aren't technical enough to recompile Windup. > Proposed Solution: Having a utility that we could use to easily look up a property from the Windup XML configuration would be a great solution for this. That way, it makes it easy for people to modify the effort. > > > 2) The ability to override and disable rules from the XML. > > User Story: A Java rule is not providing anticipated output and needs to be excluded from the report. > Proposed Solution: Have a simple registry of disabled rules in the XML, where the qualified Java class is provided that needs to be disabled / skipped. I think this is a good idea, although I think that we should base it on the Rule Provider ID (or optionally rule id) rather than on the class name. > > > Brad Davis > Senior Manager, Red Hat Consulting > Email: bdavis at redhat.com | c: 980.226.7865 | http://www.redhat.com > > > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev From bdavis at redhat.com Wed Sep 2 14:08:12 2015 From: bdavis at redhat.com (Brad Davis) Date: Wed, 2 Sep 2015 14:08:12 -0400 (EDT) Subject: [windup-dev] Features for Discussion In-Reply-To: <55E7398B.80707@redhat.com> References: <977551341.7749345.1438699298660.JavaMail.zimbra@redhat.com> <55E7398B.80707@redhat.com> Message-ID: <E440CB8D-F4CF-442B-82DD-C0D444AD1857@redhat.com> Sure; makes sense to me. I figured you would just comment out XML rules but there isn't a way to do that with Java rules. Rule name is fine though. Sent from my iPhone > On Sep 2, 2015, at 2:01 PM, Jess Sightler <jsightle at redhat.com> wrote: > > > >> On 08/04/2015 10:41 AM, Brad Davis wrote: >> I'd like to have the following features, but wanted to get everyone's feedback. >> >> 1) The ability to read in effort from the XML files. >> >> User Story: User runs Windup report and doesn't agree with the effort estimate. They would like to change the effort for a Java rule and rerun Windup, but aren't technical enough to recompile Windup. >> Proposed Solution: Having a utility that we could use to easily look up a property from the Windup XML configuration would be a great solution for this. That way, it makes it easy for people to modify the effort. >> >> >> 2) The ability to override and disable rules from the XML. >> >> User Story: A Java rule is not providing anticipated output and needs to be excluded from the report. >> Proposed Solution: Have a simple registry of disabled rules in the XML, where the qualified Java class is provided that needs to be disabled / skipped. > > I think this is a good idea, although I think that we should base it on > the Rule Provider ID (or optionally rule id) rather than on the class name. > > > >> >> >> Brad Davis >> Senior Manager, Red Hat Consulting >> Email: bdavis at redhat.com | c: 980.226.7865 | http://www.redhat.com >> >> >> _______________________________________________ >> windup-dev mailing list >> windup-dev at lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/windup-dev > > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev From lincolnbaxter at gmail.com Wed Sep 2 15:34:33 2015 From: lincolnbaxter at gmail.com (Lincoln Baxter, III) Date: Wed, 2 Sep 2015 15:34:33 -0400 Subject: [windup-dev] Features for Discussion In-Reply-To: <E440CB8D-F4CF-442B-82DD-C0D444AD1857@redhat.com> References: <977551341.7749345.1438699298660.JavaMail.zimbra@redhat.com> <55E7398B.80707@redhat.com> <E440CB8D-F4CF-442B-82DD-C0D444AD1857@redhat.com> Message-ID: <CAEp_U4FhMR20Vx+sv9AAUY-yTP3ECWE8_LRvou+=vrOB-7CX=w@mail.gmail.com> I like both of these things, and both can really be done already. We can certainly try to make the experience simpler. I think both of these things get easier if we start to deliver windup as a web-application. On Wed, Sep 2, 2015 at 2:08 PM, Brad Davis <bdavis at redhat.com> wrote: > Sure; makes sense to me. I figured you would just comment out XML rules > but there isn't a way to do that with Java rules. Rule name is fine though. > > Sent from my iPhone > > > On Sep 2, 2015, at 2:01 PM, Jess Sightler <jsightle at redhat.com> wrote: > > > > > > > >> On 08/04/2015 10:41 AM, Brad Davis wrote: > >> I'd like to have the following features, but wanted to get everyone's > feedback. > >> > >> 1) The ability to read in effort from the XML files. > >> > >> User Story: User runs Windup report and doesn't agree with the effort > estimate. They would like to change the effort for a Java rule and rerun > Windup, but aren't technical enough to recompile Windup. > >> Proposed Solution: Having a utility that we could use to easily look up > a property from the Windup XML configuration would be a great solution for > this. That way, it makes it easy for people to modify the effort. > >> > >> > >> 2) The ability to override and disable rules from the XML. > >> > >> User Story: A Java rule is not providing anticipated output and needs > to be excluded from the report. > >> Proposed Solution: Have a simple registry of disabled rules in the XML, > where the qualified Java class is provided that needs to be disabled / > skipped. > > > > I think this is a good idea, although I think that we should base it on > > the Rule Provider ID (or optionally rule id) rather than on the class > name. > > > > > > > >> > >> > >> Brad Davis > >> Senior Manager, Red Hat Consulting > >> Email: bdavis at redhat.com | c: 980.226.7865 | http://www.redhat.com > >> > >> > >> _______________________________________________ > >> windup-dev mailing list > >> windup-dev at lists.jboss.org > >> https://lists.jboss.org/mailman/listinfo/windup-dev > > > > _______________________________________________ > > windup-dev mailing list > > windup-dev at lists.jboss.org > > https://lists.jboss.org/mailman/listinfo/windup-dev > > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev > -- Lincoln Baxter, III http://ocpsoft.org "Simpler is better." -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/windup-dev/attachments/20150902/8c51deab/attachment.html From bdavis at redhat.com Wed Sep 2 22:18:02 2015 From: bdavis at redhat.com (Brad Davis) Date: Wed, 2 Sep 2015 22:18:02 -0400 (EDT) Subject: [windup-dev] JBoss Web Framework Kit -- Good Migration Option In-Reply-To: <1365262661.22478086.1441246433099.JavaMail.zimbra@redhat.com> Message-ID: <707528179.22478627.1441246682378.JavaMail.zimbra@redhat.com> I have largely ignored the JBoss Web Framework Kit, but it should be something we are actively looking at for migrations. We could be pushing it when we see versions of Seam, Struts, Spring that aren't otherwise in JBoss EAP 6.x but that is their target. In other words, if the customer doesn't want to rewrite things but just wants support on the newest server, it might be an option. We are exploring this with one of our customers currently, and I think it is a good options in some scenarios. https://access.redhat.com/articles/112543 Basically path of least resistance upgrades. Brad Davis Senior Manager, Red Hat Consulting Email: bdavis at redhat.com | c: 980.226.7865 | http://www.redhat.com From bdavis at redhat.com Wed Sep 2 22:45:14 2015 From: bdavis at redhat.com (Brad Davis) Date: Wed, 2 Sep 2015 22:45:14 -0400 (EDT) Subject: [windup-dev] JSP / JSP / Taglib Parsing & Rules In-Reply-To: <606371660.22488914.1441247470460.JavaMail.zimbra@redhat.com> Message-ID: <354412503.22503923.1441248314817.JavaMail.zimbra@redhat.com> One of my projects leverages Richfaces 3 and we need to move to 4. It would be very helpful to expand upon the (basic) JSP rules that we had in Windup 0.7 with actual JSP parsing in Windup 2.4. Because we leverage Eclipse for AST with Java, I wonder if we can do the same thing for JSF / JSP? Maybe we can reach out to one of the project leads in the Eclipse community to get their recommendation on which project would provide similar functionality for those technologies. I think Nick Sandonato from the Eclipse WTP team may be a good starting point. There is a migration guide at: https://developer.jboss.org/wiki/RichFaces33-4xMigrationGuideUnleashed I guess we could use old-fashioned XPath and probably get a lot of the way, but I think in Windup 1 this fell down around <% %> / embedded code. Thoughts? Brad Davis Senior Manager, Red Hat Consulting Email: bdavis at redhat.com | c: 980.226.7865 | http://www.redhat.com From bdavis at redhat.com Wed Sep 2 23:14:30 2015 From: bdavis at redhat.com (Brad Davis) Date: Wed, 2 Sep 2015 23:14:30 -0400 (EDT) Subject: [windup-dev] JSP / JSP / Taglib Parsing & Rules In-Reply-To: <354412503.22503923.1441248314817.JavaMail.zimbra@redhat.com> References: <354412503.22503923.1441248314817.JavaMail.zimbra@redhat.com> Message-ID: <74754491.22510140.1441250070920.JavaMail.zimbra@redhat.com> For JSP, it looks like the following project / source would do what we are looking for: https://github.com/eclipse/webtools.sourceediting/blob/master/bundles/org.eclipse.jst.jsp.core/src/org/eclipse/jst/jsp/core/internal/parser/JSPSourceParser.java Examples of parsing: https://github.com/eclipse/webtools.sourceediting.tests/blob/master/tests/org.eclipse.jst.jsp.ui.tests/src/org/eclipse/jst/jsp/ui/tests/model/TestModelsFromFiles.java Brad Davis Senior Manager, Red Hat Consulting Email: bdavis at redhat.com | c: 980.226.7865 | http://www.redhat.com ----- Original Message ----- From: "Brad Davis" <bdavis at redhat.com> To: "Windup-dev List" <windup-dev at lists.jboss.org> Sent: Wednesday, September 2, 2015 10:45:14 PM Subject: [windup-dev] JSP / JSP / Taglib Parsing & Rules One of my projects leverages Richfaces 3 and we need to move to 4. It would be very helpful to expand upon the (basic) JSP rules that we had in Windup 0.7 with actual JSP parsing in Windup 2.4. Because we leverage Eclipse for AST with Java, I wonder if we can do the same thing for JSF / JSP? Maybe we can reach out to one of the project leads in the Eclipse community to get their recommendation on which project would provide similar functionality for those technologies. I think Nick Sandonato from the Eclipse WTP team may be a good starting point. There is a migration guide at: https://developer.jboss.org/wiki/RichFaces33-4xMigrationGuideUnleashed I guess we could use old-fashioned XPath and probably get a lot of the way, but I think in Windup 1 this fell down around <% %> / embedded code. Thoughts? Brad Davis Senior Manager, Red Hat Consulting Email: bdavis at redhat.com | c: 980.226.7865 | http://www.redhat.com _______________________________________________ windup-dev mailing list windup-dev at lists.jboss.org https://lists.jboss.org/mailman/listinfo/windup-dev From mnovotny at redhat.com Thu Sep 3 04:11:53 2015 From: mnovotny at redhat.com (Marek Novotny) Date: Thu, 3 Sep 2015 10:11:53 +0200 Subject: [windup-dev] JBoss Web Framework Kit -- Good Migration Option In-Reply-To: <707528179.22478627.1441246682378.JavaMail.zimbra@redhat.com> References: <707528179.22478627.1441246682378.JavaMail.zimbra@redhat.com> Message-ID: <55E800C9.1010704@redhat.com> On 3.9.2015 04:18, Brad Davis wrote: > I have largely ignored the JBoss Web Framework Kit, Oh, what a shame on you :D but it should be something we are actively looking at for migrations. I would agree with that but to migrate to CDI and new stuff. We try the best in the deadline we had in the latest WFK release, but we could be definitely better (that was/is my motivation to join WindUp team) We could be pushing it when we see versions of Seam, Struts, Spring that aren't otherwise in JBoss EAP 6.x but that is their target. First from your list only Seam should be matter of our focus. Spring was not delivered and supported in any way like a product until you didn't use Snowdrop, but that was not really required for Spring 3/4 applications, and Spring as such is still certified/supported in EAP 6 testing. I believe Struts wasn't anything more than we gave advises and tested minimal examples on our platforms. In your referenced URL https://access.redhat.com/articles/1125, please read the explanation what Tier 4 is ;) In other words, if the customer doesn't want to rewrite things but just wants support on the newest server, it might be an option. I don't think it should be the safe way for customer, because that opens a pandora's box. It is always better to stay with out-of-date technology in the application if they don't want to migrate that outdated tech. We everywhere recommends to migrate from Seam to CDI and Deltaspike and for Spring only versions 3 and 4 are certified for now. Struts are out of scope as it was a long time ago you should move to JSF from it. We are exploring this with one of our customers currently, and I think it is a good options in some scenarios. +1 for some very specific scenarios yes, but for majority application not. Take for instance jbpm 3 case used in Seam 2, that is definitely not good way to take such existing application and try to deploy to EAP6. > > https://access.redhat.com/articles/112543 > > Basically path of least resistance upgrades. > > Brad Davis > Senior Manager, Red Hat Consulting > Email: bdavis at redhat.com | c: 980.226.7865 | http://www.redhat.com > > > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev > -- Marek Novotny -- Windup team member and Seam Project Lead Red Hat Czech s.r.o. Purkynova 99 612 45 Brno From mnovotny at redhat.com Thu Sep 3 04:18:27 2015 From: mnovotny at redhat.com (Marek Novotny) Date: Thu, 3 Sep 2015 10:18:27 +0200 Subject: [windup-dev] JSP / JSP / Taglib Parsing & Rules In-Reply-To: <354412503.22503923.1441248314817.JavaMail.zimbra@redhat.com> References: <354412503.22503923.1441248314817.JavaMail.zimbra@redhat.com> Message-ID: <55E80253.1050101@redhat.com> You probably need to move even to newer 4.5.x. Be aware of bigger changes between 4.3.x and 4.5.x which was first called as Richfaces 5 and then was downgraded to minor versionning. Read https://github.com/richfaces/richfaces/wiki/Migration-from-RichFaces-4-to-RichFaces-4.5 for better understanding of changes as addition to Richfaces 3 to 4 migration guide. On 3.9.2015 04:45, Brad Davis wrote: > One of my projects leverages Richfaces 3 and we need to move to 4. It would be very helpful to expand upon the (basic) JSP rules that we had in Windup 0.7 with actual JSP parsing in Windup 2.4. Because we leverage Eclipse for AST with Java, I wonder if we can do the same thing for JSF / JSP? Maybe we can reach out to one of the project leads in the Eclipse community to get their recommendation on which project would provide similar functionality for those technologies. I think Nick Sandonato from the Eclipse WTP team may be a good starting point. > > There is a migration guide at: https://developer.jboss.org/wiki/RichFaces33-4xMigrationGuideUnleashed > > I guess we could use old-fashioned XPath and probably get a lot of the way, but I think in Windup 1 this fell down around <% %> / embedded code. Thoughts? Richfaces 3.3 and later was used more JSF Facelets technology so basic handling of <% %> is not enough IMO, but XPATH and XSLT transformation of JSF templates could do the thing. > > Brad Davis > Senior Manager, Red Hat Consulting > Email: bdavis at redhat.com | c: 980.226.7865 | http://www.redhat.com > > > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev > -- Marek Novotny -- Windup team member and Seam Project Lead Red Hat Czech s.r.o. Purkynova 99 612 45 Brno From mnovotny at redhat.com Thu Sep 3 04:23:04 2015 From: mnovotny at redhat.com (Marek Novotny) Date: Thu, 3 Sep 2015 10:23:04 +0200 Subject: [windup-dev] JSP / JSP / Taglib Parsing & Rules In-Reply-To: <74754491.22510140.1441250070920.JavaMail.zimbra@redhat.com> References: <354412503.22503923.1441248314817.JavaMail.zimbra@redhat.com> <74754491.22510140.1441250070920.JavaMail.zimbra@redhat.com> Message-ID: <55E80368.3040406@redhat.com> Some JSP to JSF migration resources: https://javaserverfaces.java.net/rlnotes/2.0.0/migration.html http://stackoverflow.com/questions/4441713/migrating-from-jsf-1-2-to-jsf-2-0/4532870#4532870 On 3.9.2015 05:14, Brad Davis wrote: > For JSP, it looks like the following project / source would do what we are looking for: > > https://github.com/eclipse/webtools.sourceediting/blob/master/bundles/org.eclipse.jst.jsp.core/src/org/eclipse/jst/jsp/core/internal/parser/JSPSourceParser.java > > Examples of parsing: > https://github.com/eclipse/webtools.sourceediting.tests/blob/master/tests/org.eclipse.jst.jsp.ui.tests/src/org/eclipse/jst/jsp/ui/tests/model/TestModelsFromFiles.java > > > > Brad Davis > Senior Manager, Red Hat Consulting > Email: bdavis at redhat.com | c: 980.226.7865 | http://www.redhat.com > > > ----- Original Message ----- > From: "Brad Davis" <bdavis at redhat.com> > To: "Windup-dev List" <windup-dev at lists.jboss.org> > Sent: Wednesday, September 2, 2015 10:45:14 PM > Subject: [windup-dev] JSP / JSP / Taglib Parsing & Rules > > One of my projects leverages Richfaces 3 and we need to move to 4. It would be very helpful to expand upon the (basic) JSP rules that we had in Windup 0.7 with actual JSP parsing in Windup 2.4. Because we leverage Eclipse for AST with Java, I wonder if we can do the same thing for JSF / JSP? Maybe we can reach out to one of the project leads in the Eclipse community to get their recommendation on which project would provide similar functionality for those technologies. I think Nick Sandonato from the Eclipse WTP team may be a good starting point. > > There is a migration guide at: https://developer.jboss.org/wiki/RichFaces33-4xMigrationGuideUnleashed > > I guess we could use old-fashioned XPath and probably get a lot of the way, but I think in Windup 1 this fell down around <% %> / embedded code. Thoughts? > > Brad Davis > Senior Manager, Red Hat Consulting > Email: bdavis at redhat.com | c: 980.226.7865 | http://www.redhat.com > > > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev > -- Marek Novotny -- Windup team member and Seam Project Lead Red Hat Czech s.r.o. Purkynova 99 612 45 Brno From rruss at redhat.com Tue Sep 8 15:12:40 2015 From: rruss at redhat.com (Rodney Russ) Date: Tue, 08 Sep 2015 13:12:40 -0600 Subject: [windup-dev] JBoss Web Framework Kit -- Good Migration Option In-Reply-To: <55E800C9.1010704@redhat.com> References: <707528179.22478627.1441246682378.JavaMail.zimbra@redhat.com> <55E800C9.1010704@redhat.com> Message-ID: <E3D92974-4D74-477A-BBAB-460551AD70C3@redhat.com> On 3 Sep 2015, at 2:11, Marek Novotny wrote: > On 3.9.2015 04:18, Brad Davis wrote: >> I have largely ignored the JBoss Web Framework Kit, > > Oh, what a shame on you :D > > but it should be something we are actively looking at for migrations. > I would agree with that but to migrate to CDI and new stuff. We try > the > best in the deadline we had in the latest WFK release, but we could be > definitely better (that was/is my motivation to join WindUp team) > > We could be pushing it when we see versions of Seam, Struts, Spring > that > aren't otherwise in JBoss EAP 6.x but that is their target. > > First from your list only Seam should be matter of our focus. Spring > was > not delivered and supported in any way like a product until you didn't > use Snowdrop, but that was not really required for Spring 3/4 > applications, and Spring as such is still certified/supported in EAP 6 > testing. One thing that "may" be useful is finding versions of Spring in the application that are different from those that were certified on EAP. This could let the user know that these may be a problem given that the version they use is different from the version certified for EAP. One "interesting" aspect of this approach is that this versioning could be a moving target with each EAP release. So, it could prove a challenge to maintain. > > I believe Struts wasn't anything more than we gave advises and tested > minimal examples on our platforms. In your referenced URL > https://access.redhat.com/articles/1125, please read the explanation > what Tier 4 is ;) > > In other words, if the customer doesn't want to rewrite things but > just > wants support on the newest server, it might be an option. > I don't think it should be the safe way for customer, because that > opens > a pandora's box. It is always better to stay with out-of-date > technology > in the application if they don't want to migrate that outdated tech. > We > everywhere recommends to migrate from Seam to CDI and Deltaspike and > for > Spring only versions 3 and 4 are certified for now. Struts are out of > scope as it was a long time ago you should move to JSF from it. > > > We are exploring this with one of our customers currently, and I think > it is a good options in some scenarios. > +1 for some very specific scenarios yes, but for majority application > not. Take for instance jbpm 3 case used in Seam 2, that is definitely > not good way to take such existing application and try to deploy to > EAP6. > >> >> https://access.redhat.com/articles/112543 >> >> Basically path of least resistance upgrades. >> >> Brad Davis >> Senior Manager, Red Hat Consulting >> Email: bdavis at redhat.com | c: 980.226.7865 | http://www.redhat.com >> >> >> _______________________________________________ >> windup-dev mailing list >> windup-dev at lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/windup-dev >> > > > -- > Marek Novotny > -- > Windup team member and Seam Project Lead > > Red Hat Czech s.r.o. > Purkynova 99 > 612 45 Brno > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev From ozizka at redhat.com Wed Sep 9 20:09:18 2015 From: ozizka at redhat.com (Ondrej Zizka) Date: Thu, 10 Sep 2015 02:09:18 +0200 Subject: [windup-dev] Freemarker shortcut for lists Message-ID: <55F0CA2E.4060307@redhat.com> Hi team, instead this <#if getTechnologyTagsForFile(reportModel.sourceFileModel).iterator()?has_content> <dt>Technologies</dt> <dd> <#list getTechnologyTagsForFile(reportModel.sourceFileModel).iterator() as techTag> <span class="label label-info">${techTag.name}</span> </#list> </dd> </#if> which, besides ugly syntax, affects performance, Freemarker has this alternative: <#list getTechnologyTagsForFile(reportModel.sourceFileModel).iterator() > <dt>Technologies</dt> <dd> <#items as techTag> <span class="label label-info">${techTag.name}</span> </#items> </dd> </#list> HTH, Ondra From ozizka at redhat.com Wed Sep 9 21:38:01 2015 From: ozizka at redhat.com (Ondrej Zizka) Date: Thu, 10 Sep 2015 03:38:01 +0200 Subject: [windup-dev] EAP6-EAP7 migration In-Reply-To: <DC7F141C-D1C0-48EE-B02C-7E8631133D41@redhat.com> References: <150033025.16264940.1441114916320.JavaMail.zimbra@redhat.com> <55E71926.7000707@redhat.com> <DC7F141C-D1C0-48EE-B02C-7E8631133D41@redhat.com> Message-ID: <55F0DEF9.8040602@redhat.com> Eduardo, is it possible to do a system call (instead of direct API usage) to run a generated CLI script and let AS deal with it? Or a system call to boot the controller, and then use the REST API? The reason for that is, that AFAIR, fiddling with standalone.xml was officially deprecated way of configuring EAP, and the recommended, forward compatible way, was officially CLI commands. Is that still the case? Thanks, Ondra On 2.9.2015 18:08, Eduardo Martins wrote: > Besides depending on EAP binaries, you would also need an embeddable EAP, and that is only on WildFly (and doesn?t integrate with windup due to logging issues). > > ?E > >> On 02 Sep 2015, at 16:43, Ondrej Zizka <ozizka at redhat.com> wrote: >> >> I am adding 3rd way: >> >> We could read the EAP 6 config using CLI, and write the EAP 7 config using CLI. >> >> That would need us to get the location of the EAP 6 dir and the new EAP 7 dir, >> and then run both in host controller mode, or how is it called. >> >> Is that viable? >> >> Ondra >> >> >> On 1.9.2015 15:41, Matej Briskar wrote: >>> Hello team, >>> there are new issues in the jira issues tracker for migrating EAP6->EAP7 thanks to Eduardo. Currently we have 3 new issues (https://issues.jboss.org/browse/WINDUPRULE-66). >>> >>> We have two ways we may resolve them: >>> a) create XSLT - this will take a lot of time, but user may love us for it >>> b) put there only hint - simple to do. >>> >>> Not sure which way to go and if we have some time to spend doing XSLT. (estimation is 1 week for 1 XSLT transformation). >>> _______________________________________________ >>> windup-dev mailing list >>> windup-dev at lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/windup-dev From mnovotny at redhat.com Thu Sep 10 04:46:54 2015 From: mnovotny at redhat.com (Marek Novotny) Date: Thu, 10 Sep 2015 10:46:54 +0200 Subject: [windup-dev] Freemarker shortcut for lists In-Reply-To: <55F0CA2E.4060307@redhat.com> References: <55F0CA2E.4060307@redhat.com> Message-ID: <55F1437E.6020000@redhat.com> Great Ondra, that is much nicer! I looked, why we didn't use it already and it is available since FreeMarker 2.3.23 (Ondra upgraded to it in July), so NEW feature ;), but very helpful! Thanks for warning. On 10.9.2015 02:09, Ondrej Zizka wrote: > <#list > getTechnologyTagsForFile(reportModel.sourceFileModel).iterator() > > <dt>Technologies</dt> > <dd> > <#items as techTag> > <span class="label > label-info">${techTag.name}</span> > </#items> > </dd> > </#list> -- Marek Novotny -- Windup team member and Seam Project Lead Red Hat Czech s.r.o. Purkynova 99 612 45 Brno From emartins at redhat.com Thu Sep 10 06:42:17 2015 From: emartins at redhat.com (Eduardo Martins) Date: Thu, 10 Sep 2015 11:42:17 +0100 Subject: [windup-dev] EAP6-EAP7 migration In-Reply-To: <55F0DEF9.8040602@redhat.com> References: <150033025.16264940.1441114916320.JavaMail.zimbra@redhat.com> <55E71926.7000707@redhat.com> <DC7F141C-D1C0-48EE-B02C-7E8631133D41@redhat.com> <55F0DEF9.8040602@redhat.com> Message-ID: <E9F6C323-C658-47B8-ABDE-47EA488DF09A@redhat.com> > On 10 Sep 2015, at 02:38, Ondrej Zizka <ozizka at redhat.com> wrote: > > Eduardo, > > is it possible to do a system call (instead of direct API usage) to run a generated CLI script and let AS deal with it? > Or a system call to boot the controller, and then use the REST API? > Suppose you could do that, and the development of such functionalities would be less effort than developing the rules to handle the migration of 3 subsystems, then before you could invoke :migrate you would still need to parse and transform the old subsystem XML into management ops, i.e. need all EAP subsystem parsers. And you would also need to somehow transform the :migrate result into high level Windup report entries (targeting the source of migration, the XML). If you are trying yo avoid the XML rules with XSLT, due to XSLT complexity, an alternative would be Non XML Windup rules using a generic XML API, integrating the code logic of :migrate ops, which is short and not very complex. IMHO much less effort than what you propose above. > The reason for that is, that AFAIR, fiddling with standalone.xml was officially deprecated way of configuring EAP, and the recommended, forward compatible way, was officially CLI commands. > Is that still the case? > Recommended != mandatory, we certainly need to cover the migration of XML server configs, it?s the basic EAP config process, and is supported by Red Hat. ?E From ozizka at redhat.com Mon Sep 14 13:36:05 2015 From: ozizka at redhat.com (Ondrej Zizka) Date: Mon, 14 Sep 2015 19:36:05 +0200 Subject: [windup-dev] JSP / JSP / Taglib Parsing & Rules In-Reply-To: <354412503.22503923.1441248314817.JavaMail.zimbra@redhat.com> References: <354412503.22503923.1441248314817.JavaMail.zimbra@redhat.com> Message-ID: <55F70585.8060800@redhat.com> On 3.9.2015 04:45, Brad Davis wrote: > One of my projects leverages Richfaces 3 and we need to move to 4. It would be very helpful to expand upon the (basic) JSP rules that we had in Windup 0.7 with actual JSP parsing in Windup 2.4. Because we leverage Eclipse for AST with Java, I wonder if we can do the same thing for JSF / JSP? Maybe we can reach out to one of the project leads in the Eclipse community to get their recommendation on which project would provide similar functionality for those technologies. I think Nick Sandonato from the Eclipse WTP team may be a good starting point. > > There is a migration guide at: https://developer.jboss.org/wiki/RichFaces33-4xMigrationGuideUnleashed > > I guess we could use old-fashioned XPath and probably get a lot of the way, Probably not XPath, because JSP can be anything, like, <%if(fish){%> <?)))>< <%}%> Once I parsed JSP by looking at it as java file, and placing "out.print( ... )" instead of the content between %> and <% . Plus special handling for the <%@. Didn't cover 100 % but worked for my case. Now I would probably use the Tomcat's JSP to servlet source processor and parse that. WDYT? It would loose the context though. > but I think in Windup 1 this fell down around <% %> / embedded code. Thoughts? > > Brad Davis > Senior Manager, Red Hat Consulting > Email: bdavis at redhat.com | c: 980.226.7865 | http://www.redhat.com > > > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev From bdavis at redhat.com Mon Sep 14 13:40:28 2015 From: bdavis at redhat.com (Brad Davis) Date: Mon, 14 Sep 2015 13:40:28 -0400 (EDT) Subject: [windup-dev] JSP / JSP / Taglib Parsing & Rules In-Reply-To: <55F70585.8060800@redhat.com> References: <354412503.22503923.1441248314817.JavaMail.zimbra@redhat.com> <55F70585.8060800@redhat.com> Message-ID: <1604113205.27096369.1442252428903.JavaMail.zimbra@redhat.com> The APIs for the Eclipse library have a DOM parser that basically extends standard DOM parsing to handle <% %> from what I could tell. Brad Davis Senior Manager, Red Hat Consulting Email: bdavis at redhat.com | c: 980.226.7865 | http://www.redhat.com ----- Original Message ----- From: "Ondrej Zizka" <ozizka at redhat.com> To: windup-dev at lists.jboss.org Sent: Monday, September 14, 2015 1:36:05 PM Subject: Re: [windup-dev] JSP / JSP / Taglib Parsing & Rules On 3.9.2015 04:45, Brad Davis wrote: > One of my projects leverages Richfaces 3 and we need to move to 4. It would be very helpful to expand upon the (basic) JSP rules that we had in Windup 0.7 with actual JSP parsing in Windup 2.4. Because we leverage Eclipse for AST with Java, I wonder if we can do the same thing for JSF / JSP? Maybe we can reach out to one of the project leads in the Eclipse community to get their recommendation on which project would provide similar functionality for those technologies. I think Nick Sandonato from the Eclipse WTP team may be a good starting point. > > There is a migration guide at: https://developer.jboss.org/wiki/RichFaces33-4xMigrationGuideUnleashed > > I guess we could use old-fashioned XPath and probably get a lot of the way, Probably not XPath, because JSP can be anything, like, <%if(fish){%> <?)))>< <%}%> Once I parsed JSP by looking at it as java file, and placing "out.print( ... )" instead of the content between %> and <% . Plus special handling for the <%@. Didn't cover 100 % but worked for my case. Now I would probably use the Tomcat's JSP to servlet source processor and parse that. WDYT? It would loose the context though. > but I think in Windup 1 this fell down around <% %> / embedded code. Thoughts? > > Brad Davis > Senior Manager, Red Hat Consulting > Email: bdavis at redhat.com | c: 980.226.7865 | http://www.redhat.com > > > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev _______________________________________________ windup-dev mailing list windup-dev at lists.jboss.org https://lists.jboss.org/mailman/listinfo/windup-dev From jsightle at redhat.com Mon Sep 14 15:36:39 2015 From: jsightle at redhat.com (Jess Sightler) Date: Mon, 14 Sep 2015 15:36:39 -0400 Subject: [windup-dev] JSP / JSP / Taglib Parsing & Rules In-Reply-To: <1604113205.27096369.1442252428903.JavaMail.zimbra@redhat.com> References: <354412503.22503923.1441248314817.JavaMail.zimbra@redhat.com> <55F70585.8060800@redhat.com> <1604113205.27096369.1442252428903.JavaMail.zimbra@redhat.com> Message-ID: <55F721C7.7040909@redhat.com> I suspect that it would be possible to use something like Jaxen[1] to provide an XPath API here if we have a good JSP parser. I think that is the approach that PMD takes for parsing Java. Although if we can convert them to .java code that would be even better. It would be nice not to have separate analysis paths for them. [1] http://jaxen.org/ On 09/14/2015 01:40 PM, Brad Davis wrote: > The APIs for the Eclipse library have a DOM parser that basically extends standard DOM parsing to handle <% %> from what I could tell. > > Brad Davis > Senior Manager, Red Hat Consulting > Email: bdavis at redhat.com | c: 980.226.7865 | http://www.redhat.com > > > ----- Original Message ----- > From: "Ondrej Zizka" <ozizka at redhat.com> > To: windup-dev at lists.jboss.org > Sent: Monday, September 14, 2015 1:36:05 PM > Subject: Re: [windup-dev] JSP / JSP / Taglib Parsing & Rules > > > > On 3.9.2015 04:45, Brad Davis wrote: >> One of my projects leverages Richfaces 3 and we need to move to 4. It would be very helpful to expand upon the (basic) JSP rules that we had in Windup 0.7 with actual JSP parsing in Windup 2.4. Because we leverage Eclipse for AST with Java, I wonder if we can do the same thing for JSF / JSP? Maybe we can reach out to one of the project leads in the Eclipse community to get their recommendation on which project would provide similar functionality for those technologies. I think Nick Sandonato from the Eclipse WTP team may be a good starting point. >> >> There is a migration guide at: https://developer.jboss.org/wiki/RichFaces33-4xMigrationGuideUnleashed >> >> I guess we could use old-fashioned XPath and probably get a lot of the way, > Probably not XPath, because JSP can be anything, like, <%if(fish){%> > <?)))>< <%}%> > Once I parsed JSP by looking at it as java file, and placing "out.print( > ... )" instead of the content between %> and <% . Plus special handling > for the <%@. Didn't cover 100 % but worked for my case. > > Now I would probably use the Tomcat's JSP to servlet source processor > and parse that. WDYT? It would loose the context though. > >> but I think in Windup 1 this fell down around <% %> / embedded code. Thoughts? >> >> Brad Davis >> Senior Manager, Red Hat Consulting >> Email: bdavis at redhat.com | c: 980.226.7865 | http://www.redhat.com >> >> >> _______________________________________________ >> windup-dev mailing list >> windup-dev at lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/windup-dev > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev > > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev From zizka at seznam.cz Wed Sep 16 00:44:28 2015 From: zizka at seznam.cz (=?UTF-8?B?SW5nLiBPbmTFmWVqIMW9acW+a2E=?=) Date: Wed, 16 Sep 2015 06:44:28 +0200 Subject: [windup-dev] Escaping in templates - <#escape x as x?html> Message-ID: <55F8F3AC.7080706@seznam.cz> I think we should add <#escape x as x?html> to all templates - unless there's a reason not to. Is there? This directive makes all ${...}'s HTML-escaped. Regards, Ondra From ozizka at redhat.com Wed Sep 16 19:38:29 2015 From: ozizka at redhat.com (Ondrej Zizka) Date: Thu, 17 Sep 2015 01:38:29 +0200 Subject: [windup-dev] Escaping in templates - <#escape x as x?html> In-Reply-To: <55F8F3AC.7080706@seznam.cz> References: <55F8F3AC.7080706@seznam.cz> Message-ID: <55F9FD75.9090808@redhat.com> Some of the values contain HTML, like, for instance, the titles. We are inconsistent in certain places what should the value be. I suggest that we add that to the javadoc where appropriate, add the <#escape ...>, and add <#noescape> where needed. That's IMO better than adding ?html everywhere. Ondra On 16.9.2015 06:44, Ing. Ond?ej ?i?ka wrote: > I think we should add <#escape x as x?html> to all templates - unless > there's a reason not to. Is there? > > This directive makes all ${...}'s HTML-escaped. > > Regards, > Ondra > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev From rruss at redhat.com Thu Sep 17 13:28:59 2015 From: rruss at redhat.com (Rodney Russ) Date: Thu, 17 Sep 2015 11:28:59 -0600 Subject: [windup-dev] Escaping in templates - <#escape x as x?html> In-Reply-To: <55F9FD75.9090808@redhat.com> References: <55F8F3AC.7080706@seznam.cz> <55F9FD75.9090808@redhat.com> Message-ID: <E84A81E5-0AB0-4EF7-A33E-56FAFCD4D9F6@redhat.com> I like the summary you provided in our stand-up, Ondrej. Do you have that documented somewhere to use for this discussion? On 16 Sep 2015, at 17:38, Ondrej Zizka wrote: > Some of the values contain HTML, like, for instance, the titles. > > We are inconsistent in certain places what should the value be. > > I suggest that we add that to the javadoc where appropriate, add the > <#escape ...>, and add <#noescape> where needed. That's IMO better > than > adding ?html everywhere. > > Ondra > > > On 16.9.2015 06:44, Ing. Ond?ej ?i?ka wrote: >> I think we should add <#escape x as x?html> to all templates - unless >> there's a reason not to. Is there? >> >> This directive makes all ${...}'s HTML-escaped. >> >> Regards, >> Ondra >> _______________________________________________ >> windup-dev mailing list >> windup-dev at lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/windup-dev > > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev From jsightle at redhat.com Thu Sep 17 13:54:04 2015 From: jsightle at redhat.com (Jess Sightler) Date: Thu, 17 Sep 2015 13:54:04 -0400 Subject: [windup-dev] Escaping in templates - <#escape x as x?html> In-Reply-To: <55F9FD75.9090808@redhat.com> References: <55F8F3AC.7080706@seznam.cz> <55F9FD75.9090808@redhat.com> Message-ID: <55FAFE3C.8080005@redhat.com> I don't think the titles actually have HTML. As far as I know, the only present place that does is the hint body. On 09/16/2015 07:38 PM, Ondrej Zizka wrote: > Some of the values contain HTML, like, for instance, the titles. > > We are inconsistent in certain places what should the value be. > > I suggest that we add that to the javadoc where appropriate, add the > <#escape ...>, and add <#noescape> where needed. That's IMO better than > adding ?html everywhere. > > Ondra > > > On 16.9.2015 06:44, Ing. Ond?ej ?i?ka wrote: >> I think we should add <#escape x as x?html> to all templates - unless >> there's a reason not to. Is there? >> >> This directive makes all ${...}'s HTML-escaped. >> >> Regards, >> Ondra >> _______________________________________________ >> windup-dev mailing list >> windup-dev at lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/windup-dev > _______________________________________________ > windup-dev mailing list > windup-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/windup-dev From mnovotny at redhat.com Fri Sep 25 02:46:09 2015 From: mnovotny at redhat.com (Marek Novotny) Date: Fri, 25 Sep 2015 08:46:09 +0200 Subject: [windup-dev] quickstarts In-Reply-To: <DDFC9BB6-EDE4-40AB-9A1F-CF4B9293DF60@redhat.com> References: <BC556A46-5F45-44D4-B34E-E68F3D41570D@redhat.com> <5603AC9C.3090803@redhat.com> <5603B9D2.5070404@redhat.com> <85ED29B4-69DB-40B1-AA1F-B40828444B81@redhat.com> <56041AD0.302@redhat.com> <DDFC9BB6-EDE4-40AB-9A1F-CF4B9293DF60@redhat.com> Message-ID: <5604EDB1.4030304@redhat.com> Right, I prefer to keep them updated and released as they are probably the simplest form how to look at basic examples of Java or XML Rules. And Windup documentation references them for this purpose I guess, so we would lost a simpler target to point to. On 24.9.2015 18:09, Rodney Russ wrote: > Well, they look like they at least have use based on the documentation > (e.g. simple examples to look at), but I thought it was at least worth > the question. > > > On 24 Sep 2015, at 9:46, Jess Sightler wrote: > >> I have often wondered if we have anyone using them. I don't know, >> though. I know that we never seem to hear questions about them. >> >> On 09/24/2015 08:10 AM, Rodney Russ wrote: >>> Thanks, Marek. I asked as they were referenced in the docs and I >>> wanted to be sure they were up to date if this was going to be the case. >>> >>> As a side note, does anyone think they aren't needed or aren't useful >>> (i.e. should we stop maintaining and referencing them)? >>> >>> >>> On 24 Sep 2015, at 2:52, Marek Novotny wrote: >>> >>>> On 24.9.2015 09:56, Marek Novotny wrote: >>>>> >>>>> On 24.9.2015 01:48, Rodney Russ wrote: >>>>>> Have these been tested/looked at for 2.4.0.CR1? >>>>>> >>>>>> https://github.com/windup/windup-quickstarts >>>>>> >>>>> >>>>> I don't think as they are still pointing to windup 2.3.0.Final >>>>> (https://github.com/windup/windup-quickstarts/blob/master/pom.xml#L7) >>>>> >>>> >>>> I created https://issues.jboss.org/browse/WINDUP-776 as I looked at XML >>>> rules and they need to be updated too. >>>> >>>> -- >>>> Marek Novotny >>>> -- >>>> Windup team member and Seam Project Lead >>>> >>>> Red Hat Czech s.r.o. >>>> Purkynova 99 >>>> 612 45 Brno -- Marek Novotny -- Windup team member and Seam Project Lead Red Hat Czech s.r.o. Purkynova 99 612 45 Brno From ozizka at redhat.com Wed Sep 30 10:01:18 2015 From: ozizka at redhat.com (Ondrej Zizka) Date: Wed, 30 Sep 2015 16:01:18 +0200 Subject: [windup-dev] EAP6-EAP7 migration In-Reply-To: <E9F6C323-C658-47B8-ABDE-47EA488DF09A@redhat.com> References: <150033025.16264940.1441114916320.JavaMail.zimbra@redhat.com> <55E71926.7000707@redhat.com> <DC7F141C-D1C0-48EE-B02C-7E8631133D41@redhat.com> <55F0DEF9.8040602@redhat.com> <E9F6C323-C658-47B8-ABDE-47EA488DF09A@redhat.com> Message-ID: <560BEB2E.6080602@redhat.com> Hi, I didn't notice your reply earlier. I don't mean the :migrate ops in particular. I mean CLI in general. That is, instead of changing the target server's standalone.xml, we would do the changes over CLI. Individual steps for individual resources. Not just calling :migrate. You wrote we need to cover XML server configs. I guess you mean the source server's XML files. So we could read these into the graph, and then generate (and perform) a CLI script which would set them up. The problem with XSLT is not complexity, but rather namespaces. XSLT 1.0 is quite poor with namespaces. And if mixed with including the .xsl files in other .xsl, it's highly error prone. Ondra On 10.9.2015 12:42, Eduardo Martins wrote: >> On 10 Sep 2015, at 02:38, Ondrej Zizka <ozizka at redhat.com> wrote: >> >> Eduardo, >> >> is it possible to do a system call (instead of direct API usage) to run a generated CLI script and let AS deal with it? >> Or a system call to boot the controller, and then use the REST API? >> > Suppose you could do that, and the development of such functionalities would be less effort than developing the rules to handle the migration of 3 subsystems, then before you could invoke :migrate you would still need to parse and transform the old subsystem XML into management ops, i.e. need all EAP subsystem parsers. And you would also need to somehow transform the :migrate result into high level Windup report entries (targeting the source of migration, the XML). > > If you are trying yo avoid the XML rules with XSLT, due to XSLT complexity, an alternative would be Non XML Windup rules using a generic XML API, integrating the code logic of :migrate ops, which is short and not very complex. IMHO much less effort than what you propose above. > >> The reason for that is, that AFAIR, fiddling with standalone.xml was officially deprecated way of configuring EAP, and the recommended, forward compatible way, was officially CLI commands. >> Is that still the case? >> > Recommended != mandatory, we certainly need to cover the migration of XML server configs, it?s the basic EAP config process, and is supported by Red Hat. > > ?E