[hibernate-commits] [hibernate/hibernate-orm] d3978a: Fix various issues with @ElementCollection

Branch: refs/heads/wip/6.0 Home: https://github.com/hibernate/hibernate-orm Commit: d3978a0871178067cdde9bb9b234307ea259da1a https://github.com/hibernate/hibernate-orm/commit/d3978a0871178067cdde9bb... Author: Andrea Boriero <andrea(a)hibernate.org&gt; Date: 2020-07-30 (Thu, 30 Jul 2020) Changed paths: M hibernate-core/src/main/java/org/hibernate/cfg/annotations/BasicValueBinder.java M hibernate-core/src/main/java/org/hibernate/collection/internal/StandardCollectionSemanticsResolver.java M hibernate-core/src/main/java/org/hibernate/mapping/BasicValue.java M hibernate-core/src/main/java/org/hibernate/metamodel/mapping/internal/BasicValuedCollectionPart.java M hibernate-core/src/main/java/org/hibernate/metamodel/mapping/internal/EmbeddedCollectionPart.java M hibernate-core/src/main/java/org/hibernate/metamodel/mapping/internal/PluralAttributeMappingImpl.java M hibernate-core/src/main/java/org/hibernate/metamodel/mapping/internal/ToOneAttributeMapping.java M hibernate-core/src/main/java/org/hibernate/metamodel/mapping/ordering/OrderByFragment.java A hibernate-core/src/main/java/org/hibernate/metamodel/mapping/ordering/OrderByFragmentImpl.java M hibernate-core/src/main/java/org/hibernate/metamodel/mapping/ordering/OrderByFragmentTranslator.java M hibernate-core/src/main/java/org/hibernate/metamodel/mapping/ordering/ast/DomainPathContinuation.java M hibernate-core/src/main/java/org/hibernate/metamodel/mapping/ordering/ast/ParseTreeVisitor.java M hibernate-core/src/main/java/org/hibernate/sql/ast/spi/AbstractSqlAstWalker.java M hibernate-core/src/main/java/org/hibernate/sql/results/graph/embeddable/AbstractEmbeddableInitializer.java M hibernate-core/src/main/java/org/hibernate/sql/results/graph/embeddable/internal/EmbeddableFetchInitializer.java A hibernate-core/src/test/java/org/hibernate/orm/test/annotations/collectionelement/Boy.java A hibernate-core/src/test/java/org/hibernate/orm/test/annotations/collectionelement/Brand.java A hibernate-core/src/test/java/org/hibernate/orm/test/annotations/collectionelement/Bug.java A hibernate-core/src/test/java/org/hibernate/orm/test/annotations/collectionelement/BugSystem.java A hibernate-core/src/test/java/org/hibernate/orm/test/annotations/collectionelement/Character.java A hibernate-core/src/test/java/org/hibernate/orm/test/annotations/collectionelement/CountryAttitude.java A hibernate-core/src/test/java/org/hibernate/orm/test/annotations/collectionelement/CustomImprovedNamingCollectionElementTest.java A hibernate-core/src/test/java/org/hibernate/orm/test/annotations/collectionelement/DefaultNamingCollectionElementTest.java A hibernate-core/src/test/java/org/hibernate/orm/test/annotations/collectionelement/EmbeddableCollectionElementWithLazyManyToOneTest.java A hibernate-core/src/test/java/org/hibernate/orm/test/annotations/collectionelement/EntityWithAnElementCollection.java A hibernate-core/src/test/java/org/hibernate/orm/test/annotations/collectionelement/FavoriteFood.java A hibernate-core/src/test/java/org/hibernate/orm/test/annotations/collectionelement/ImprovedNamingCollectionElementTest.java A hibernate-core/src/test/java/org/hibernate/orm/test/annotations/collectionelement/LocalizedString.java A hibernate-core/src/test/java/org/hibernate/orm/test/annotations/collectionelement/Matrix.java A hibernate-core/src/test/java/org/hibernate/orm/test/annotations/collectionelement/MyImprovedNamingStrategy.java A hibernate-core/src/test/java/org/hibernate/orm/test/annotations/collectionelement/OrderByTest.java A hibernate-core/src/test/java/org/hibernate/orm/test/annotations/collectionelement/Owner.java A hibernate-core/src/test/java/org/hibernate/orm/test/annotations/collectionelement/Person.java A hibernate-core/src/test/java/org/hibernate/orm/test/annotations/collectionelement/PrimitiveArrayElementCollectionTempTest.java A hibernate-core/src/test/java/org/hibernate/orm/test/annotations/collectionelement/Products.java A hibernate-core/src/test/java/org/hibernate/orm/test/annotations/collectionelement/QueryTest.java A hibernate-core/src/test/java/org/hibernate/orm/test/annotations/collectionelement/TestCourse.java A hibernate-core/src/test/java/org/hibernate/orm/test/annotations/collectionelement/Toy.java A hibernate-core/src/test/java/org/hibernate/orm/test/annotations/collectionelement/Widgets.java A hibernate-core/src/test/java/org/hibernate/orm/test/annotations/collectionelement/deepcollectionelements/A.java A hibernate-core/src/test/java/org/hibernate/orm/test/annotations/collectionelement/deepcollectionelements/B.java A hibernate-core/src/test/java/org/hibernate/orm/test/annotations/collectionelement/deepcollectionelements/C.java A hibernate-core/src/test/java/org/hibernate/orm/test/annotations/collectionelement/deepcollectionelements/DeepCollectionElementTest.java A hibernate-core/src/test/java/org/hibernate/orm/test/annotations/collectionelement/embeddables/withcustomenumdef/Location.java A hibernate-core/src/test/java/org/hibernate/orm/test/annotations/collectionelement/embeddables/withcustomenumdef/Query.java A hibernate-core/src/test/java/org/hibernate/orm/test/annotations/collectionelement/embeddables/withcustomenumdef/TestBasicOps.java A hibernate-core/src/test/java/org/hibernate/orm/test/annotations/collectionelement/indexedCollection/Contact.java A hibernate-core/src/test/java/org/hibernate/orm/test/annotations/collectionelement/indexedCollection/IndexedCollectionOfElementsTest.java A hibernate-core/src/test/java/org/hibernate/orm/test/annotations/collectionelement/indexedCollection/Sale.java A hibernate-core/src/test/java/org/hibernate/orm/test/annotations/collectionelement/ordered/Address.java A hibernate-core/src/test/java/org/hibernate/orm/test/annotations/collectionelement/ordered/ElementCollectionSortingTest.java A hibernate-core/src/test/java/org/hibernate/orm/test/annotations/collectionelement/ordered/Person.java A hibernate-core/src/test/java/org/hibernate/orm/test/annotations/collectionelement/recreate/Poi.java A hibernate-core/src/test/java/org/hibernate/orm/test/annotations/collectionelement/recreate/PoiArrival.java A hibernate-core/src/test/java/org/hibernate/orm/test/annotations/collectionelement/recreate/RaceExecution.java A hibernate-core/src/test/java/org/hibernate/orm/test/annotations/collectionelement/recreate/RecreateCollectionTest.java R hibernate-core/src/test/java/org/hibernate/test/annotations/collectionelement/Boy.java R hibernate-core/src/test/java/org/hibernate/test/annotations/collectionelement/Brand.java R hibernate-core/src/test/java/org/hibernate/test/annotations/collectionelement/Bug.java R hibernate-core/src/test/java/org/hibernate/test/annotations/collectionelement/BugSystem.java R hibernate-core/src/test/java/org/hibernate/test/annotations/collectionelement/Character.java R hibernate-core/src/test/java/org/hibernate/test/annotations/collectionelement/CountryAttitude.java R hibernate-core/src/test/java/org/hibernate/test/annotations/collectionelement/CustomImprovedNamingCollectionElementTest.java R hibernate-core/src/test/java/org/hibernate/test/annotations/collectionelement/DefaultNamingCollectionElementTest.java R hibernate-core/src/test/java/org/hibernate/test/annotations/collectionelement/EmbeddableCollectionElementWithLazyManyToOneTest.java R hibernate-core/src/test/java/org/hibernate/test/annotations/collectionelement/EntityWithAnElementCollection.java R hibernate-core/src/test/java/org/hibernate/test/annotations/collectionelement/FavoriteFood.java R hibernate-core/src/test/java/org/hibernate/test/annotations/collectionelement/ImprovedNamingCollectionElementTest.java R hibernate-core/src/test/java/org/hibernate/test/annotations/collectionelement/LocalizedString.java R hibernate-core/src/test/java/org/hibernate/test/annotations/collectionelement/Matrix.java R hibernate-core/src/test/java/org/hibernate/test/annotations/collectionelement/OrderByTest.java R hibernate-core/src/test/java/org/hibernate/test/annotations/collectionelement/Owner.java R hibernate-core/src/test/java/org/hibernate/test/annotations/collectionelement/Person.java R hibernate-core/src/test/java/org/hibernate/test/annotations/collectionelement/Products.java R hibernate-core/src/test/java/org/hibernate/test/annotations/collectionelement/QueryTest.java R hibernate-core/src/test/java/org/hibernate/test/annotations/collectionelement/TestCourse.java R hibernate-core/src/test/java/org/hibernate/test/annotations/collectionelement/Toy.java R hibernate-core/src/test/java/org/hibernate/test/annotations/collectionelement/Widgets.java R hibernate-core/src/test/java/org/hibernate/test/annotations/collectionelement/deepcollectionelements/A.java R hibernate-core/src/test/java/org/hibernate/test/annotations/collectionelement/deepcollectionelements/B.java R hibernate-core/src/test/java/org/hibernate/test/annotations/collectionelement/deepcollectionelements/C.java R hibernate-core/src/test/java/org/hibernate/test/annotations/collectionelement/deepcollectionelements/DeepCollectionElementTest.java R hibernate-core/src/test/java/org/hibernate/test/annotations/collectionelement/embeddables/withcustomenumdef/Location.java R hibernate-core/src/test/java/org/hibernate/test/annotations/collectionelement/embeddables/withcustomenumdef/Query.java R hibernate-core/src/test/java/org/hibernate/test/annotations/collectionelement/embeddables/withcustomenumdef/TestBasicOps.java R hibernate-core/src/test/java/org/hibernate/test/annotations/collectionelement/indexedCollection/Contact.java R hibernate-core/src/test/java/org/hibernate/test/annotations/collectionelement/indexedCollection/IndexedCollectionOfElementsTest.java R hibernate-core/src/test/java/org/hibernate/test/annotations/collectionelement/indexedCollection/Sale.java R hibernate-core/src/test/java/org/hibernate/test/annotations/collectionelement/ordered/Address.java R hibernate-core/src/test/java/org/hibernate/test/annotations/collectionelement/ordered/ElementCollectionSortingTest.java R hibernate-core/src/test/java/org/hibernate/test/annotations/collectionelement/ordered/Person.java R hibernate-core/src/test/java/org/hibernate/test/annotations/collectionelement/recreate/Poi.java R hibernate-core/src/test/java/org/hibernate/test/annotations/collectionelement/recreate/PoiArrival.java R hibernate-core/src/test/java/org/hibernate/test/annotations/collectionelement/recreate/RaceExecution.java R hibernate-core/src/test/java/org/hibernate/test/annotations/collectionelement/recreate/RecreateCollectionTest.java Log Message: ----------- Fix various issues with @ElementCollection Commit: b26b397d5956c3ca8f548efb6f12645118918eca https://github.com/hibernate/hibernate-orm/commit/b26b397d5956c3ca8f548ef... Author: Andrea Boriero <andrea(a)hibernate.org&gt; Date: 2020-07-30 (Thu, 30 Jul 2020) Changed paths: M hibernate-core/src/main/java/org/hibernate/metamodel/mapping/EmbeddableValuedModelPart.java M hibernate-core/src/main/java/org/hibernate/metamodel/mapping/internal/EmbeddedAttributeMapping.java M hibernate-core/src/main/java/org/hibernate/metamodel/mapping/internal/EmbeddedCollectionPart.java M hibernate-core/src/main/java/org/hibernate/metamodel/mapping/internal/MappingModelCreationHelper.java M hibernate-core/src/main/java/org/hibernate/sql/results/graph/embeddable/AbstractEmbeddableInitializer.java M hibernate-core/src/test/java/org/hibernate/orm/test/bootstrap/binding/annotations/embedded/EmbeddedTest.java Log Message: ----------- Implemented @Parent Commit: b9612247f5eeaaff8bfc3fb8d92466e35d89b9b0 https://github.com/hibernate/hibernate-orm/commit/b9612247f5eeaaff8bfc3fb... Author: Andrea Boriero <andrea(a)hibernate.org&gt; Date: 2020-07-30 (Thu, 30 Jul 2020) Changed paths: M hibernate-core/src/main/java/org/hibernate/metamodel/mapping/internal/PluralAttributeMappingImpl.java Log Message: ----------- Fix PluralAttributeMapping#findSubpart for elementDescriptor instanceof EmbeddedCollectionPart Commit: 8db97094082e7d20303408e3d9ecb6a0ab02ca1d https://github.com/hibernate/hibernate-orm/commit/8db97094082e7d20303408e... Author: Andrea Boriero <andrea(a)hibernate.org&gt; Date: 2020-07-30 (Thu, 30 Jul 2020) Changed paths: M hibernate-core/src/main/java/org/hibernate/metamodel/internal/AbstractCompositeIdentifierMapping.java M hibernate-core/src/main/java/org/hibernate/metamodel/mapping/internal/EntityCollectionPart.java M hibernate-core/src/main/java/org/hibernate/metamodel/mapping/ordering/ast/ColumnReference.java M hibernate-core/src/main/java/org/hibernate/metamodel/mapping/ordering/ast/PluralAttributePath.java M hibernate-core/src/main/java/org/hibernate/persister/entity/AbstractEntityPersister.java M hibernate-core/src/main/java/org/hibernate/persister/entity/JoinedSubclassEntityPersister.java M hibernate-core/src/main/java/org/hibernate/sql/results/graph/embeddable/AbstractEmbeddableInitializer.java M hibernate-core/src/test/java/org/hibernate/orm/test/annotations/collectionelement/DefaultNamingCollectionElementTest.java A hibernate-core/src/test/java/org/hibernate/orm/test/annotations/collectionelement/OrderByColumnNameTest.java M hibernate-core/src/test/java/org/hibernate/orm/test/annotations/collectionelement/OrderByTest.java M hibernate-core/src/test/java/org/hibernate/orm/test/annotations/collectionelement/Products.java M hibernate-core/src/test/java/org/hibernate/orm/test/annotations/collectionelement/Widgets.java M hibernate-core/src/test/java/org/hibernate/orm/test/annotations/collectionelement/embeddables/withcustomenumdef/TestBasicOps.java Log Message: ----------- Fix @ElementCollection + @OrderBy with Inheritance Compare: https://github.com/hibernate/hibernate-orm/compare/d246a4b4602c...8db9709...