[aerogear-dev] iOS API overhaul - rename 'getter' for 'modules'

[Matthias Wessendorf]

On Thu, Dec 20, 2012 at 2:16 PM, Christos Vasilakis <cvasilak at gmail.com> wrote:
> Hi team,
>
> as part of the API overhaul ticket[1] for the next CR1 release, inside of the following classes we have a getter, to get an actual object by its name:
>         • AGPipeline
>         • AGDataManager
>         • AGAuthenticator
>
> Example
> - (id<AGAuthenticationModule>)get:(NSString *)moduleName
>
> In in the iOS land, a get* method by convention is used to fill the parameters of the method with a value, for example see [2] from apple documentation . What we propose is a rename of these methods,
> for example:


+1 on renaming ;-)


> - (id<AGAuthenticationModule>)moduleWithName:(NSString *)moduleName

I am not 100% sure, but that _could_ work for receiving an authModule.
(perhaps '-authModuleWithName:' ?)

For AGPipeline, how about:
-pipeWithName:

For AGDataManager, how about
-storeWithName:


-M


>
> What do you think?
>
> A ticket has been already opened for this change, see [3]
>
> Thanks,
> Christos
>
>
> [1] https://issues.jboss.org/browse/AEROGEAR-763
> [2] https://developer.apple.com/library/mac/documentation/Cocoa/Reference/ApplicationKit/Classes/NSColor_Class/Reference/Reference.html#//apple_ref/occ/instm/NSColor/getCyan:magenta:yellow:black:alpha:
> [3] https://issues.jboss.org/browse/AEROGEAR-767
>
>
> _______________________________________________
> aerogear-dev mailing list
> aerogear-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/aerogear-dev



-- 
Matthias Wessendorf

blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf