[aerogear-dev] Android Guides

[Christos Vasilakis]

nice guides!

some small comments:

In AerogearAndroidPipes101.asciidoc
	
- Android’s Loader API  --> a link to the official android doc:  http://developer.android.com/guide/components/loaders.html
	
- On the paragraph describing the Loader API I think it's good to append the added benefit AeroGear provides to the loader API e.g.
"AeroGear transparently handles the registration and attaching of the callback in the Loader mechanism,  without the user having to explicitly declare it"…or sth similar.

---
In AerogearAndroidPagination.asciidoc

- new PageConsumer()) ? ->  did you mean "new SamplePageResultExtractor()"

- typos and comma:  ...special requirements or legacy services, AeroGear's pagination framework can be easily extended to support them.

---

In AerogearAndroidDataStore.asciidoc

- Creating a Memory Store
 .....Also it can not perform nested querying of its data. -> Note that currently, it doesn't support nested querying of its data.

- Creating a SQLStore
  not sure if nested querying is supported,
      if it does -> Unlike MemoryStore, the SQLStore supports nested query of its data.
      if not -> Similar to MemoryStore, the SQLStore doesn't support nested query of its data.

- typo: can conly filter -> can only filter

In AerogearAndroidAuthentication.asciidoc

- typo: encapuslates -> encapsulates, instanciate -> instantiate

In AerogearAndroidCustomizingPipes.asciidoc

- ...managing PipeHandler instances and returning their results and returning them to the user via callbacks.. -> 
  ...managing PipeHandler instances, processing their results and returning them to the user via callbacks..

-  thustly?


Thanks
Christos


On Mar 20, 2013, at 10:44 AM, Matthias Wessendorf <matzew at apache.org> wrote:

> Howdy,
> 
> great to see some docs/guides
> 
> Here are my first/initial comments:
> 
> 1) Group them into a subfolder, like daniel did, for the controller
> 
> 2) links to the matching JavaDocs (classes (e.g. PipeHandlert etc)) does not hurt
> 
> 3) not sure about if the `AerogearAndroidCustomizingPipes.asciidoc` is really useful ...
> 
> "AerogearAndroidPagination"
> 4) You never show ParameterProvider...
> 5) what is config.setDataRoot()
> --> looks like the Android bits are a bit _different_, compared to the iOS/JS version 
> 6) do I really have to implement my own "PageResultExtractor" 
> 
> The Pagination feels: Lot's of code... for a simple read...
> 
> 
> 
> -Matthias
> 
> 
> On Tue, Mar 19, 2013 at 9:19 PM, Summers Pittman <supittma at redhat.com> wrote:
> I just committed some guides for using the Aerogear Android libraries.  
> 
> https://github.com/aerogear/aerogear.org/commit/d3cae265d
> 
> 
> I'm still editing them for gramma/spelling/formatting, so be warned (hence why I havn't PRed it yet).  Also, if there is anything I missed, glossed over, explained like crap let me know and I will try to reword it when I begin proofreading.
> 
> Summers
> 
> _______________________________________________
> aerogear-dev mailing list
> aerogear-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/aerogear-dev
> 
> 
> 
> -- 
> Matthias Wessendorf 
> 
> blog: http://matthiaswessendorf.wordpress.com/
> sessions: http://www.slideshare.net/mwessendorf
> twitter: http://twitter.com/mwessendorf
> _______________________________________________
> aerogear-dev mailing list
> aerogear-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/aerogear-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/aerogear-dev/attachments/20130320/08567052/attachment-0001.html