[forge-commits] [forge/addon-gradle] ddd10c: Fix GradleSourceUtil.insertTask()

Lincoln Baxter, III lincolnbaxter at gmail.com
Thu Aug 8 19:30:11 EDT 2013


Hey Adam, nice work on all this! Its looking great. One question. Is this
going to work on all operating systems?

https://github.com/forge/addon-gradle/compare/1e501ac1f3f7...d8a4cdd3b859#L7L30

You might want to ask george and Vineet about this because I think we have
a common way to handle OS path canonicalization.

Keep up the great work!

---
Lincoln Baxter's Droid
http://ocpsoft.org
"Keep it Simple"
On Aug 8, 2013 7:17 PM, "Adam Wyłuda" <adamwyl92 at gmail.com> wrote:

>   Branch: refs/heads/master
>   Home:   https://github.com/forge/addon-gradle
>   Commit: ddd10ce6bc84b9c219a593afc97a7cb728e046f8
>
> https://github.com/forge/addon-gradle/commit/ddd10ce6bc84b9c219a593afc97a7cb728e046f8
>   Author: Adam Wyłuda <adamwyl92 at gmail.com>
>   Date:   2013-08-08 (Thu, 08 Aug 2013)
>
>   Changed paths:
>     M
> impl/src/main/java/org/jboss/forge/addon/gradle/parser/GradleSourceUtil.java
>     M
> impl/src/test/java/org/jboss/forge/addon/gradle/parser/GradleSourceUtilTest.java
>     M
> tests/src/test/java/org/jboss/forge/addon/gradle/projects/GradleFacetTest.java
>
>   Log Message:
>   -----------
>   Fix GradleSourceUtil.insertTask()
>
>
>   Commit: 71587e673afa3e89650a39530f82875934d8e132
>
> https://github.com/forge/addon-gradle/commit/71587e673afa3e89650a39530f82875934d8e132
>   Author: Adam Wyłuda <adamwyl92 at gmail.com>
>   Date:   2013-08-08 (Thu, 08 Aug 2013)
>
>   Changed paths:
>     M
> impl-projects/src/main/java/org/jboss/forge/addon/gradle/projects/GradleFacetImpl.java
>     M
> impl/src/main/java/org/jboss/forge/addon/gradle/parser/GradleSourceUtil.java
>     M
> tests/src/test/java/org/jboss/forge/addon/gradle/projects/GradleTestProjectProvider.java
>     M tests/src/test/resources/build.gradle
>
>   Log Message:
>   -----------
>   Improve GradleFacet implementation and fix test (now passes all)
>
>
>   Commit: 24cd34bf40e4aaaa4a4bad42a5acf7edee8ba62f
>
> https://github.com/forge/addon-gradle/commit/24cd34bf40e4aaaa4a4bad42a5acf7edee8ba62f
>   Author: Adam Wyłuda <adamwyl92 at gmail.com>
>   Date:   2013-08-08 (Thu, 08 Aug 2013)
>
>   Changed paths:
>     M
> tests/src/test/java/org/jboss/forge/addon/gradle/projects/GradleTestProjectProvider.java
>     M
> tests/src/test/java/org/jboss/forge/addon/gradle/projects/ProjectAssert.java
>
>   Log Message:
>   -----------
>   Fix ProjectAssert
>
>
>   Commit: d8a4cdd3b859ef2e59c080da1a8739a2cc2c0a03
>
> https://github.com/forge/addon-gradle/commit/d8a4cdd3b859ef2e59c080da1a8739a2cc2c0a03
>   Author: Adam Wyłuda <adamwyl92 at gmail.com>
>   Date:   2013-08-08 (Thu, 08 Aug 2013)
>
>   Changed paths:
>     M
> impl-projects/src/main/java/org/jboss/forge/addon/gradle/projects/GradleProjectLocator.java
>     M
> impl-projects/src/main/java/org/jboss/forge/addon/gradle/projects/facets/GradleResourceFacet.java
>     M
> tests/src/test/java/org/jboss/forge/addon/gradle/projects/facets/GradleResourceFacetTest.java
>
>   Log Message:
>   -----------
>   Implement GradleResourceFacet
>
>
> Compare:
> https://github.com/forge/addon-gradle/compare/1e501ac1f3f7...d8a4cdd3b859
>
> _______________________________________________
> forge-commits mailing list
> forge-commits at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/forge-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/forge-commits/attachments/20130808/e76aeb31/attachment-0001.html 


More information about the forge-commits mailing list