[Hawkular-dev] Tag concept in metrics and alerts

[Gary Brown]

Hi Jay

Thats fine, better to get consensus, as we don't want to have to rename again in the future :)

Another alternative that I'd like to suggest, based on your mention of the optional category, is to actually use Category, as it seems like that is how it is used (i.e. to categorize alerts) ?

Regards
Gary

----- Original Message -----
> 
> 
> On 6/24/2015 11:35 AM, Thomas Heute wrote:
> >
> > On 06/24/2015 04:54 PM, Gary Brown wrote:
> >>
> >> ----- Original Message -----
> >>>
> >>> On 6/24/2015 9:13 AM, Gary Brown wrote:
> >>>> ----- Original Message -----
> >>>>> In alert context, the incoming data should match
> >>>>> org.hawkular.alerts.api.model.data
> >>>>> https://github.com/hawkular/hawkular-alerts/tree/master/hawkular-alerts-api/src/main/java/org/hawkular/alerts/api/model/data
> >>>>> These data is carried and stored in the evaluation details for an
> >>>>> alert. But "Tag" in alerts is used as a way to put "alias" on
> >>>>> definitions but is not related to specific incoming data.
> >>>> Sorry when I referred to 'tag', I meant the tag in the metrics event,
> >>>> which
> >>>> is a map of name/value pairs.
> >>>>
> >>>> So when the alerts engine is analysing a metric, is the tag information
> >>>> on
> >>>> the metric stored in the alert's condition evaluation data?
> >>> As you mentioned earlier, Tags are labels that can be attached ad-hoc to
> >>> Trigger definitions.  They can then be used to filter queries, like,
> >>> "give me all of the unresolved alerts for triggers labeled XYZ".  That
> >>> mechanism is for use by the clients, to be used in their own way.
> >> Yes, this is where the use of 'tag' in alerts and metrics differs, so
> >> might be good if Tag in Alerts could be renamed Label.
> > Do we need 1 word labelling at all or key/value pairs only ?
> >
> > (BTW to make it more confusing OpenShift/Kubernetes use the term label
> > for key=value things)
> >
> > Thomas
> 
> I don't really want to rename Tag to Label unless it's really confusing
> people.  Or until we have complete concensus over the terminology and
> semantics.  As it stands, ALerts'  tags are not 1 word labels, but
> actually allow for qualifying 'category', as well as  the 'name'.
> 
> 
> 
> _______________________________________________
> hawkular-dev mailing list
> hawkular-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hawkular-dev
>