[Hawkular-dev] relaxing checkstyle on java comment lines

[Jay Shaughnessy]

Hi Jiri,

I was unaware of that PR, sorry.  I see now there has been previous 
debate on this topic.  My config changes also dealt with block comments 
and trailing spaces.  I suppose I should commit to the existing PR 
branch.  The -Dcheckstyle.skip is fine, I use that along with 
license.skip, just to speed things up while developing.  But it's not 
the same as changing the policy we have in place.  I'd argue that 
comments should not be subject to line length or trailing whitespace 
constraints, and that is why I made the change.  We can keep things as 
is, but if no one really cares I'd rather the change go in.

On 5/19/2015 3:28 AM, Jiri Kremser wrote:
> Hi,
>    the change is basically the same as this PR https://github.com/hawkular/hawkular-build-tools/pull/10
> I can re-open it, however, I am pretty fine with using -Dcheckstyle.skip all the time and do the dirty work only once before the commit.
>
> jk
>
> ----- Original Message -----
> | From: "Jay Shaughnessy" <jshaughn at redhat.com>
> | To: hawkular-dev at lists.jboss.org
> | Sent: Monday, 18 May, 2015 11:20:24 PM
> | Subject: [Hawkular-dev] relaxing checkstyle on java comment lines
> |
> |
> | I was getting really tired of checkstyle complaining about line-too-long and
> | trailing spaces for Java comment lines. I altered the config file (attached)
> | to be more flexible. But I don't have perms to create a PR against
> | hawkular-build-tools.
> |
> | If you'd like to see this changed maybe chime in and the powers that be will
> | apply the change.
> |
> | _______________________________________________
> | hawkular-dev mailing list
> | hawkular-dev at lists.jboss.org
> | https://lists.jboss.org/mailman/listinfo/hawkular-dev
> |
> _______________________________________________
> hawkular-dev mailing list
> hawkular-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hawkular-dev
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/hawkular-dev/attachments/20150519/5eeb58e3/attachment.html