[Hawkular-dev] [process] tickets and PRs

Juraci Paixão Kröhling jpkroehling at redhat.com
Thu May 28 07:35:50 EDT 2015


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 05/28/2015 12:50 PM, Lukas Krejci wrote:
> -1 on squashing all PRs (if that is what you meant).
> 
> IMHO squashes are a nice feature to get rid of "garbage" commits
> PRIOR to pushing those commits upstream but SHOULD NOT be used to
> modify any commits that exists also remotely.

I think that's what Lucas meant, and this is certainly what I meant
:-) To make it clear: I'm in favor of squashing the multiple commits
*for a single PR*. Once the single commit for the PR is merged into
master, there's no coming back.

- - Juca.


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJVZv2WAAoJECKM1e+fkPrXRs4H/itZ1k8L5GlOjBl7WRXrLQ/i
a6y8+TaPMgb/wQaRM/4GoQFNjKIdkQm9VOpPFxVwMa3WGLoZDxDCsbXl2FOdPtIY
sa38GA72ml58Jg+dJvxPu3/RSiZdtSJluBmsWmlAP4tIk+WrDwe8HIstvdtoGj0j
ODa5aQnkxKGvbYidJSIzOnJn/ZBI+wLSy5ERc6Lx3apvadZrGLxCLdiCgwt1kvbH
BkSlxytw4oVjzMsedE9Zk6D71PLRoTW5TZN5TlcKRNTL6Sehxx3HuYBkPOJ0zOga
3gmdtXipvrd9rOuqIgP5r4iFyTfhunNsH9NLBNvDju+R378MtUAIrccMtElVr1Y=
=MC5+
-----END PGP SIGNATURE-----


More information about the hawkular-dev mailing list