[Hawkular-dev] Request for PR review - build-tools - https://github.com/hawkular/hawkular-build-tools/pull/25

Gary Brown gbrown at redhat.com
Wed Jun 22 12:17:46 EDT 2016


Hi Lukas

I ran the script locally (rather than pulling in via the build tools plugin), and mostly it seemed fine, although I had one strange situation with the InteractionNode data type, which has two fields both of type Message - however in the adoc they are listed with type 'null'.

I've attached the files.

Otherwise it looks good to me - and something APM definitely needs :)

Regards
Gary

----- Original Message -----
> Hi all,
> 
> I've made some adjustments to our swagger -> asciidoc script so that it is
> able to emit information about inheritance of the data definitions.
> 
> I'd like to use this for the next Inventory release, because the REST docs
> are
> border-line useless without it.
> 
> I made biiig updates to the REST docs for the new inventory REST API and
> would
> like to have it in shape before the imminent release of it.
> 
> Therefore I humbly ask for review of the above mentioned PR so that we can
> release new build-tools and parent that I could then consume in inventory for
> the new release.
> 
> Thanks,
> 
> --
> Lukas Krejci
> _______________________________________________
> hawkular-dev mailing list
> hawkular-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hawkular-dev
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: swagger.json
Type: application/json
Size: 78356 bytes
Desc: not available
Url : http://lists.jboss.org/pipermail/hawkular-dev/attachments/20160622/f30843b6/attachment-0001.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rest-apm.adoc
Type: application/octet-stream
Size: 52469 bytes
Desc: not available
Url : http://lists.jboss.org/pipermail/hawkular-dev/attachments/20160622/f30843b6/attachment-0001.obj 


More information about the hawkular-dev mailing list