[hibernate-dev] SchemaCreatorImpl always creating a poolable sequence

[Steve Ebersole]

I do think this is an error.  I think the proper fix is to first make use
of Exporter<Sequence>#getSqlCreateStrings via Dialect#getSequenceExporter.

>From there, either:

   1. Change the standard Exporter<Sequence> to look at
   Dialect#supportsPooledSequences and deciding which
   Dialect#getCreateSequenceStrings form to call
   2. Change Firebird's Exporter<Sequence> impl

I'd also suggest we properly deprecate Dialect#supportsPooledSequences,
Dialect#getCreateSequenceStrings directing to Dialect#getSequenceExporter.


On Thu, Jul 28, 2016 at 6:15 AM Mark Rotteveel <mark at lawinegevaar.nl> wrote:

> On 28-7-2016 13:02, Vlad Mihalcea wrote:
> > Is it that you get the exception even if the incrementSize is 1? I guess
> > this is an issue that we need to open a Jira ticket for it.
>
> Yes, see the code in my initial email: SchemaCreatorImpl always tries to
> create a pooled sequence.
>
> Mark
> --
> Mark Rotteveel
> _______________________________________________
> hibernate-dev mailing list
> hibernate-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>