[hibernate-dev] Removing dom4j?

[Steve Ebersole]

Would we be interested?  Heck yeah.  We have just not put in the effort
because it is used for such a small subset of features *and* we plan to not
use DOM/SAX directly moving forward (we are transitioning to JAXB).

All that said though, I am surprised you ran into so few problems.  Envers
e.g. makes extensive use of DOM4J.

On Fri, Feb 16, 2018 at 4:29 PM Jordan Gigov <coladict at gmail.com> wrote:

> The woodstox dependency is incompatible with the rest of the XML API due to
> a bug in the JDK that is otherwise hidden in all cases in the default
> implementation.
>
> Specifically it's implementation of EndElement brings that bug to the
> forefront, when
> com.sun.org.apache.xalan.internal.xsltc.trax.StAXEvent2SAX.handleElementEnd
> tries to typecast a Namespace to String.
>
> In the default implementation, that Namespace iterator is always empty, so
> it never reaches that line.
>
> Though that does make me wonder why the Document after being read is
> scanned again as a DOMSource and then converted back to a Document object.
> Might be a better way to pass it on altogether. Makes me wish I had noticed
> the deprecation note on org.hibernate.boot.MetadataSources.addDocument(
> Document)
>
> On 16 February 2018 at 23:33, Sanne Grinovero <sanne at hibernate.org> wrote:
>
> > Hi Jordan,
> >
> > I think it would be great to remove it. Especially recently we've
> > started exploring what it would take to convert all jars into proper
> > Jigsaw modules, and a requirement is that all dependencies need to be
> > converted as well; this is obviously more problematic for such old
> > libraries so it would be best to remove it or find a good replacement.
> >
> > I'd suggest to work on the master branch though, we wouldn't want to
> > apply this on the 5.2 branch which is now in maintenance mode.
> >
> > What do you mean with "shiv-libraries" ?
> >
> > Thanks,
> > Sanne
> >
> >
> > On 16 February 2018 at 21:11, Jordan Gigov <coladict at gmail.com> wrote:
> > > So, the library has not seen a bugfix in over 10 years, and it lists
> the
> > > wrong version for it's xml-apis dependency.
> > > There are some notes in comments about eventually removing it, and I
> > > thought I'd give it a try on the 5.2 branch.
> > > I had to remove two shiv-libraries you had added to work around
> problems
> > > you probably encountered prior to JDK6.
> > >
> > > I've narrowed it down to 11 failing tests (5 distinct exceptions) when
> > > using the default XML APIs provided with JDK8.
> > >
> > > Is there any interest in this?
> > > _______________________________________________
> > > hibernate-dev mailing list
> > > hibernate-dev at lists.jboss.org
> > > https://lists.jboss.org/mailman/listinfo/hibernate-dev
> >
> _______________________________________________
> hibernate-dev mailing list
> hibernate-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>