[infinispan-dev] JBoss Logging upgrade breaking build

[Sanne Grinovero]

Hi Galder,
I agree this upgrade is being too painful, it shouldn't have been
integrated in this state. I'm preparing a rollback pull request, then
I'll create the issues on JBoss Logger/Tools. When these issues are
sorted out we can try again updating. It was good to use the new
version - even briefly - as the strict validation made me fix several
log messages.

The errors you see are thrown by a validation step in the annotation
processor, for some reason it doesn't like anymore the Logger
extensions we have in non-core modules: it's not just Query but any
module other than infinispan-core.

I also don't understand what's wrong in the Log implementations, I'm
inclined to think it's a bug in the validation step; if it's a new
requirement, that's annoying as we follow that same pattern for
logging inheritance in all Infinispan modules and all Hibernate
modules too.

I'm not agreeing on the auto-discovery of the annotation processors in
the IDE, but will rollback that too so that we can discuss that
properly first. FYI autodiscovery works fine in Eclipse even with the
patch included, although it requires a snapshot of Fred Bricon's work
on tooling; I would expect IDEA to provide a comparable feature.

BTW the original pull request looked like fine to me as I'm not having
TRACE logging enabled on view changes, where the log messages where
broken but detected at runtime only. The second pull request solved
that problem but introduced other regressions.

Sanne

On 23 October 2011 09:20, Galder Zamarreño <galder at redhat.com> wrote:
> Hi,
>
> This JBoss Logging upgrade is rather annoying for a couple of reasons:
>
> 1. IDE integration is broken: Before we had a JBoss Logging Processor as some dependency that allowed the logging processor to be found in the classpath. Now this is no longer in the classpath, so IntelliJ forces you to point to a jar. However, the new processing jar is split between two jars: ./jboss-logging-processor/1.0.0.CR3/jboss-logging-processor-1.0.0.CR3.jar  and ./jboss-logging-generator/1.0.0.CR3/jboss-logging-generator-1.0.0.CR3.jar - And the generation won't work without both jars being pointed by the annotation processor. David, why did you split these jars?
>
> 2. It breaks our build, see https://infinispan.ci.cloudbees.com/job/Infinispan-master-JDK6-tcp/268/org.infinispan$infinispan-query/console - What are these errors about? And why is it an info it breaks the compilation? :)
> [INFO] diagnostic error: All message bundles and message logger messageMethods must have or inherit a message.
>
> What is wrong with https://github.com/infinispan/infinispan/blob/master/query/src/main/java/org/infinispan/query/logging/Log.java ?
>
> Cheers,
>
> p.s. We can we please test these upgrades throughfully before committing them? Thx :)
> --
> Galder Zamarreño
> Sr. Software Engineer
> Infinispan, JBoss Cache
>
>
> _______________________________________________
> infinispan-dev mailing list
> infinispan-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/infinispan-dev
>