[infinispan-dev] To make it clear which PRs need attention ...

Sanne Grinovero sanne at infinispan.org
Mon Aug 4 11:09:16 EDT 2014


On 4 August 2014 09:02, Radim Vansa <rvansa at redhat.com> wrote:
> Great, thanks, Sanne! I was often in-doubt what's the actual status of
> my PR, now I will check these :)
>
> Btw., "Ready for review" suggests that I think that it could be
> integrated after a proper review. There are situations (such as my [1])
> where I need some advice about the PR - should that be considered "Ready
> for review", or would be some label "Advice/Review requested" fit
> better? Of course, having thousand labels is not desirable, that's why I
> am asking how coarse grained this should be.

Good point, I've created an intense blue label for that.
+1 to not have many labels but we're free to experiment a bit.

Sanne

>
> Radim
>
> [1] https://github.com/infinispan/infinispan/pull/2585
>
> On 08/01/2014 09:50 PM, Sanne Grinovero wrote:
>> .. and from who.
>>
>> It's sometimes unclear which PRs are there in need for review, or
>> which have been commented on and are waiting for fixes / polishing /
>> rebase / denial.
>>
>> Hope these labels help:
>> https://github.com/infinispan/infinispan/pulls
>>
>> And you can bookmark them!
>> https://github.com/infinispan/infinispan/pulls?q=is%3Aopen+is%3Apr+label%3A%22Ready+for+Review%22
>>
>> Cheers,
>> Sanne
>> _______________________________________________
>> infinispan-dev mailing list
>> infinispan-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/infinispan-dev
>
>
> --
> Radim Vansa <rvansa at redhat.com>
> JBoss DataGrid QA
>
> _______________________________________________
> infinispan-dev mailing list
> infinispan-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/infinispan-dev


More information about the infinispan-dev mailing list