[jboss-dev] new scanning in AS trunk

Tue Jun 8 01:59:01 EDT 2010

Thanks for looking into this Brian.

As for the issue, I think, as already pointed out by Remy, relying on 
deployment file names in itself isn't a good way of filtering out 
deployments. I know it's a good to have feature, but I believe it should 
be more of a "user deployment" feature rather than for deployments that 
are shipped by JBoss AS.  From what I understand, the real fix is to add 
a (empty?) jboss-scanning.xml to such deployments which shouldn't be 
scanned. Or maybe there's a better way based on metadata (version)? I'll 
create a separate JIRA for that, so that we can get rid of these name 
based filtering (atleast for JBoss AS shipped deployments).

regards,
-Jaikiran
Brian Stansberry wrote:
> Found it; should be easy to fix. Deployments whose names include the 
> string "cluster" aren't being scanned.
>
> https://jira.jboss.org/browse/JBAS-8076
>
> This problem may be the cause of some other failures as well, as 
> deployments including the string "hornetq" or "security" in their 
> names will have the problem.
>
> On 06/07/2010 01:49 PM, Brian Stansberry wrote:
>> I'll poke into this some more this afternoon and will file a JIRA. I
>> suspect it will be easy enough to isolate; there's ZERO logging from any
>> EJB3 deployer, so something pretty early in the process must be going 
>> wrong.
>>
>> On 06/07/2010 12:38 PM, Jaikiran Pai wrote:
>>> Is there a JIRA around this one? We are seeing similar clustering
>>> deployment failures in our EJB3 build environment. I haven't yet looked
>>> into the details to see what exactly causes the issue.
>>>
>>> -Jaikiran
>>> Brian Stansberry wrote:
>>>> Still fails.
>>>>
>>>> I don't think the problem is on the JPA side -- or at least that's not
>>>> the obvious surface problem. The persistence unit deployment seems to
>>>> go ok.
>>>>
>>>> The obvious surface problem is that during the deployment there is no
>>>> logging by any EJB3 related deployers. The session beans the test
>>>> invokes on are not getting deployed.
>>>>
>>>> On 06/03/2010 03:17 PM, Ales Justin wrote:
>>>>> The JPA has known issues:
>>>>>
>>>>>> https://jira.jboss.org/browse/JBJPA-29
>>>>>> https://jira.jboss.org/browse/JBAS-8064
>>>>> ALR already fixed this with new jpa.vfs3 release.
>>>>> And Shelly just confirmed this now works as expected.
>>>>>
>>>>> The new jsp.vfs3 lib is already commited into c-m/pom.xml.
>>>>> Can you try it and let us know if this also works for you?
>>>>>
>>>>>
>>>>> On Jun 3, 2010, at 10:07 PM, Brian Stansberry wrote:
>>>>>
>>>>>> The tests artifacts are jars that all have this structure:
>>>>>>
>>>>>> META-INF/
>>>>>> ++ MANIFEST.MF (w/ nothing interesting
>>>>>> ++ persistence.xml
>>>>>> org/blah/...
>>>>>>
>>>>>> where some of the classes are entities and some are annotated EJB3
>>>>>> session beans. No ejb-jar.xml or jboss.xml.
>>>>>>
>>>>>> The testsuite/output/lib/clusteredentity-test.jar is a good example.
>>>>>>
>>>>>> In some but not all tests the jar is packaged in an ear along with a
>>>>>> datasource.
>>>>>>
>>>>>> There's no EJB3 deployer logging, so perhaps the scanning isn't 
>>>>>> picking
>>>>>> up the EJB annotations?
>>>>>>
>>>>>> On 06/03/2010 03:01 PM, Brian Stansberry wrote:
>>>>>>> Following this commit (r105574), the tests in the
>>>>>>> o.j.t.clustered.clusteredentity package started failing.[1] I
>>>>>>> brought an
>>>>>>> AS checkout up to the commit before that (r105506) and they 
>>>>>>> pass, but
>>>>>>> with the r105574 commit they start failing.
>>>>>>>
>>>>>>> The tests deploy ejb3 jars with persistence units included. The 
>>>>>>> tests
>>>>>>> are failing because the EJBs are not bound in JNDI. Looking at the
>>>>>>> logs
>>>>>>> there are no obvious failures during the artifact deployments. But
>>>>>>> there's no logging from any EJB3 deployers, just from Hibernate.
>>>>>>>
>>>>>>> [1]
>>>>>>> http://hudson.qa.jboss.com/hudson/view/JBoss%20AS/job/JBoss-AS-6.0.x-testSuite-sun16/739/testReport/org.jboss.test.cluster.defaultcfg.clusteredentity.test/ 
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On 06/02/2010 08:26 AM, Ales Justin wrote:
>>>>>>>> I've just updated the AS trunk with new Scanning lib.
>>>>>>>> It also includes some other MC changes: Reflect, MDR, Kernel, CL,
>>>>>>>> Deployers.
>>>>>>>>
>>>>>>>> Apart from AnnotationRepository (which was already there with the
>>>>>>>> old code),
>>>>>>>> I've also hacked around Hibernate's Scanner a bit, so it uses new
>>>>>>>> scanning lib's ScannerImpl.
>>>>>>>> (the hack is mostly in place due to some impl issues in Hibernate
>>>>>>>> itself, Emmanuel is working on it)
>>>>>>>>
>>>>>>>> JSF can now use new JBossAnnotationProvider -- let me know how 
>>>>>>>> that
>>>>>>>> goes Stan.
>>>>>>>> And web can use ResourcesIndex from DeploymentUnit -- Remy.
>>>>>>>>
>>>>>>>> WeldScanningPlugin is currently commented out.
>>>>>>>> We need to disable one of the deployers in plugin's favor.
>>>>>>>> Pete, let me know when the new Weld release is coming in,
>>>>>>>> and I'll enable the plugin + run a few tests.
>>>>>>>>
>>>>>>>> All in all, if you spot any issues / regressions wrt this change,
>>>>>>>> let me know, and I'll try to fix the stuff asap.
>>>>>>>>
>>>>>>>>
>>>>>>>> _______________________________________________
>>>>>>>> jboss-development mailing list
>>>>>>>> jboss-development at lists.jboss.org
>>>>>>>> <mailto:jboss-development at lists.jboss.org>
>>>>>>>> https://lists.jboss.org/mailman/listinfo/jboss-development
>>>>>>>
>>>>>>
>>>>>> -- 
>>>>>> Brian Stansberry
>>>>>> Lead, AS Clustering
>>>>>> JBoss by Red Hat
>>>>>> _______________________________________________
>>>>>> jboss-development mailing list
>>>>>> jboss-development at lists.jboss.org
>>>>>> <mailto:jboss-development at lists.jboss.org>
>>>>>> https://lists.jboss.org/mailman/listinfo/jboss-development
>>>>
>>>>
>>>
>>
>>
>
>