[jbosstools-dev] Automated Tests in tests/ module: What are the Annotated*.java ?

[Max Rydahl Andersen]

On Apr 25, 2012, at 9:09 , Vlado Pakan wrote:

> Hi Max,
> 
> Right now org.jboss.tools.ui.bot.ext.test is on correct place within tests module or is it not correct place?

Sorry - I misread "tests module". For me tests module is trunk/test not trunk/test/tests/ directory :)

All ok then.

> Reason to not run all of these tests via maven build is that these test are not worth it. if there is error affecting tests from JBT modules JSF, CDI ... then these tests will fail if there is error affecting only swt.bot.ext "framework" it's not used in project/product testing.
> 
> It has really low priority to have these tests running actually nobody was running them till now. We will use them once swt.bot.ext alias red deer will be published to community.
> 
> Another reason is to not make build time longer. These tests are starting and stopping AS which would take some time.

All fine for me. Agreed it is not important to get tests that didnt run before except for dev running now - good we got the tests code moved though to avoid repating confusion over what is in the code ;)

Thanks,
/max

> 
> Vlado.
> 
> On 04/25/2012 12:41 AM, Max Rydahl Andersen wrote:
>> guys - please don't put tests inside api/app source code.
>> 
>> makes zero sense.
>> 
>> don't understand the reason for not having the tests properly setup as everywhere else ?
>> 
>> /max
>> 
>> On Apr 24, 2012, at 15:46 , Vlado Pakan wrote:
>> 
>>> Hi,
>>> 
>>> org.jboss.tools.ui.bot.ext.test is moved to tests module. I have updated
>>> related pom files and set skipTests property to true for this plugin
>>> because we do not want to run this tests automatically. There is only
>>> one test left defined within test suite and this one should not create
>>> any problem when run within build in case somebody will run these test
>>> via maven and force them to be executed. All the tests contained in this
>>> plugin are really just for test developers and they will run them
>>> manually if they will want.
>>> 
>>> Javadoc added.
>>> 
>>> Vlado.
>>> 
>>> On 04/24/2012 01:55 PM, Max Rydahl Andersen wrote:
>>>> `
>>>>> Tests in org/jboss/tools/ui/bot/ext/test were added only for testing
>>>>> during development of this package and there is no reason to run these
>>>>> tests. It's confirmed by author.
>>>>> 
>>>>> I'm gonna comment out test classes in test suite definition to have
>>>>> ready this test suite for development of this package in future but not
>>>>> run any test when package is built.
>>>> okey - and it does not make sense to move these tests to the right test module instead of within the non-testy parts ?
>>>> 
>>>>> I will also add some javadoc to have some description of this package
>>>>> content.
>>>> yes, please :)
>>>> 
>>>> /max
>>>> 
>>>> 
>>> _______________________________________________
>>> jbosstools-dev mailing list
>>> jbosstools-dev at lists.jboss.org
>>> https://lists.jboss.org/mailman/listinfo/jbosstools-dev