[jbosstools-dev] AS Test Suite failure fix?

Denis Golovin dgolovin at exadel.com
Tue Mar 19 14:21:29 EDT 2013


We sure should, I just forgot about -Dmaximum  and thought it is just 
different behavior in WTP 3.4 and 3.5.

Denis


On 03/19/2013 02:10 AM, Rob Stryker wrote:
> https://github.com/jbosstools/jbosstools-server/commit/b3672b46e4df710741c39ff77733246485547c8c 
>
>
> Denis:
>
> I realize the error in the test suite was that the .project file is 
> now included, whereas it was not included in the past.  Why do you 
> think the proper solution to this change in behavior was to simply 
> change the expected count? That seems like a very bad fix.
>
> If something upstream has changed, we should discover what it is 
> before simply changing the expected count in the unit test. Clearly 
> these tests used to pass, and started failing after the update to m5. 
> Shouldn't we try to discover what exactly changed here?
>
> - Rob



More information about the jbosstools-dev mailing list