[jbosstools-dev] ACTION REQUIRED: JBT 4.1.1.Alpha2 candidate build STILL contains older Forge features

[Nick Boldt]

Reported here:

https://issues.jboss.org/browse/JBIDE-15610

On 10/03/2013 11:43 AM, Max Andersen wrote:
> On Thu, Oct 03, 2013 at 11:12:29AM -0400, Nick Boldt wrote:
>> Wrong plugin - thought I already explained this ad nauseum in other
>> thread(s).
>
> All rebuilt/rereleased plugins shuold have their micro version bumped -
> that is how we've done it for ages.
> our build setup and release mechanism doesn't just release the changed
> ones so if this goes final you
> have two plugins with same x.y.z even though they are *not* the same.
> I thought we discussed the bad parts of that ad nauseum too ;)
>
> /max
>
>> Affected plugin was the runtime one.
>>
>> https://github.com/jbosstools/jbosstools-forge/blob/jbosstools-4.1.1.Alpha2x/plugins/org.jboss.tools.forge.runtime/META-INF/MANIFEST.MF#L5
>>
>>
>> Just check the history, and the changes become obvious:
>>
>> https://github.com/jbosstools/jbosstools-forge/commits/jbosstools-4.1.1.Alpha2x
>>
>>
>> On 10/03/2013 10:55 AM, Max Andersen wrote:
>>> On Thu, Oct 03, 2013 at 04:10:47PM +0200, Koen Aers wrote:
>>>> The plugin versions were already changed earlier.
>>>
>>> where ?
>>>
>>> afaics
>>> https://github.com/jbosstools/jbosstools-forge/blob/jbosstools-4.1.1.Alpha2x/plugins/org.jboss.tools.forge.core/META-INF/MANIFEST.MF
>>>
>>>
>>>
>>> was updated 8 months ago.
>>>
>>>
>>> /max
>>>
>>>> Cheers,
>>>> Koen
>>>>
>>>> Op 3-okt.-2013, om 15:48 heeft Max Andersen het volgende geschreven:
>>>>
>>>>> I see
>>>>> https://github.com/jbosstools/jbosstools-forge/commit/94821b4acbcff5cded0f7ac894315ba555963512
>>>>>
>>>>>
>>>>>
>>>>> but that just changes the feature version, not the plugin versions.
>>>>>
>>>>> This looks like incomplete patch/fix ?
>>>>>
>>>>> /max
>>>>>
>>>>> On Tue, Oct 01, 2013 at 12:33:33PM +0200, Max Andersen wrote:
>>>>>> Koen - can you do this ASAP ?
>>>>>>
>>>>>> Thanks,
>>>>>> Max
>>>>>>
>>>>>> On Mon, Sep 30, 2013 at 02:49:56PM -0400, Nick Boldt wrote:
>>>>>>> In JBT 4.1.0 [0], we had Forge features 1.0.0 and 1.2.0.
>>>>>>>
>>>>>>> [0] http://download.jboss.org/jbosstools/updates/stable/kepler/
>>>>>>>
>>>>>>> In JBT 4.1.1.Alpha2, we have Forge features 1.0.0 and 1.2.0 [1] as
>>>>>>> well, even though things have changed [2].
>>>>>>>
>>>>>>> [1]
>>>>>>> http://download.jboss.org/jbosstools/builds/staging/jbosstools-forge_41/all/repo/
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> [2]
>>>>>>> https://github.com/jbosstools/jbosstools-forge/commits/jbosstools-4.1.1.Alpha2x
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> In JBT 4.2.0 (master branch), we have Forge features 1.1.0 and
>>>>>>> 1.3.0 [3].
>>>>>>>
>>>>>>> [3]
>>>>>>> http://download.jboss.org/jbosstools/builds/staging/jbosstools-forge_master/all/repo/
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> So... if you want the newer forge bits included in the JBT
>>>>>>> 4.1.1.Alpha2 build, you need to bump the features that contain
>>>>>>> org.jboss.tools.forge.runtime to contain the changed forge runtime
>>>>>>> (1.3.3 -> 1.4.1), presumably to 1.2.1.
>>>>>>>
>>>>>>> Affected files:
>>>>>>>
>>>>>>> https://github.com/jbosstools/jbosstools-forge/blob/jbosstools-4.1.1.Alpha2x/features/org.jboss.tools.forge.feature/feature.xml
>>>>>>>
>>>>>>>
>>>>>>> https://github.com/jbosstools/jbosstools-forge/blob/jbosstools-4.1.1.Alpha2x/features/org.jboss.tools.forge.feature/pom.xml
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> https://github.com/jbosstools/jbosstools-forge/blob/jbosstools-4.1.x/features/org.jboss.tools.forge.feature/feature.xml
>>>>>>>
>>>>>>>
>>>>>>> https://github.com/jbosstools/jbosstools-forge/blob/jbosstools-4.1.x/features/org.jboss.tools.forge.feature/pom.xml
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> When this is fixed, please kick your job [4] to respin it using the
>>>>>>> updated versions. I'll be leaving for the airport in 2hrs, so I
>>>>>>> won't
>>>>>>> have time to kick it for you.
>>>>>>>
>>>>>>> [4]
>>>>>>> https://jenkins.mw.lab.eng.bos.redhat.com/hudson/view/DevStudio/view/DevStudio_7.0.kepler/job/jbosstools-forge_41/
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Nick Boldt :: JBoss by Red Hat
>>>>>>> Productization Lead :: JBoss Tools & Dev Studio
>>>>>>> http://nick.divbyzero.com
>>>>>> _______________________________________________
>>>>>> jbosstools-dev mailing list
>>>>>> jbosstools-dev at lists.jboss.org
>>>>>> https://lists.jboss.org/mailman/listinfo/jbosstools-dev
>>>>> _______________________________________________
>>>>> jbosstools-dev mailing list
>>>>> jbosstools-dev at lists.jboss.org
>>>>> https://lists.jboss.org/mailman/listinfo/jbosstools-dev
>>>>
>>
>> --
>> Nick Boldt :: JBoss by Red Hat
>> Productization Lead :: JBoss Tools & Dev Studio
>> http://nick.divbyzero.com

-- 
Nick Boldt :: JBoss by Red Hat
Productization Lead :: JBoss Tools & Dev Studio
http://nick.divbyzero.com