[jbosstools-dev] Pull Request against jbosstools-target-platforms repository validated automatically

[Mickael Istria]

On 05/25/2016 07:45 PM, Nick Boldt wrote:
> When I moved us to M7, there were a number of required small tweaks 
> before I had a PR that worked, and that validation happens much more 
> efficiently on local than by submitting it off to Jenkins to build.
Contributions checks are in no way meant to replace the local tests and 
are not an assistance for development/authoring the change. They're just 
an assistance for review (someone else reviewing the change doesn't have 
to build locally).
> And that "blue" PR contained bad changes like the addition of jetty 
> 9.3.6 and a newer Mylyn Wikitext version. Neither of these were caught 
> by the TP build/validation process -- they were caught by downstream 
> install-grinder and p2director install tests.
Right.
It's already good that such issues are detected automatically by those jobs.
But we can do better, I've opened 
https://issues.jboss.org/browse/JBIDE-22443 to suggest a way to catch 
such issues earlier automatically.
-- 
Mickael Istria
Eclipse developer at JBoss, by Red Hat <http://www.jboss.org/tools>
My blog <http://mickaelistria.wordpress.com> - My Tweets 
<http://twitter.com/mickaelistria>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/jbosstools-dev/attachments/20160526/73596e48/attachment.html