[keycloak-dev] module re-org

Stian Thorgersen sthorger at redhat.com
Tue Jan 12 13:32:16 EST 2016


On 12 January 2016 at 16:26, Bill Burke <bburke at redhat.com> wrote:

>
>
> On 1/12/2016 2:45 AM, Stian Thorgersen wrote:
>
>
>
> On 12 January 2016 at 03:22, Bill Burke <bburke at redhat.com> wrote:
>
>> I can't find the original email on this, but we need to do this for
>> 1.9.  I can start doing it one module at a time:
>
>
>> Common:
>> keycloak-common
>> keycloak-common-saml
>> keycloak-common-oidc
>>
>> Libraries server:
>>
>> keycloak-server-spi - all SPI interfaces and common code
>> keycloak-server-saml - all saml server code, broker and protocol plugins
>> keycloak-server-oidc - all oidc code, broker and protocol plugins
>> keycloak-server-impl - everything
>>
>
> I'm not 100% sure we should put all implementations of SPIs into
> keycloak-server-impl. We at least need to keep Mongo separate as it's not
> part of the product.
>
> If we put all SPI implementations, including services, into the same
> module we'd end up with one huge module. There's also a risk that we'd end
> up with strong relationships between them, rather than having them properly
> linked via SPI interfaces.
>
> I'm a bit 50/50 on it though.
>
> You do remember how many modules we currently have don't you?  Minimally,
> we should have a big SPI module right?
>

I'm absolutely on board with:

Common:
keycloak-common
keycloak-common-saml
keycloak-common-oidc

Libraries server:
keycloak-server-spi

So we can agree on that, I'm just not 100% sure about a single module for
all SPI implementations and services.



>
>
> --
> Bill Burke
> JBoss, a division of Red Hathttp://bill.burkecentral.com
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/keycloak-dev/attachments/20160112/d2209a51/attachment.html 


More information about the keycloak-dev mailing list