[keycloak-dev] Any reason why the DefaultBruteForceProtector success() method is private?

[Stian Thorgersen]

I don't see any issues with changing it to public. Just remember that only
SPIs/APIs in server-spi will have backwards compatibility/deprecation
period.

On Fri, 13 Jul 2018 at 20:17, Eric B <ebenzacar at gmail.com> wrote:

> Hi.
>
> I'm looking at producing an extended implementation of the
> DefaultBruteForceProtector implementation, but for some reason the
> success() method in the class is the only private method which is
> prohibiting me of simply extending the DefaultBruteForceProtector class and
> adding some additional logic to the methods.
>
> Is there a particular reason why the visibility for these methods are as
> follows?
> - public void failure()
> - private void success()
>
> Why is success() private, whereas failure is public()?  Was this just an
> oversight?  Can sucess() be changed to public?
>
> Thanks,
>
> Eric
> _______________________________________________
> keycloak-dev mailing list
> keycloak-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/keycloak-dev
>