[rules-dev] Guvnor 5.2.0.M1.x : Maven config fix

[Sayhi Aymen]

Hi Geoffrey,

I've fixed all things you've talked about and I've some remarks:

2011/2/24 Geoffrey De Smet <ge0ffrey.spam at gmail.com>

>  Hi Sayhi,
>
> Thanks for noticing this issue and creating a patch.
>
> Unfortunately I cannot accept and apply this patch because:
> - By changing the build resources to only include
> src/main/resources/**/*.gwt.xml, it breaks the backend which needs other
> resources out of src/main/resources.
>

Fixed : you're right !


> - By changing the build resources to include the java files from
> src/main/java, it clutters the deployed jars and dirties the build (those
> things are in source jars already).
>

Maintained:
Projects "drools-factconstraint" and "drools-ide-common" are seen as gwt
libraries by "drools-guvnor", one of the rules for developing gwt libraries
is that when packaged, classes that reside in the client package (i.e. those
that will be used in client code of projets using the library) should have
their sources packaged with them. The reason for this is that sources should
be available on the classpath for the gwt compiler.

You can check this in gwt-user.jar itself :
http://repo1.maven.org/maven2/com/google/gwt/gwt-user/2.1.1/gwt-user-2.1.1.jar

And in the famous library Ext GWT :
http://repo1.maven.org/maven2/com/extjs/gxt/2.2.0/gxt-2.2.0.jar


> - It's stale when compared to master on
> https://github.com/droolsjbpm/guvnor
> -- drools-factconstraints has been removed some time already on master
> -- droolsjbpm-ide-common is ne
>

This patch is intended for "origin/5.2.0.M1.x" branch, not for master.


> - The changes are obfuscated with style changes that do not follow our
> guidelines.
> -- See README https://github.com/droolsjbpm/droolsjbpm-build-bootstrap
> --- More specifically about indentation
>
>
Fixed: sorry for that :) I'm using your cleaning and formatting settings
now.


> I believe a much better way to deal with the gwt:run problem is to fix this
> issue:
>   https://issues.jboss.org/browse/GUVNOR-1196
>

You don't really think it is needed to do All that in order to run the
guvnor project with maven.


>
> But that's stuck on the fact that I don't know if and how intellij/eclipse
> can deal with hosted mode in that structure.
> Any experiments and data to answer that question will help that issue
> forward.
>
> --
> With kind regards,
> Geoffrey De Smet
>
>
>
I attached a patch (fixed one :)) to this e-mail for those who are using
branch 5.2.0.M1.x and need to run the guvnor project in hosted mode with
maven.

P.S. sorry for the previous e-mail, it was incomplete.


> Op 24-02-11 02:17, Sayhi Aymen schreef:
>
>
>  Here is the patch. I hope it helps !
>
> 2011/2/23 Mauricio Salatino <salaboy at gmail.com>
>
>> Sounds really cool.. if you can help to get maven working better for the
>> project I think that the dev team will highly appreciate that.
>> Greetings.
>>
>>  On Wed, Feb 23, 2011 at 1:36 PM, Sayhi Aymen <sayhi.aymen at gmail.com>wrote:
>>
>>>
>>>  Hi everybody,
>>>
>>> I checked Drools 5.2.0.M1.x sources yesterday in order to look with more
>>> insight to *Guvnor *internals.
>>>
>>>  I built the whole project with *Maven* and that was ok.
>>>
>>>  But when I tried to run *Guvnor *with *Maven *(mvn gwt:run) I was
>>> surprised to see that the *Maven *config do not allow that, I get a lot
>>> of errors !
>>>
>>>  Thankfully I fixed that (after a hard night) and I want to contribute
>>> with that *Maven *config fix.
>>>
>>>  Are you interested ?
>>>
>>>  By the way, I've already been *Maven *maintainer of an open source
>>> project on sourceforge, *Gilead<http://noon.gilead.free.fr/gilead/index.php?page=thanks>
>>> *. And I can help you in the future for anything related to *Maven*.
>>>
>>> --
>>> Best Regards
>>> Aymen SAYHI
>>>
>>>
>>>
>>>  _______________________________________________
>>> rules-dev mailing list
>>> rules-dev at lists.jboss.org
>>> https://lists.jboss.org/mailman/listinfo/rules-dev
>>>
>>>
>>
>>
>> --
>>  - CTO @ http://www.plugtree.com
>>  - MyJourney @ http://salaboy.wordpress.com
>>  - Co-Founder @ http://www.jbug.com.ar
>>
>>  - Salatino "Salaboy" Mauricio -
>>
>
>
>
> --
> Best Regards
> Aymen SAYHI
>
>
>
> _______________________________________________
> rules-dev mailing listrules-dev at lists.jboss.orghttps://lists.jboss.org/mailman/listinfo/rules-dev
>
>
>
> _______________________________________________
> rules-dev mailing list
> rules-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/rules-dev
>
>
-- 
Best Regards
Aymen SAYHI
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/rules-dev/attachments/20110225/8137aaf2/attachment-0001.html 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-origin-5.2.0.M1.x-Fixed-pom-files-necessary-for-runn.patch
Type: application/octet-stream
Size: 1877 bytes
Desc: not available
Url : http://lists.jboss.org/pipermail/rules-dev/attachments/20110225/8137aaf2/attachment-0001.obj