[shrinkwrap-issues] [JBoss JIRA] Commented: (SHRINKWRAP-237) ShrinkWrap ClassLoader Caches the read Assets Inputstream

[Aslak Knutsen (JIRA)]

    [ https://jira.jboss.org/browse/SHRINKWRAP-237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12559503#action_12559503 ] 

Aslak Knutsen commented on SHRINKWRAP-237:
------------------------------------------

No I'm just stating where in the code the issues is and what needs to be done to fix it.. 

I'm not sure what your getting at in your example tho, a InputStream is a one time operation, you can't reset it. So reading it twice will normally fail.

I can counter your argument for Descriptors with; why are we closing resources we don't create/control. Give us a File or a String, we create the InputSream and we clean up. Give us a InputStream, your in charge of cleaning up. We don't know what type of inputstream etc we're getting, closing it might not be the desired behavior.

> ShrinkWrap ClassLoader Caches the read Assets Inputstream
> ---------------------------------------------------------
>
>                 Key: SHRINKWRAP-237
>                 URL: https://jira.jboss.org/browse/SHRINKWRAP-237
>             Project: ShrinkWrap
>          Issue Type: Bug
>    Affects Versions: 1.0.0-alpha-11
>         Environment: Weld 1.1.0.Beta1, Arqullian Alpha4, Seam XML Alpha3
>            Reporter: Lincoln Baxter III
>
> http://pastebin.com/3neHZ6BL
> This can be reproduced using Weld 1.1.0.Beta1, Seam XML Alpha3 and Arqullian Alpha4-  create a test that attempts to add a Manifest Resources from disk to Beans.xml.
> Seam XML will attempt to load the beans file and complain that the InputStream was closed.
> @RunWith(Arquillian.class)
> public class DefaultTimeZoneTest
> {
>    @Deployment
>    public static JavaArchive createTestArchive()
>    {
>       return ShrinkWrap.create(JavaArchive.class, "test.jar")
>                .addClass(DefaultTimeZoneProducer.class)
>                .addClass(DefaultTimeZoneConfig.class)
>                .addManifestResource("org/jboss/seam/international/test/timezone/user-timezone.xml", ArchivePaths.create("beans.xml"));
>    }
>    @Inject
>    DateTimeZone timeZone;
>    @Test
>    public void testDefaultTimeZoneProducerDirect()
>    {
>       Assert.assertNotNull(timeZone);
>    }
> }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira