[shrinkwrap-issues] [JBoss JIRA] Commented: (SHRINKDESC-18) DescriptorImporter.from(InputStream) should close the IS by default, have option to leave open

[Dan Allen (JIRA)]

    [ https://issues.jboss.org/browse/SHRINKDESC-18?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615774#comment-12615774 ] 

Dan Allen commented on SHRINKDESC-18:
-------------------------------------

Don't you typically lead with the boolean flags. I'm referring to the ShrinkWrap archive methods like addPackages(boolean recursive, ...). I'm just bringing it to your attention...not necessarily saying it should come first in this case.

> DescriptorImporter.from(InputStream) should close the IS by default, have option to leave open
> ----------------------------------------------------------------------------------------------
>
>                 Key: SHRINKDESC-18
>                 URL: https://issues.jboss.org/browse/SHRINKDESC-18
>             Project: ShrinkWrap Descriptors
>          Issue Type: Feature Request
>          Components: api
>    Affects Versions: 0.1.0
>            Reporter: Dan Allen
>            Assignee: Tommy Tynjä
>            Priority: Minor
>
> The import process should close the stream. After all, the main purpose of providing the stream is to slurp up all the contents. If the stream is left open, we throw the burden back on the developer to close it (and all the try/catch block headaches)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira