[shrinkwrap-issues] [JBoss JIRA] Commented: (SHRINKDESC-18) DescriptorImporter.from(InputStream) should close the IS by default, have option to leave open

[Aslak Knutsen (JIRA)]

    [ https://issues.jboss.org/browse/SHRINKDESC-18?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615787#comment-12615787 ] 

Aslak Knutsen commented on SHRINKDESC-18:
-----------------------------------------

The only reason for boolean first in addPackages is due to the varargs Package..., needs to be the last argument

> DescriptorImporter.from(InputStream) should close the IS by default, have option to leave open
> ----------------------------------------------------------------------------------------------
>
>                 Key: SHRINKDESC-18
>                 URL: https://issues.jboss.org/browse/SHRINKDESC-18
>             Project: ShrinkWrap Descriptors
>          Issue Type: Feature Request
>          Components: api
>    Affects Versions: 0.1.0
>            Reporter: Dan Allen
>            Assignee: Tommy Tynjä
>            Priority: Minor
>
> The import process should close the stream. After all, the main purpose of providing the stream is to slurp up all the contents. If the stream is left open, we throw the burden back on the developer to close it (and all the try/catch block headaches)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira