[weld-dev] Pull Request to close weld.properties file sooner

[Benjamin Confino]

Good morning. 

No worries about Weld 2 releases, I've already informed the team of the 
situation regarding that branch, but I thought it was no trouble to submit 
a PR anyway.

Regarding your question about verification, my understanding of where 
things are is that we shifted to looking for a more general solution to 
make liberty more resilient as we promptly uncovered a different upstream 
component that had a stream without a closing statement. Tom Bitonti will 
be taking the lead on that. 

Regards
Benjamin



From:   Matej Novotny <manovotn at redhat.com>
To:     Benjamin Confino <BENJAMIC at uk.ibm.com>
Cc:     weld-dev at lists.jboss.org, Thomas Bitonti <bitonti at us.ibm.com>
Date:   09/12/2019 10:12
Subject:        [EXTERNAL] Re: [weld-dev] Pull Request to close 
weld.properties file sooner



Hello,

thanks for the PR. We're totally missing the stream closing statement 
there.
I take it you verified that this fixes the problem in Liberty?

Otherwise, master branch (Weld 3.1) is totally where these PRs should go.
As for 3.0, we do not plan any releases there, we are going forward with 
just 3.1 branch.
So I don't really see much value in merging it there.
Last but not least, Weld 2 is not actively developed anymore and doesn't 
have a set release schedule.
Therefore, we can merge it there, but with no promises on release dates.

I've created a tracking JIRA for this - 
https://urldefense.proofpoint.com/v2/url?u=https-3A__issues.redhat.com_browse_WELD-2D2606&d=DwICaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=hl8XiFr1UrTSgyXVc4KO_i51sM3Gyhlu1KZ4TkyseEQ&m=y7s467dvmfgmFyicUufBC0I2_vl6xSZSZ82OnXdxz0s&s=2vFuWBXP-AeLXJTKXd6oXQd2roIYzQvtYYK_WK0n1Uw&e= 


Regards
Matej

----- Original Message -----
> From: "Benjamin Confino" <BENJAMIC at uk.ibm.com>
> To: weld-dev at lists.jboss.org
> Cc: "Thomas Bitonti" <bitonti at us.ibm.com>
> Sent: Saturday, December 7, 2019 12:34:17 PM
> Subject: [weld-dev] Pull Request to close weld.properties file sooner
> 
> Hello
> 
> We encountered a bug in liberty which we think is caused by the
> weld.properties file remaining open for longer than liberty expects 
files to
> be held open. To resolve this I have submitted a trio of small pull 
requests
> that will close the InputStream in a finally block after weld.properties 
is
> read. You can find them at:
> 
> 
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_weld_core_pull_1953&d=DwICaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=hl8XiFr1UrTSgyXVc4KO_i51sM3Gyhlu1KZ4TkyseEQ&m=y7s467dvmfgmFyicUufBC0I2_vl6xSZSZ82OnXdxz0s&s=KvY8Q6_s6uQaG2v-7WS_rQvvqye-I12jV_v0hyMSN3U&e= 

> 
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_weld_core_pull_1954&d=DwICaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=hl8XiFr1UrTSgyXVc4KO_i51sM3Gyhlu1KZ4TkyseEQ&m=y7s467dvmfgmFyicUufBC0I2_vl6xSZSZ82OnXdxz0s&s=9L5r4Aps0ZbZZhxdkxkZsLZzFMoR2uwnIvZy3_2O1Gw&e= 

> 
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_weld_core_pull_1955&d=DwICaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=hl8XiFr1UrTSgyXVc4KO_i51sM3Gyhlu1KZ4TkyseEQ&m=y7s467dvmfgmFyicUufBC0I2_vl6xSZSZ82OnXdxz0s&s=4LhjQ3v4D4SvrGYlWRhJxylbpbxQSF2bFcfmY-3bhAY&e= 

> 
> I hope these PRs meet with your approval.
> 
> Regards
> Benjamin
> Unless stated otherwise above:
> IBM United Kingdom Limited - Registered in England and Wales with number
> 741598.
> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 
3AU
> 
> _______________________________________________
> weld-dev mailing list
> weld-dev at lists.jboss.org
> 
https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.jboss.org_mailman_listinfo_weld-2Ddev&d=DwICaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=hl8XiFr1UrTSgyXVc4KO_i51sM3Gyhlu1KZ4TkyseEQ&m=y7s467dvmfgmFyicUufBC0I2_vl6xSZSZ82OnXdxz0s&s=sQcNiakgq8LFBUR9gNMwEiu_RQqxBL0yVB25AinCRns&e= 






Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 
741598. 
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/weld-dev/attachments/20191209/792af6cf/attachment.html