[
https://jira.jboss.org/jira/browse/DNA-456?page=com.atlassian.jira.plugin...
]
Dan Florian commented on DNA-456:
---------------------------------
Below are the TCK tests that are failing using my (not currently checked-in)
implementation of the ObservationManager and why I think they are failing.
One design note: I had to implement a check that makes sure Changes with a timestamp
before the time a listener was registered do not get delivered to that listener. This was
a problem because the events were created and the listener was being registered in one
thread and the event notification was being handled in a different thread.
I will write Jiras for (1) requests don't differentiate between setting a new property
or changing an existing property, and (2) Changes need to include a session identifier so
that the ObservationManager can handle the "noLocal" flag.
=====================
LockingTest
testAddLockToNode - no PROPERTY_ADDED events received
testRemoveLockFromNode - no PROPERTY_REMOVED events received
NodeRemovedTest
testMultiNodesRemoved - no NODE_REMOVED event for child nodes when a parent is
removed
NodeMovedTest
testMoveWithRemove - fails with NPE (originalParent) in
GraphSession.containsChangesWithExternalDependencies()
NodeReorderTest
testNodeReorder - no events received (need to research what happens when
node.orderBefore(sourcePath, destinationPath) is called)
PropertyAddedTest
testSinglePropertyAdded - no events received since PROPERTY_ADDED changes are
implemented as PROPERTY_CHANGED events
testMultiPropertyAdded - no events received since PROPERTY_ADDED changes are
implemented as PROPERTY_CHANGED events
PropertyChangedTest
testSinglePropertyChangedWithAdded - too many events as PROPERTY_ADDED changes are
being broadcast as PROPERTY_CHANGED events
AddEventListenerTest
testNodeType - path is /testroot/node2/node3 but should be /testroot/node1/node3
(need to research this one)
testPath - should not have path /testroot/node1 (so does isDeep mean not to
include parent path?)
testIsDeepFalseNodeAdded - path is /testroot/node1 and should be
/testroot/node1/node2 (expected test results seems wrong??)
testIsDeepFalsePropertyAdded - no events since PROPERTY_ADDED changes are sent as
PROPERTY_CHANGED events
testNoLocalTrue - still have to implement "noLocal" check in
ObservationManager
testUUID - no events received since no PROPERTY_ADDED changes are implemented as
PROPERTY_CHANGED events
WorkspaceOperationTest
testCopy - no NODE_ADDED event generated for child node of copied parent node
Add JSR-170 Observation Optional Feature
----------------------------------------
Key: DNA-456
URL:
https://jira.jboss.org/jira/browse/DNA-456
Project: DNA
Issue Type: Feature Request
Components: JCR
Affects Versions: 0.5
Reporter: Brian Carothers
Assignee: Dan Florian
Fix For: 0.7
JSR-170 defines several optional features. The observation feature would provide
notification of node and property changes to registered listeners.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira