[dna-issues] [JBoss JIRA] Commented: (DNA-551) graph.Location's equals(Object) and hashCode() Methods Are Not Consistent
[
https://jira.jboss.org/jira/browse/DNA-551?page=com.atlassian.jira.plugin...
]
Randall Hauch commented on DNA-551:
-----------------------------------
The error was actually an unrelated bug in GraphSession (DNA-559). The fix has been
committed, and incorporating that fix to these changes gets us farther. However, there
still is another error in one of the unit tests in 'dna-connector-filesystem'.
The problem appears to be in AbstractConnectorTest, where one use of
Location.isSame(Location) was not changed to use 'equals()'. Fixing that makes
all unit tests and integration tests pass (via a complete integration build).
graph.Location's equals(Object) and hashCode() Methods Are Not
Consistent
-------------------------------------------------------------------------
Key: DNA-551
URL: https://jira.jboss.org/jira/browse/DNA-551
Project: DNA
Issue Type: Bug
Components: Graph
Affects Versions: 0.6
Reporter: Dan Florian
Priority: Blocker
Fix For: 0.7
Attachments: DNA-551-patch1.txt
Location.hashCode() and Location.equals(Object) need to be consistent. The current
implementation of the base class and subclasses prevent logically equal locations (same
path or same ID properties) from being used java.util.Map objects.
It should be true that if one subtype of Location has the same path as a different
subtype of Location, and only one of these objects has ID properties, those locations
should be equal and should have the same hashCode.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira