[
https://jira.jboss.org/jira/browse/DNA-505?page=com.atlassian.jira.plugin...
]
Randall Hauch commented on DNA-505:
-----------------------------------
Thanks, Feu. I wasn't able to reproduce, but I changed AbstractJcrNode.toString() to
better handle this situation if it should arise. However, it shouldn't really be
happening in the first place, so I've made a few other changes to try and further
prevent this NPE.
First, the PropertyIterator should never expose a null Property, so the code that is
creating this (and the underlying collection of Property objects) was changed to never add
a null reference to the collection.
Second, the SVN connector had one case where it *might* add a null property object to the
resulting nodes, so the code was changed to handle this case.
Svn Repository Source with NPE and other issues while opening
connection through Jcr
------------------------------------------------------------------------------------
Key: DNA-505
URL:
https://jira.jboss.org/jira/browse/DNA-505
Project: DNA
Issue Type: Bug
Components: Connectors
Affects Versions: 0.6
Environment: Mac OS X 10.5 - Jvm 1.5 - Maven 2
Reporter: Luiz Fernando Teston
Assignee: Randall Hauch
Fix For: 0.6
Attachments: 0001-fixing-a-few-null-pointer-exeptions.patch,
DnaSvnUsingJcrWithProgramaticConfigurationTest.java
Durring a test run to read data from some svn repository using Jcr api from DNA, it
throws NullPointerException when trying to read jcr:content for nodes of type folder. This
NPEs was really easy to solve. So, I created a patch for this. After this patch, when
running the same unit test, it throws a repository source exception saying
"svnRepositorySource does not allow same name siblings on nodes: read children of
/{http://www.jcp.org/jcr/1.0}content[2] in the
""http://hamcrest.googlecode.com/svn/trunk/hamcrest-java""
workspace".
The stack trace is here also:
org.jboss.dna.graph.connector.RepositorySourceException: svnRepositorySource does not
allow same name siblings on nodes: read children of
/{http://www.jcp.org/jcr/1.0}content[2] in the
""http://hamcrest.googlecode.com/svn/trunk/hamcrest-java"" workspace
at
org.jboss.dna.connector.svn.SVNRepositoryRequestProcessor.checkThePath(SVNRepositoryRequestProcessor.java:1000)
at
org.jboss.dna.connector.svn.SVNRepositoryRequestProcessor.process(SVNRepositoryRequestProcessor.java:151)
at
org.jboss.dna.graph.request.processor.RequestProcessor.process(RequestProcessor.java:641)
at
org.jboss.dna.graph.request.processor.RequestProcessor.process(RequestProcessor.java:239)
at
org.jboss.dna.graph.request.processor.RequestProcessor.process(RequestProcessor.java:298)
at
org.jboss.dna.graph.request.processor.RequestProcessor.process(RequestProcessor.java:219)
at
org.jboss.dna.connector.svn.SVNRepositoryConnection.execute(SVNRepositoryConnection.java:176)
at
org.jboss.dna.graph.connector.federation.ForkRequestProcessor$Channel$3.call(ForkRequestProcessor.java:318)
at
org.jboss.dna.graph.connector.federation.ForkRequestProcessor$Channel$3.call(ForkRequestProcessor.java:314)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:269)
at java.util.concurrent.FutureTask.run(FutureTask.java:123)
at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:651)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:676)
at java.lang.Thread.run(Thread.java:613)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira