[
http://jira.jboss.com/jira/browse/JBESB-452?page=comments#action_12367436 ]
Daniel Bevenius commented on JBESB-452:
---------------------------------------
Progress update:
"Pulled up" the sendToAll method from NotifyQueues and NotifyTopics as most the
code was
duplicated in both classes.
Made sendToAll a template method that calls send on the specific
subclass (the code that was different in NotifyQueues and NotifyTopics.
sendToAll now throws JMSException is any of the send fail. This will still try to send to
all
configured queues/topics but will later throw a jms message with the error and stacktrace
of
all failed sends. Previously exceptions were simply being logged but no
NotificationException was
getting throws from sendNotfication().
Also added test for the methods in question (not added in both unit test as I it enough to
test one)
Commited revision: 12994
I'll go through and take a look at the other notifiers.
Refactor Notifiers
------------------
Key: JBESB-452
URL:
http://jira.jboss.com/jira/browse/JBESB-452
Project: JBoss ESB
Issue Type: Task
Security Level: Public(Everyone can see)
Components: Rosetta
Affects Versions: 4.0
Environment: any
Reporter: Kurt Stam
Assigned To: Daniel Bevenius
Priority: Critical
Fix For: 4.2
Time Spent: 4 hours
Remaining Estimate: 0 minutes
These comments are based on the JMS notifiers but will probably apply to the other
notifiers as well:
1. The notifiers should be more like listeners where you get one (or more instances).
Until they get recycled when there is a config change. Right now the JMS onces
connected and disconnect with every message, which causes stress on the JMS provider when
running in high load mode.
2. They should get their 'provider' configuration from the configuration, just
like the listeners. Right now you cannot connect to other JMS providers.
3. The notifiers should get hooked up to the same life cycle management as the listener
infrastructure.
In other words: They really should be 'inverse gateways', the model is broken and
there shouldn't be a distinction between notifying and sending a message via
couriers+listeners. The fact we support different transports (and in different ways) for
notifiers than for the "core" ESB is just wrong.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira