[JBoss JIRA] (JBESB-3722) ActionProcessingPipeline incorrectly uses LOGGER.debug() instead of LOGGER.error() for exceptions
7:41 p.m.
ActionProcessingPipeline incorrectly uses LOGGER.debug() instead of LOGGER.error() for
exceptions
-------------------------------------------------------------------------------------------------
Key: JBESB-3722
URL: https://issues.jboss.org/browse/JBESB-3722
Project: JBoss ESB
Issue Type: Bug
Security Level: Public (Everyone can see)
Affects Versions: 4.10, 4.9, 4.8
Reporter: Ryan LaMothe
For a long time now, we have been trying to figure out why exceptions in our action
pipelines would never log any useful information. It turns out that in the file
ActionProcessingPipeline lines 654-657 declare the wrong logging level.
Current code:
if (LOGGER.isDebugEnabled())
{
LOGGER.debug("Unexpected exception caught while processing the action
pipeline",ex);
}
Suggested fix:
// if (LOGGER.isDebugEnabled())
// {
LOGGER.error("Unexpected exception caught while processing the action
pipeline",ex);
// }
Unfortunately, if we simply increase the logging level in JBoss globally for the package
that this file is in, the logs quickly fill up with thousands of lines of unneeded
messages. In production, logging these kinds of error messages really help with
debugging.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:43 p.m.
[
https://issues.jboss.org/browse/JBESB-3722?page=com.atlassian.jira.plugin...
]
Ryan LaMothe updated JBESB-3722:
--------------------------------
Description:
For a long time now, we have been trying to figure out why exceptions in our action
pipelines would never log any useful information. It turns out that in the file
ActionProcessingPipeline lines 654-657 declare the wrong logging level.
Current code:
{code:title=ActionProcessingPipeline.java|borderStyle=solid}
if (LOGGER.isDebugEnabled())
{
LOGGER.debug("Unexpected exception caught while processing the action
pipeline",ex);
}
{code}
Suggested fix:
{code:title=ActionProcessingPipeline.java|borderStyle=solid}
// if (LOGGER.isDebugEnabled())
// {
LOGGER.error("Unexpected exception caught while processing the action
pipeline",ex);
// }
{code}
Unfortunately, if we simply increase the logging level in JBoss globally for the package
that this file is in, the logs quickly fill up with thousands of lines of unneeded
messages. In production, logging these kinds of error messages really help with
debugging.
was:
For a long time now, we have been trying to figure out why exceptions in our action
pipelines would never log any useful information. It turns out that in the file
ActionProcessingPipeline lines 654-657 declare the wrong logging level.
Current code:
if (LOGGER.isDebugEnabled())
{
LOGGER.debug("Unexpected exception caught while processing the action
pipeline",ex);
}
Suggested fix:
// if (LOGGER.isDebugEnabled())
// {
LOGGER.error("Unexpected exception caught while processing the action
pipeline",ex);
// }
Unfortunately, if we simply increase the logging level in JBoss globally for the package
that this file is in, the logs quickly fill up with thousands of lines of unneeded
messages. In production, logging these kinds of error messages really help with
debugging.
ActionProcessingPipeline incorrectly uses LOGGER.debug() instead of
LOGGER.error() for exceptions
-------------------------------------------------------------------------------------------------
Key: JBESB-3722
URL: https://issues.jboss.org/browse/JBESB-3722
Project: JBoss ESB
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 4.8, 4.9, 4.10
Reporter: Ryan LaMothe
For a long time now, we have been trying to figure out why exceptions in our action
pipelines would never log any useful information. It turns out that in the file
ActionProcessingPipeline lines 654-657 declare the wrong logging level.
Current code:
{code:title=ActionProcessingPipeline.java|borderStyle=solid}
if (LOGGER.isDebugEnabled())
{
LOGGER.debug("Unexpected exception caught while processing the action
pipeline",ex);
}
{code}
Suggested fix:
{code:title=ActionProcessingPipeline.java|borderStyle=solid}
// if (LOGGER.isDebugEnabled())
// {
LOGGER.error("Unexpected exception caught while processing the action
pipeline",ex);
// }
{code}
Unfortunately, if we simply increase the logging level in JBoss globally for the package
that this file is in, the logs quickly fill up with thousands of lines of unneeded
messages. In production, logging these kinds of error messages really help with debugging.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:23 a.m.
[
https://issues.jboss.org/browse/JBESB-3722?page=com.atlassian.jira.plugin...
]
Kevin Conner commented on JBESB-3722:
-------------------------------------
Debug is the intended logging level for this as the normal processing behaviour then
continues to send the fault message to the caller of the service or store it within the
DLQ.
If you want to log these at a different logging level then it is easy to achieve, simply
create an action that does no processing and have the processException method log the
exception however you wish. This should be your first action in each pipeline you wish to
modify.
ActionProcessingPipeline incorrectly uses LOGGER.debug() instead of
LOGGER.error() for exceptions
-------------------------------------------------------------------------------------------------
Key: JBESB-3722
URL: https://issues.jboss.org/browse/JBESB-3722
Project: JBoss ESB
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 4.8, 4.9, 4.10
Reporter: Ryan LaMothe
For a long time now, we have been trying to figure out why exceptions in our action
pipelines would never log any useful information. It turns out that in the file
ActionProcessingPipeline lines 654-657 declare the wrong logging level.
Current code:
{code:title=ActionProcessingPipeline.java|borderStyle=solid}
if (LOGGER.isDebugEnabled())
{
LOGGER.debug("Unexpected exception caught while processing the action
pipeline",ex);
}
{code}
Suggested fix:
{code:title=ActionProcessingPipeline.java|borderStyle=solid}
// if (LOGGER.isDebugEnabled())
// {
LOGGER.error("Unexpected exception caught while processing the action
pipeline",ex);
// }
{code}
Unfortunately, if we simply increase the logging level in JBoss globally for the package
that this file is in, the logs quickly fill up with thousands of lines of unneeded
messages. In production, logging these kinds of error messages really help with debugging.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
5210
days inactive
5222
days old
2 comments
3 participants
participants (3)
-
Kevin Conner (Commented) (JIRA) -
Ryan LaMothe (Created) (JIRA)
-
Ryan LaMothe (Updated) (JIRA)