[JBoss JIRA] Created: (JBESB-2905) FtpImpl timeout global and not always respected
by Tom Eicher (JIRA)
FtpImpl timeout global and not always respected
-----------------------------------------------
Key: JBESB-2905
URL: https://jira.jboss.org/jira/browse/JBESB-2905
Project: JBoss ESB
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: Transports
Affects Versions: 4.6, 4.5
Reporter: Tom Eicher
org.jboss.internal.soa.esb.util.FtpImpl does look for a property org.jboss.soa.esb.ftp.timeout in jbossesb.sar/jbossesb-properties.xml, however:
it does so only in 1 out of 3 constructors! ;-)
code "String timeout = ModulePropertyManager..." should be moved from the "public FtpImpl (FTPEpr p_oP)"
to the "protected void initialize (boolean bConnect)".
other parameters in the 3 constructor should also be checked if they are respected in all three cases.
Also:
- "infinite" is not so good a default, as the thread will hang forever in case of firewall issues (I have one 48hrs old now ;-)
even a ridiculous long one like 6hrs woule be better...("_timeout = 0;" in 2 places)
- please add "<property name="org.jboss.soa.esb.ftp.timeout" value="60000"/>" to the default jbossesb-properties.xml
so that people may know that this setting exists
- please also allow configuration of timeout from ConfigTree (method "checkParams()" and Constant in "RemoteFileSystem")
and from FileEpr. (and then add to doc ;-)
Cheers & kind regards,
Tom.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
14 years