[JBoss JIRA] (JBESB-3942) OGNLUtils.assertIsCollection() incorrectly interprets "Zero or more repetitions" comments in front of non-repeatable field
by RH Bugzilla Integration (JIRA)
[ https://issues.jboss.org/browse/JBESB-3942?page=com.atlassian.jira.plugin... ]
RH Bugzilla Integration commented on JBESB-3942:
------------------------------------------------
tcunning(a)redhat.com changed the Status of [bug 983077|https://bugzilla.redhat.com/show_bug.cgi?id=983077] from NEW to MODIFIED
> OGNLUtils.assertIsCollection() incorrectly interprets "Zero or more repetitions" comments in front of non-repeatable field
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: JBESB-3942
> URL: https://issues.jboss.org/browse/JBESB-3942
> Project: JBoss ESB
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: Web Services
> Affects Versions: 4.12
> Reporter: Tom Cunningham
> Assignee: Tom Cunningham
> Fix For: 4.11 CP3
>
>
> Description of problem:
> * Suppose you have a long WSDL document and only set one single parameter in the request map using OGNL, such as:
> requestMap.put("mutiereGeschaeft.geschaeft.Kredit.KreStatus", "ssss");
> * WSDL snippet:
> <xs:element name='KreStatus' nillable='true' type='xs:string'/>
> * Generated Request - without parameters filed:
> <!--Zero or more repetitions: - cloned-->
>
> <java1:KreStatus>?</java1:KreStatus>
> * org.jboss.internal.soa.esb.soap.OGNLUtils.assertIsCollection() checks for this:
> if(commentBefore != null
> && (commentBefore.getTextContent().endsWith(SOAPUI_CLONE_COMMENT)
> || commentBefore.getTextContent().endsWith(SOAPUI_CLONE_COMMENT + CLONED_POSTFIX))) {
> return true;
> }
> which is true and this causes this parameter to not be filled at all. If
> mutiereGeschaeft.geschaeft.Kredit.KreStatus[0] is used, the parameter will be correctly filled.
> We need to make sure that assertIsCollection(), possibly assertIsParentCollection() also checks if the element can be repeated, or somehow else make sure that we actually have repeated the element and not some other elements.
> Version-Release number of selected component (if applicable):
> - JBoss SOA-P 5.3.1
> How reproducible:
> Always
> Steps to Reproduce:
> 1. Using attached modified quickstart
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 9 months
[JBoss JIRA] (JBESB-3942) OGNLUtils.assertIsCollection() incorrectly interprets "Zero or more repetitions" comments in front of non-repeatable field
by RH Bugzilla Integration (JIRA)
[ https://issues.jboss.org/browse/JBESB-3942?page=com.atlassian.jira.plugin... ]
RH Bugzilla Integration commented on JBESB-3942:
------------------------------------------------
tcunning(a)redhat.com made a comment on [bug 983077|https://bugzilla.redhat.com/show_bug.cgi?id=983077]
The issue doesn't seem to be with OGNLUtils.assertIsCollection, the issue seems to be with removing elements in SoapUIClientService - when removing elements, we were leaving behind comments associated to that element.
> OGNLUtils.assertIsCollection() incorrectly interprets "Zero or more repetitions" comments in front of non-repeatable field
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: JBESB-3942
> URL: https://issues.jboss.org/browse/JBESB-3942
> Project: JBoss ESB
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: Web Services
> Affects Versions: 4.12
> Reporter: Tom Cunningham
> Assignee: Tom Cunningham
> Fix For: 4.11 CP3
>
>
> Description of problem:
> * Suppose you have a long WSDL document and only set one single parameter in the request map using OGNL, such as:
> requestMap.put("mutiereGeschaeft.geschaeft.Kredit.KreStatus", "ssss");
> * WSDL snippet:
> <xs:element name='KreStatus' nillable='true' type='xs:string'/>
> * Generated Request - without parameters filed:
> <!--Zero or more repetitions: - cloned-->
>
> <java1:KreStatus>?</java1:KreStatus>
> * org.jboss.internal.soa.esb.soap.OGNLUtils.assertIsCollection() checks for this:
> if(commentBefore != null
> && (commentBefore.getTextContent().endsWith(SOAPUI_CLONE_COMMENT)
> || commentBefore.getTextContent().endsWith(SOAPUI_CLONE_COMMENT + CLONED_POSTFIX))) {
> return true;
> }
> which is true and this causes this parameter to not be filled at all. If
> mutiereGeschaeft.geschaeft.Kredit.KreStatus[0] is used, the parameter will be correctly filled.
> We need to make sure that assertIsCollection(), possibly assertIsParentCollection() also checks if the element can be repeated, or somehow else make sure that we actually have repeated the element and not some other elements.
> Version-Release number of selected component (if applicable):
> - JBoss SOA-P 5.3.1
> How reproducible:
> Always
> Steps to Reproduce:
> 1. Using attached modified quickstart
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 9 months
[JBoss JIRA] (JBESB-3942) OGNLUtils.assertIsCollection() incorrectly interprets "Zero or more repetitions" comments in front of non-repeatable field
by Tom Cunningham (JIRA)
[ https://issues.jboss.org/browse/JBESB-3942?page=com.atlassian.jira.plugin... ]
Tom Cunningham resolved JBESB-3942.
-----------------------------------
Resolution: Done
When elements were being removed from the template in SoapUIClientService, the comments associated with that element were not being removed. Make sure to remove comments when removing an element.
> OGNLUtils.assertIsCollection() incorrectly interprets "Zero or more repetitions" comments in front of non-repeatable field
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: JBESB-3942
> URL: https://issues.jboss.org/browse/JBESB-3942
> Project: JBoss ESB
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: Web Services
> Affects Versions: 4.12
> Reporter: Tom Cunningham
> Assignee: Tom Cunningham
> Fix For: 4.11 CP3
>
>
> Description of problem:
> * Suppose you have a long WSDL document and only set one single parameter in the request map using OGNL, such as:
> requestMap.put("mutiereGeschaeft.geschaeft.Kredit.KreStatus", "ssss");
> * WSDL snippet:
> <xs:element name='KreStatus' nillable='true' type='xs:string'/>
> * Generated Request - without parameters filed:
> <!--Zero or more repetitions: - cloned-->
>
> <java1:KreStatus>?</java1:KreStatus>
> * org.jboss.internal.soa.esb.soap.OGNLUtils.assertIsCollection() checks for this:
> if(commentBefore != null
> && (commentBefore.getTextContent().endsWith(SOAPUI_CLONE_COMMENT)
> || commentBefore.getTextContent().endsWith(SOAPUI_CLONE_COMMENT + CLONED_POSTFIX))) {
> return true;
> }
> which is true and this causes this parameter to not be filled at all. If
> mutiereGeschaeft.geschaeft.Kredit.KreStatus[0] is used, the parameter will be correctly filled.
> We need to make sure that assertIsCollection(), possibly assertIsParentCollection() also checks if the element can be repeated, or somehow else make sure that we actually have repeated the element and not some other elements.
> Version-Release number of selected component (if applicable):
> - JBoss SOA-P 5.3.1
> How reproducible:
> Always
> Steps to Reproduce:
> 1. Using attached modified quickstart
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 9 months
[JBoss JIRA] (JBESB-3942) OGNLUtils.assertIsCollection() incorrectly interprets "Zero or more repetitions" comments in front of non-repeatable field
by Tom Cunningham (JIRA)
[ https://issues.jboss.org/browse/JBESB-3942?page=com.atlassian.jira.plugin... ]
Tom Cunningham closed JBESB-3942.
---------------------------------
> OGNLUtils.assertIsCollection() incorrectly interprets "Zero or more repetitions" comments in front of non-repeatable field
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: JBESB-3942
> URL: https://issues.jboss.org/browse/JBESB-3942
> Project: JBoss ESB
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: Web Services
> Affects Versions: 4.12
> Reporter: Tom Cunningham
> Assignee: Tom Cunningham
> Fix For: 4.11 CP3
>
>
> Description of problem:
> * Suppose you have a long WSDL document and only set one single parameter in the request map using OGNL, such as:
> requestMap.put("mutiereGeschaeft.geschaeft.Kredit.KreStatus", "ssss");
> * WSDL snippet:
> <xs:element name='KreStatus' nillable='true' type='xs:string'/>
> * Generated Request - without parameters filed:
> <!--Zero or more repetitions: - cloned-->
>
> <java1:KreStatus>?</java1:KreStatus>
> * org.jboss.internal.soa.esb.soap.OGNLUtils.assertIsCollection() checks for this:
> if(commentBefore != null
> && (commentBefore.getTextContent().endsWith(SOAPUI_CLONE_COMMENT)
> || commentBefore.getTextContent().endsWith(SOAPUI_CLONE_COMMENT + CLONED_POSTFIX))) {
> return true;
> }
> which is true and this causes this parameter to not be filled at all. If
> mutiereGeschaeft.geschaeft.Kredit.KreStatus[0] is used, the parameter will be correctly filled.
> We need to make sure that assertIsCollection(), possibly assertIsParentCollection() also checks if the element can be repeated, or somehow else make sure that we actually have repeated the element and not some other elements.
> Version-Release number of selected component (if applicable):
> - JBoss SOA-P 5.3.1
> How reproducible:
> Always
> Steps to Reproduce:
> 1. Using attached modified quickstart
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 9 months